Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonos] Add speechenhancement channel for Sonos One #7484

Merged
merged 5 commits into from
May 1, 2020

Conversation

mindstorms6
Copy link

[sonos] - Add speechancement channel to Sonos One devices because they also have a Mic ( https://www.sonos.com/en-us/shop/one.html )

Just adds the existing speechenhancement property to the Sonos One Devices - they also have a built in microphone for use with Alexa/Google Assistant.
The same channel and handlers already existed for other sonos devices.
Also updated the README to reflect this change.

@mindstorms6
Copy link
Author

I wasn't sure if it's useful to split/create a new thing for the OneSL versus the One.

@TravisBuddy
Copy link

Travis tests were successful

Hey @mindstorms6,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

1 similar comment
@TravisBuddy
Copy link

Travis tests were successful

Hey @mindstorms6,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@lolodomo
Copy link
Contributor

One and OneSL are sharing the same thing type. Take a look in the discovery code.
So if the channels are now different between One and OneSL, yes I think we should split them and create a new thing type for OneSL.

@mindstorms6
Copy link
Author

Hey thanks for the feedback @lolodomo

Looks like we intentionally collapse the One SL into the One thing type:

I'm happy to remove this and add a separate thing for the OneSL - but my only concern is I don't have a One SL currently so my real world testing will be relying on someone who has one.

I'll make the changes requested. Thanks!

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisBuddy
Copy link

Travis tests have failed

Hey @mindstorms6,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

@TravisBuddy
Copy link

Travis tests have failed

Hey @mindstorms6,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

Signed-off-by: Breland Miley <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @mindstorms6,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

1 similar comment
@TravisBuddy
Copy link

Travis tests were successful

Hey @mindstorms6,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@cpmeister cpmeister added the enhancement An enhancement or new feature for an existing add-on label May 1, 2020
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit e3489f2 into openhab:2.5.x May 1, 2020
@cpmeister cpmeister added this to the 2.5.5 milestone May 1, 2020
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
* [sonos] Add speechenhancement channel for Sonos One

Signed-off-by: Breland Miley <[email protected]>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
* [sonos] Add speechenhancement channel for Sonos One

Signed-off-by: Breland Miley <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
* [sonos] Add speechenhancement channel for Sonos One

Signed-off-by: Breland Miley <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* [sonos] Add speechenhancement channel for Sonos One

Signed-off-by: Breland Miley <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* [sonos] Add speechenhancement channel for Sonos One

Signed-off-by: Breland Miley <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* [sonos] Add speechenhancement channel for Sonos One

Signed-off-by: Breland Miley <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* [sonos] Add speechenhancement channel for Sonos One

Signed-off-by: Breland Miley <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
* [sonos] Add speechenhancement channel for Sonos One

Signed-off-by: Breland Miley <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
* [sonos] Add speechenhancement channel for Sonos One

Signed-off-by: Breland Miley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants