-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sonos] Add speechenhancement channel for Sonos One #7484
Conversation
Signed-off-by: Breland Miley <[email protected]>
I wasn't sure if it's useful to split/create a new thing for the OneSL versus the One. |
Travis tests were successfulHey @mindstorms6, |
1 similar comment
Travis tests were successfulHey @mindstorms6, |
One and OneSL are sharing the same thing type. Take a look in the discovery code. |
Hey thanks for the feedback @lolodomo Looks like we intentionally collapse the Lines 88 to 90 in 7628135
I'm happy to remove this and add a separate thing for the I'll make the changes requested. Thanks! |
Signed-off-by: Breland Miley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Travis tests have failedHey @mindstorms6, |
Signed-off-by: Breland Miley <[email protected]>
Travis tests have failedHey @mindstorms6, |
Signed-off-by: Breland Miley <[email protected]>
Travis tests were successfulHey @mindstorms6, |
1 similar comment
Travis tests were successfulHey @mindstorms6, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [sonos] Add speechenhancement channel for Sonos One Signed-off-by: Breland Miley <[email protected]>
* [sonos] Add speechenhancement channel for Sonos One Signed-off-by: Breland Miley <[email protected]>
* [sonos] Add speechenhancement channel for Sonos One Signed-off-by: Breland Miley <[email protected]> Signed-off-by: CSchlipp <[email protected]>
* [sonos] Add speechenhancement channel for Sonos One Signed-off-by: Breland Miley <[email protected]>
* [sonos] Add speechenhancement channel for Sonos One Signed-off-by: Breland Miley <[email protected]>
* [sonos] Add speechenhancement channel for Sonos One Signed-off-by: Breland Miley <[email protected]>
* [sonos] Add speechenhancement channel for Sonos One Signed-off-by: Breland Miley <[email protected]>
* [sonos] Add speechenhancement channel for Sonos One Signed-off-by: Breland Miley <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
* [sonos] Add speechenhancement channel for Sonos One Signed-off-by: Breland Miley <[email protected]>
[sonos] - Add speechancement channel to Sonos One devices because they also have a Mic ( https://www.sonos.com/en-us/shop/one.html )
Just adds the existing
speechenhancement
property to the Sonos One Devices - they also have a built in microphone for use with Alexa/Google Assistant.The same channel and handlers already existed for other sonos devices.
Also updated the README to reflect this change.