-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[miio] add gosund plug & Vacuum 1C STYTJ01ZHM #7452
Conversation
Add 2 miot devices Vacuum 1C STYTJ01ZHM dreame.vacuum.mc1808 cuco goplug cuco.plug.cp1 Signed-off-by: Marcel Verpaalen <[email protected]>
Travis tests were successfulHey @marcelrv, |
| TotalCleanArea | String | clean- | | ||
| CleanLogStartTime | String | clean- | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description is missing for these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep. fixed
| LifeSieve | String | consumable-life-sieve | | ||
| LifeBrushSide | String | consumable-life-brush-side | | ||
| LifeBrushMain | String | consumable-life-brush-main | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these supposed to be percentage values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see the long comment below
| TotalCleanTime | String | clean-total time | | ||
| TotalCleanTimes | String | clean-total times | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the difference between these fields? Can they be Number:Time
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I don't know. see the long comment below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But, given the names, I expect that the one is the (clock) time of the cleaning and the other the amount of times the machine has cleaned. Similar counts are for the other Xiaomi vacuum cleaners available.
btw, it is still on my wish list #7276 to have the binding deal with Number:Time
sort of notation. I expect it is not a huge effort, but I have not looked deeper into it what would be the detailed impact to the updating process and the possible impact in handling of the commands
Hallo @cpmeister This is a so called miot device, which is following the new protocol Xiaomi is trying to implement for their devices. (I think they are slowly moving all their devices to it) For these devices they publish the definitions e.g. for the vacuum here. The OH database json file is a translation of that file, incl the data types. In the end my intention is that these can be added directly by the user in the miio:unsupported handler ( #7276 ) But before that, I want to give it a try for a few devices to see if it gives meaningful results. note, the list of devices that support this (miot) protocol is already rather big (total list of Xiaomi devices >1500 by now) One meter intelligent curtain (090615.curtain.1mcu01) |
Signed-off-by: Marcel Verpaalen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Travis tests were successfulHey @marcelrv, |
* [miio] add gosund plug & Vacuum 1C STYTJ01ZHM Add 2 miot devices Vacuum 1C STYTJ01ZHM dreame.vacuum.mc1808 cuco goplug cuco.plug.cp1 * [miio] add missing channel descriptions Signed-off-by: Marcel Verpaalen <[email protected]> Signed-off-by: Eugen Freiter <[email protected]>
* [miio] add gosund plug & Vacuum 1C STYTJ01ZHM Add 2 miot devices Vacuum 1C STYTJ01ZHM dreame.vacuum.mc1808 cuco goplug cuco.plug.cp1 * [miio] add missing channel descriptions Signed-off-by: Marcel Verpaalen <[email protected]>
* [miio] add gosund plug & Vacuum 1C STYTJ01ZHM Add 2 miot devices Vacuum 1C STYTJ01ZHM dreame.vacuum.mc1808 cuco goplug cuco.plug.cp1 * [miio] add missing channel descriptions Signed-off-by: Marcel Verpaalen <[email protected]>
* [miio] add gosund plug & Vacuum 1C STYTJ01ZHM Add 2 miot devices Vacuum 1C STYTJ01ZHM dreame.vacuum.mc1808 cuco goplug cuco.plug.cp1 * [miio] add missing channel descriptions Signed-off-by: Marcel Verpaalen <[email protected]> Signed-off-by: CSchlipp <[email protected]>
* [miio] add gosund plug & Vacuum 1C STYTJ01ZHM Add 2 miot devices Vacuum 1C STYTJ01ZHM dreame.vacuum.mc1808 cuco goplug cuco.plug.cp1 * [miio] add missing channel descriptions Signed-off-by: Marcel Verpaalen <[email protected]>
* [miio] add gosund plug & Vacuum 1C STYTJ01ZHM Add 2 miot devices Vacuum 1C STYTJ01ZHM dreame.vacuum.mc1808 cuco goplug cuco.plug.cp1 * [miio] add missing channel descriptions Signed-off-by: Marcel Verpaalen <[email protected]>
* [miio] add gosund plug & Vacuum 1C STYTJ01ZHM Add 2 miot devices Vacuum 1C STYTJ01ZHM dreame.vacuum.mc1808 cuco goplug cuco.plug.cp1 * [miio] add missing channel descriptions Signed-off-by: Marcel Verpaalen <[email protected]>
* [miio] add gosund plug & Vacuum 1C STYTJ01ZHM Add 2 miot devices Vacuum 1C STYTJ01ZHM dreame.vacuum.mc1808 cuco goplug cuco.plug.cp1 * [miio] add missing channel descriptions Signed-off-by: Marcel Verpaalen <[email protected]>
* [miio] add gosund plug & Vacuum 1C STYTJ01ZHM Add 2 miot devices Vacuum 1C STYTJ01ZHM dreame.vacuum.mc1808 cuco goplug cuco.plug.cp1 * [miio] add missing channel descriptions Signed-off-by: Marcel Verpaalen <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
* [miio] add gosund plug & Vacuum 1C STYTJ01ZHM Add 2 miot devices Vacuum 1C STYTJ01ZHM dreame.vacuum.mc1808 cuco goplug cuco.plug.cp1 * [miio] add missing channel descriptions Signed-off-by: Marcel Verpaalen <[email protected]>
[miio] add gosund plug & Vacuum 1C STYTJ01ZHM
Add 2 miot devices
Vacuum 1C STYTJ01ZHM dreame.vacuum.mc1808
cuco goplug cuco.plug.cp1
Signed-off-by: Marcel Verpaalen [email protected]