Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[insteon] Add support for Beep and LED on/off features to Dimmer Modules(2457D2), On/Off Modules(2635-222), and On/Off Outdoor Modules(2634-222) #7295

Merged
merged 11 commits into from
Apr 5, 2020
Merged

[insteon] Add support for Beep and LED on/off features to Dimmer Modules(2457D2), On/Off Modules(2635-222), and On/Off Outdoor Modules(2634-222) #7295

merged 11 commits into from
Apr 5, 2020

Conversation

tommycw1
Copy link

@tommycw1 tommycw1 commented Apr 4, 2020

This is connected to issue 7294

#7294

tommycw1 added 11 commits March 25, 2020 21:50
@tommycw1
Added Beep and LED On/Off to dimmers switches (and keypad dimmers and…
9aa3134 
… switches). Also added Dawn/Dusk and LowBattery to motion detectors.

Signed-off-by: Tom Weichmann <[email protected]>
@tommycw1
Added Beep and LED On/Off as channels
915943e 
Signed-off-by: Tom Weichmann <[email protected]>
@tommycw1
Added Beep and LED On/Off channels to README.md
ded4e5c 
Signed-off-by: Tom Weichmann <[email protected]>
@tommycw1
Added Motion Sensor Dawn/Dusk and Low Batt as channels and to README.md
d690e46 
Signed-off-by: Tom Weichmann <[email protected]>
@tommycw1
Changed a few variable names to better match standard and removed com…
7f4aaef 
…mented out code.

Signed-off-by: Tom Weichmann <[email protected]>
@tommycw1
Chnged variable for light sensor above threshold to betther match sta…
a73965d 
…ndard and fixed formatting to better match standard

Signed-off-by: Tom Weichmann <[email protected]>
@tommycw1
Changed WirelessMotionSensorLightlevelabovethreshold to WirelessMotio…
d3db24e 
…nSensorLightLevelAboveThreshold per request

Signed-off-by: Tom Weichmann <[email protected]>
@tommycw1
Changed WirelessMotionSensorLowbattery to WirelessMotionSensorLowBatt…
1a482f9 
…ery per request

Signed-off-by: Tom Weichmann <[email protected]>
@tommycw1
Added some formatting changes to ensure docs match code and to al cod…
315e8c3 
…e to match Eclipse formatting

Signed-off-by: Tom Weichmann <[email protected]>
@tommycw1
Merge remote-tracking branch 'upstream/2.5.x' into 2.5.x
ce3801c
@tommycw1
Added LED On/Off and Beep to Dimmer Modules (2457D2), On/Off Modules …
af77bb5 
…(2635-222), and On/Off Outdoor Modules (2634-222)

Signed-off-by: Tom Weichmann <[email protected]>
@tommycw1 tommycw1 requested a review from robnielsen as a code owner April 4, 2020 22:49
@TravisBuddy
Copy link

Travis tests were successful

Hey @tommycw1,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@robnielsen
Copy link
Contributor

@tommycw1, this PR appears to include a the previous commits from the PR that was approved.

@cpmeister cpmeister linked an issue Apr 4, 2020 that may be closed by this pull request
[insteon] Add support for Beep and LED on/off features to Dimmer Modules(2457D2), On/Off Modules(2635-222), and On/Off Outdoor Modules(2634-222) #7294
Closed
@cpmeister cpmeister added the enhancement An enhancement or new feature for an existing add-on label Apr 4, 2020
robnielsen
robnielsen approved these changes Apr 5, 2020
View reviewed changes
Copy link
Contributor

@robnielsen robnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @cpmeister the PR says there are 11 commits, but they are from the prior PR. Any concerns with this?

cpmeister
cpmeister approved these changes Apr 5, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
It doesn't matter how many commits there are since only the final differences between the two branches are considered. Merging squashes the commits into a single commit anyway.

@cpmeister cpmeister merged commit b891413 into openhab:2.5.x Apr 5, 2020
@cpmeister cpmeister added this to the 2.5.4 milestone Apr 5, 2020
Hans-Reiner pushed a commit to Hans-Reiner/openhab2-addons that referenced this pull request Apr 11, 2020
@tommycw1 @Hans-Reiner
[insteon] Add support for Beep and LED on/off features to various mod…
157116e 
…ules (openhab#7295)

* Add support for Beep and LED on/off features to Dimmer Modules(2457D2), On/Off Modules(2635-222), and On/Off Outdoor Modules(2634-222)

Signed-off-by: Tom Weichmann <[email protected]>
Signed-off-by: Hans-Reiner Hoffmann <[email protected]>
yfre pushed a commit to yfre/openhab-addons that referenced this pull request Apr 27, 2020
@tommycw1
[insteon] Add support for Beep and LED on/off features to various mod…
7c5ab37 
…ules (openhab#7295)

* Add support for Beep and LED on/off features to Dimmer Modules(2457D2), On/Off Modules(2635-222), and On/Off Outdoor Modules(2634-222)

Signed-off-by: Tom Weichmann <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request May 29, 2020
@tommycw1 @markus7017
[insteon] Add support for Beep and LED on/off features to various mod…
ea9f764 
…ules (openhab#7295)

* Add support for Beep and LED on/off features to Dimmer Modules(2457D2), On/Off Modules(2635-222), and On/Off Outdoor Modules(2634-222)

Signed-off-by: Tom Weichmann <[email protected]>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
@tommycw1 @LoungeFlyZ
[insteon] Add support for Beep and LED on/off features to various mod…
a1a47ad 
…ules (openhab#7295)

* Add support for Beep and LED on/off features to Dimmer Modules(2457D2), On/Off Modules(2635-222), and On/Off Outdoor Modules(2634-222)

Signed-off-by: Tom Weichmann <[email protected]>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@tommycw1 @J-N-K
[insteon] Add support for Beep and LED on/off features to various mod…
d2a0a2e 
…ules (openhab#7295)

* Add support for Beep and LED on/off features to Dimmer Modules(2457D2), On/Off Modules(2635-222), and On/Off Outdoor Modules(2634-222)

Signed-off-by: Tom Weichmann <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@tommycw1 @CSchlipp
[insteon] Add support for Beep and LED on/off features to various mod…
0ec7fae 
…ules (openhab#7295)

* Add support for Beep and LED on/off features to Dimmer Modules(2457D2), On/Off Modules(2635-222), and On/Off Outdoor Modules(2634-222)

Signed-off-by: Tom Weichmann <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@tommycw1 @andrewfg
[insteon] Add support for Beep and LED on/off features to various mod…
7365c26 
…ules (openhab#7295)

* Add support for Beep and LED on/off features to Dimmer Modules(2457D2), On/Off Modules(2635-222), and On/Off Outdoor Modules(2634-222)

Signed-off-by: Tom Weichmann <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@tommycw1 @andrewfg
[insteon] Add support for Beep and LED on/off features to various mod…
07cc31a 
…ules (openhab#7295)

* Add support for Beep and LED on/off features to Dimmer Modules(2457D2), On/Off Modules(2635-222), and On/Off Outdoor Modules(2634-222)

Signed-off-by: Tom Weichmann <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@tommycw1 @andrewfg
[insteon] Add support for Beep and LED on/off features to various mod…
5304941 
…ules (openhab#7295)

* Add support for Beep and LED on/off features to Dimmer Modules(2457D2), On/Off Modules(2635-222), and On/Off Outdoor Modules(2634-222)

Signed-off-by: Tom Weichmann <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@tommycw1 @andrewfg
[insteon] Add support for Beep and LED on/off features to various mod…
a7617d4 
…ules (openhab#7295)

* Add support for Beep and LED on/off features to Dimmer Modules(2457D2), On/Off Modules(2635-222), and On/Off Outdoor Modules(2634-222)

Signed-off-by: Tom Weichmann <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@tommycw1 @DaanMeijer
[insteon] Add support for Beep and LED on/off features to various mod…
e48932b 
…ules (openhab#7295)

* Add support for Beep and LED on/off features to Dimmer Modules(2457D2), On/Off Modules(2635-222), and On/Off Outdoor Modules(2634-222)

Signed-off-by: Tom Weichmann <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@tommycw1 @markus7017
[insteon] Add support for Beep and LED on/off features to various mod…
7f56006 
…ules (openhab#7295)

* Add support for Beep and LED on/off features to Dimmer Modules(2457D2), On/Off Modules(2635-222), and On/Off Outdoor Modules(2634-222)

Signed-off-by: Tom Weichmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

@robnielsen robnielsen robnielsen approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
2.5.4
4 participants
@tommycw1 @TravisBuddy @robnielsen @cpmeister