[satel] Action for reading the event log added #7282

druciak · 2020-04-04T12:40:44Z

This PR add a rule action for reading records from the event log. It replaces current way of reading the log using items linked to channels of event-log thing. This is still available but marked as deprecated.

It also contains minor changes in README file.

Signed-off-by: Krzysztof Goworek [email protected]

TravisBuddy · 2020-04-04T12:43:41Z

Travis tests were successful

Hey @druciak,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

J-N-K · 2020-04-04T13:13:01Z

bundles/org.openhab.binding.satel/README.md

+        eventIdx = eventRec.get("prev_index")
+    ]
+    logInfo("EventLog", "End")
+    getActions("mail","mail:smtp:local").sendMail("[email protected]", "Event log", msgBody)


Maybe add a note seomwhere that this requires the mail binding.

This is just an example. The purpose of the action is to read single record from the event log. It does not specify what one should do with the result.

True. I was just thinking that someone installs satel, adds this example and runs into an error. Maybe a comment in the line above this one like sending notifications via mail requires the mail binding or something like that would be good.

J-N-K · 2020-04-04T13:14:34Z

...ing.satel/src/main/java/org/openhab/binding/satel/internal/handler/SatelEventLogHandler.java

+    /**
+     * Represents single record of the event log.
+     *
+     * @author kgoworek


Please use a real name here

...ing.satel/src/main/java/org/openhab/binding/satel/internal/handler/SatelEventLogHandler.java

TravisBuddy · 2020-04-04T13:43:47Z

Travis tests were successful

Hey @druciak,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

J-N-K · 2020-04-04T13:55:50Z

bundles/org.openhab.binding.satel/README.md

@@ -55,6 +55,8 @@ Example:
 Bridge satel:ethm-1:home [ host="192.168.0.2", refresh=1000, userCode="1234", encryptionKey="abcdefgh" ]
 ```

+**NOTE:** There can be only one client connected to ETHM-1 module. It does not accept new connections if there is already a connection established. In case you have troubles connecting to the system using this module, please make sure there is no other client (for example installed 1.x version of the binding) already connected to it.


Please use a new line for each sentence. They are concatenated automatically.

J-N-K · 2020-04-04T13:56:01Z

bundles/org.openhab.binding.satel/README.md

+
+### readEvent
+
+This action allows you to read one record from the event log placed at index given by input parameter. The result of this action is compatible with channels of `event-log` thing and contains following values:


J-N-K · 2020-04-04T13:57:26Z

bundles/org.openhab.binding.satel/README.md

+        eventIdx = eventRec.get("prev_index")
+    ]
+    logInfo("EventLog", "End")
+    getActions("mail","mail:smtp:local").sendMail("[email protected]", "Event log", msgBody)


True. I was just thinking that someone installs satel, adds this example and runs into an error. Maybe a comment in the line above this one like sending notifications via mail requires the mail binding or something like that would be good.

Signed-off-by: Krzysztof Goworek <[email protected]>

TravisBuddy · 2020-04-04T17:27:04Z

Travis tests were successful

Hey @druciak,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

druciak · 2020-04-05T07:36:24Z

@J-N-K I think I resolved all your comments. Could you please look at the code if there's still something to fix?

J-N-K

Please add the breaking change to this file: https://github.com/openhab/openhab-distro/blob/master/distributions/openhab/src/main/resources/bin/update.lst

druciak · 2020-04-05T14:24:35Z

Thanks for merging this PR so quickly.

Please add the breaking change to this file: https://github.com/openhab/openhab-distro/blob/master/distributions/openhab/src/main/resources/bin/update.lst

The old way is still available, should I add breaking change in such case as well?

Related to openhab/openhab-addons#7282 Signed-off-by: Krzysztof Goworek <[email protected]>

Signed-off-by: Krzysztof Goworek <[email protected]> Signed-off-by: Hans-Reiner Hoffmann <[email protected]>

Signed-off-by: Krzysztof Goworek <[email protected]> Signed-off-by: Eugen Freiter <[email protected]>

Signed-off-by: Krzysztof Goworek <[email protected]>

Signed-off-by: Krzysztof Goworek <[email protected]> Signed-off-by: CSchlipp <[email protected]>

Signed-off-by: Krzysztof Goworek <[email protected]>

Signed-off-by: Krzysztof Goworek <[email protected]> Signed-off-by: Daan Meijer <[email protected]>

Signed-off-by: Krzysztof Goworek <[email protected]>

druciak added the enhancement An enhancement or new feature for an existing add-on label Apr 4, 2020

druciak requested review from Hilbrand, mhilbush and J-N-K April 4, 2020 12:42

J-N-K requested changes Apr 4, 2020

View reviewed changes

druciak force-pushed the satel_binding branch from 132ae73 to 3ecc281 Compare April 4, 2020 13:41

J-N-K requested changes Apr 4, 2020

View reviewed changes

[satel] Action for reading the event log added

025200c

Signed-off-by: Krzysztof Goworek <[email protected]>

druciak force-pushed the satel_binding branch from 3ecc281 to 025200c Compare April 4, 2020 17:24

J-N-K approved these changes Apr 5, 2020

View reviewed changes

J-N-K merged commit 3b49fb9 into openhab:2.5.x Apr 5, 2020

cpmeister added this to the 2.5.4 milestone Apr 5, 2020

druciak mentioned this pull request Apr 7, 2020

Added message for satel binding openhab/openhab-distro#1100

Merged

cweitkamp pushed a commit to openhab/openhab-distro that referenced this pull request Apr 8, 2020

Added message for satel binding (#1100)

478c6b5

Related to openhab/openhab-addons#7282 Signed-off-by: Krzysztof Goworek <[email protected]>

Hans-Reiner pushed a commit to Hans-Reiner/openhab2-addons that referenced this pull request Apr 11, 2020

[satel] Action for reading the event log added (openhab#7282)

f639ee1

Signed-off-by: Krzysztof Goworek <[email protected]> Signed-off-by: Hans-Reiner Hoffmann <[email protected]>

yfre pushed a commit to yfre/openhab-addons that referenced this pull request Apr 27, 2020

[satel] Action for reading the event log added (openhab#7282)

1eba620

Signed-off-by: Krzysztof Goworek <[email protected]> Signed-off-by: Eugen Freiter <[email protected]>

markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request May 29, 2020

[satel] Action for reading the event log added (openhab#7282)

c24a9ec

Signed-off-by: Krzysztof Goworek <[email protected]>

LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020

[satel] Action for reading the event log added (openhab#7282)

016015b

Signed-off-by: Krzysztof Goworek <[email protected]>

J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020

[satel] Action for reading the event log added (openhab#7282)

44d2f32

Signed-off-by: Krzysztof Goworek <[email protected]>

CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020

[satel] Action for reading the event log added (openhab#7282)

f4fb9cf

Signed-off-by: Krzysztof Goworek <[email protected]> Signed-off-by: CSchlipp <[email protected]>

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020

[satel] Action for reading the event log added (openhab#7282)

06fa982

Signed-off-by: Krzysztof Goworek <[email protected]>

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020

[satel] Action for reading the event log added (openhab#7282)

0b3db29

Signed-off-by: Krzysztof Goworek <[email protected]>

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020

[satel] Action for reading the event log added (openhab#7282)

5344e8d

Signed-off-by: Krzysztof Goworek <[email protected]>

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020

[satel] Action for reading the event log added (openhab#7282)

b291bbf

Signed-off-by: Krzysztof Goworek <[email protected]>

DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020

[satel] Action for reading the event log added (openhab#7282)

0c88c87

Signed-off-by: Krzysztof Goworek <[email protected]> Signed-off-by: Daan Meijer <[email protected]>

markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020

[satel] Action for reading the event log added (openhab#7282)

f9fbd49

Signed-off-by: Krzysztof Goworek <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[satel] Action for reading the event log added #7282

[satel] Action for reading the event log added #7282

druciak commented Apr 4, 2020 •

edited

Loading

TravisBuddy commented Apr 4, 2020

J-N-K Apr 4, 2020

druciak Apr 4, 2020

J-N-K Apr 4, 2020

druciak Apr 4, 2020

J-N-K Apr 4, 2020

druciak Apr 4, 2020

TravisBuddy commented Apr 4, 2020

J-N-K Apr 4, 2020

druciak Apr 4, 2020

J-N-K Apr 4, 2020

druciak Apr 4, 2020

J-N-K Apr 4, 2020

TravisBuddy commented Apr 4, 2020

druciak commented Apr 5, 2020

J-N-K left a comment

druciak commented Apr 5, 2020


		### readEvent

		This action allows you to read one record from the event log placed at index given by input parameter. The result of this action is compatible with channels of `event-log` thing and contains following values:

[satel] Action for reading the event log added #7282

[satel] Action for reading the event log added #7282

Conversation

druciak commented Apr 4, 2020 • edited Loading

TravisBuddy commented Apr 4, 2020

Travis tests were successful

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TravisBuddy commented Apr 4, 2020

Travis tests were successful

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TravisBuddy commented Apr 4, 2020

Travis tests were successful

druciak commented Apr 5, 2020

J-N-K left a comment

Choose a reason for hiding this comment

druciak commented Apr 5, 2020

druciak commented Apr 4, 2020 •

edited

Loading