[radiothermostat] RadioThermostat Binding - initial contribution #7266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lobstein <[email protected]>
mlobstein
force-pushed
the
RadioThermostat
branch
from
f656bfe to
a143408
Compare
Travis tests have failedHey @mlobstein, |
Signed-off-by: Michael Lobstein <[email protected]>
Travis tests were successfulHey @mlobstein, |
…lues to bounce Signed-off-by: Michael Lobstein <[email protected]>
Travis tests were successfulHey @mlobstein, |
cpmeister
changed the title
cpmeister
added
the
new binding
|
The RadioThermostat supports a type of SSDP discovery so you don't need to add each one manually. While stuck at home I wrote a binding for it, and if you want you can take the discovery portion of that or I can try to merge it in with your thing. |
Signed-off-by: Michael Lobstein <[email protected]>
Thanks! I added it to the PR! |
Travis tests were successfulHey @mlobstein, |
Signed-off-by: Michael Lobstein <[email protected]>
update fork
update fork
Signed-off-by: Michael Lobstein <[email protected]>
Travis tests were successfulHey @mlobstein, |
|
Would it make any sense to augment this:
With something like this: As often as I've been using the RadioThermostat, all I've wanted to do really with these values is store away the runtimes and look at them on a group graph. Having a channel that provides a single number would avoid doing transformations to persist the single value needed. |
Yeah that is a good idea. I was originally thinking in terms of just exposing the data from the json api directly to provide compatibility with rule based scraping of the json data that many have done with this thermostat over the years. That also why I put in the channels to provide the thermostat time from the json data even though it is mostly redundant. What unit of time should this single number be? Minutes perhaps? For heat today, I would do the following (today_heat_hour * 60) + today_heat_minute = RuntimeTodayHeat (minutes). Does that sound good? |
|
Yeah just and to store it, you could use
That way, expressed as Number:Time, the user can change the representation as they need. There is one other thing that might be important due to the way these thermostats work. When these guys are in HOLD at a setpoint, you can't transition to a temporary value without unholding it. Other times you may want to set a value and HOLD it. So the way you have things now I think that would be two commands. Since the thermostat can take the json string, I have a simple channel called "command" that just checks and passes that to the thermostat, eg: In this way you avoid the double command, and issues with the radiothermostat timing out when it's doing too much. Also, since people would migrate from the http binding, they are already sending json strings. And this also leaves open the possibility that somebody may want to do something with an undocumented api that we weren't aware of. |
Signed-off-by: Michael Lobstein <[email protected]>
|
@billfor I made your suggested changes. Try it out and let me know what you think. |
Travis tests were successfulHey @mlobstein, |
Looks good! Thank you. |
Signed-off-by: Michael Lobstein <[email protected]>
Travis tests were successfulHey @mlobstein, |
|
While waiting for the next reviewer. Please try to resolve all of these build warnings. Most of them can be resolved by caching fields in local variables and performing your logic on those local variables instead. If there are any you have trouble with let me know and I'll tell you how to solve it. |
I am not sure about those that all appear because of the NotNullByDefault annotation. In the DTO for example, the only way I see to fix it is to assign default values for everything. |
|
We have null checker exclusions in place for DTO classes, if you want to have your DTO class excluded from null checks you must fulfill one of the two following criteria:
|
Signed-off-by: Michael Lobstein <[email protected]>
Travis tests were successfulHey @mlobstein, |
update fork
Signed-off-by: Michael Lobstein <[email protected]>
Done! |
kaikreuzer
requested changes
Jun 24, 2020
|
|
||
| This binding connects RadioThermostat/3M Filtrete models CT30, CT50/3M50, CT80, etc. with built-in Wi-Fi module to openHAB. | ||
|
|
||
| The binding retrieves and periodically updates all basic system information from the thermostat. The main thermostat functions such |
There was a problem hiding this comment.
Please add a line break after every sentence throughout the README, thanks!
| <parent> | ||
| <groupId>org.openhab.addons.bundles</groupId> | ||
| <artifactId>org.openhab.addons.reactor.bundles</artifactId> | ||
| <version>2.5.6-SNAPSHOT</version> |
There was a problem hiding this comment.
As 2.5.6 has just been release, we have to ask you to change this version for a very last time, promised ;-)
Suggested change
| <version>2.5.6-SNAPSHOT</version> | |
| <version>2.5.7-SNAPSHOT</version> |
There was a problem hiding this comment.
Done! Thanks @kaikreuzer
update fork
Signed-off-by: Michael Lobstein <[email protected]>
Travis tests were successfulHey @mlobstein, |
knikhilwiz
pushed a commit
to knikhilwiz/openhab2-addons
that referenced
this pull request
Jul 12, 2020
…nhab#7266) Signed-off-by: Michael Lobstein <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
…nhab#7266) Signed-off-by: Michael Lobstein <[email protected]> Signed-off-by: CSchlipp <[email protected]>
MPH80
pushed a commit
to MPH80/openhab-addons
that referenced
this pull request
Aug 3, 2020
…nhab#7266) Signed-off-by: Michael Lobstein <[email protected]> Signed-off-by: MPH80 <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…nhab#7266) Signed-off-by: Michael Lobstein <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…nhab#7266) Signed-off-by: Michael Lobstein <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…nhab#7266) Signed-off-by: Michael Lobstein <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…nhab#7266) Signed-off-by: Michael Lobstein <[email protected]>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
…nhab#7266) Signed-off-by: Michael Lobstein <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
…nhab#7266) Signed-off-by: Michael Lobstein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This binding connects RadioThermostat/3M Filtrete models CT30, CT50/3M50, CT80, etc. with built-in Wi-Fi module using its HTTP/JSON interface.