-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[insteon] add console commands to help with troubleshooting #7251
Conversation
...nsteon/src/main/java/org/openhab/binding/insteon/internal/handler/InsteonNetworkHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no problem with merging this but you cannot use singletons to implement this feature.
...teon/src/main/java/org/openhab/binding/insteon/internal/command/InsteonCommandExtension.java
Outdated
Show resolved
Hide resolved
...insteon/src/main/java/org/openhab/binding/insteon/internal/handler/InsteonDeviceHandler.java
Show resolved
Hide resolved
...nsteon/src/main/java/org/openhab/binding/insteon/internal/handler/InsteonNetworkHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rob Nielsen <[email protected]>
@cpmeister, I made changes as suggested and commented on one of them. I also cleaned up the README.md file to use 'home' instead of 'local' local was there when the binding auto discovered the network, and it was removed. |
Travis tests were successfulHey @robnielsen, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, If you have tested it and are satisfied then I'll go ahead and merge.
@cpmeister, yes I have tested it. Thanks! |
…7251) Signed-off-by: Rob Nielsen <[email protected]> Signed-off-by: Hans-Reiner Hoffmann <[email protected]>
…7251) Signed-off-by: Rob Nielsen <[email protected]> Signed-off-by: Eugen Freiter <[email protected]>
…7251) Signed-off-by: Rob Nielsen <[email protected]>
…7251) Signed-off-by: Rob Nielsen <[email protected]>
…7251) Signed-off-by: Rob Nielsen <[email protected]>
…7251) Signed-off-by: Rob Nielsen <[email protected]> Signed-off-by: CSchlipp <[email protected]>
…7251) Signed-off-by: Rob Nielsen <[email protected]>
…7251) Signed-off-by: Rob Nielsen <[email protected]>
…7251) Signed-off-by: Rob Nielsen <[email protected]>
…7251) Signed-off-by: Rob Nielsen <[email protected]>
…7251) Signed-off-by: Rob Nielsen <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
…7251) Signed-off-by: Rob Nielsen <[email protected]>
The commands provide information that is logged by the oh1 binding insteonplm. This is helpful when configuring the binding and supporting people who run into issues.