[fronius] Add new channels and fix documentation #7247
Conversation
hypetsch
commented
Mar 28, 2020
hypetsch
commented
- Added a new channel to retrieve the device status error code property.
- Added a new channel to retrieve the device status status code property.
- Fixed incorrect channel and parameters ids in documentation.
Signed-off-by: Peter Schraffl <[email protected]>
Signed-off-by: Peter Schraffl <[email protected]>
Travis tests were successfulHey @hypetsch, |
cpmeister
added
the
enhancement
|
From the way you have coded this, there will always be an error code reported to the channel even when there is no error? |
|
It's just the current error code value as reported by the inverter where error code value 0 means no error/normal operation. So this is information has to be more interpreted as a status of the inverter, so in my opinion this is ok. |
|
@trokohl Please give some feedback if you can. |
| @@ -20,28 +20,30 @@ The binding has no configuration options, all configuration is done at Thing lev | |||
|
|
|||
| The thing has a few configuration parameters: | |||
| | refresh | Refresh interval in seconds | | ||
| | Parameter | Description | | ||
| |-----------------|------------------------------------------------------ | | ||
| | hostname | The ip-address of your Fronius Datalogger | |
There was a problem hiding this comment.
is it possible to add a hostname here? Or are only IP addresses supported?
There was a problem hiding this comment.
As far as I can see it in the code it should be possible to use a hostname too. It just replaces the configuration value into the URL. Also the reachability check should work with a hostname.
Internally the variables are sometimes called ip and sometimes hostname...
(In my opinion it would habe been better to simply name it host.)
There was a problem hiding this comment.
That should be refactored, but is out of scope of this PR. Can you adjust the two open pointa in the documentation?
There was a problem hiding this comment.
Did some more cleanups of the documentation, hope it is ok this way.
Signed-off-by: Peter Schraffl <[email protected]>
Travis tests were successfulHey @hypetsch, |
* Added status code and error code channel * Fix documentation Signed-off-by: Peter Schraffl <[email protected]> Signed-off-by: Hans-Reiner Hoffmann <[email protected]>
* Added status code and error code channel * Fix documentation Signed-off-by: Peter Schraffl <[email protected]> Signed-off-by: Eugen Freiter <[email protected]>
* Added status code and error code channel * Fix documentation Signed-off-by: Peter Schraffl <[email protected]>
* Added status code and error code channel * Fix documentation Signed-off-by: Peter Schraffl <[email protected]>
* Added status code and error code channel * Fix documentation Signed-off-by: Peter Schraffl <[email protected]>
* Added status code and error code channel * Fix documentation Signed-off-by: Peter Schraffl <[email protected]> Signed-off-by: CSchlipp <[email protected]>
* Added status code and error code channel * Fix documentation Signed-off-by: Peter Schraffl <[email protected]>
* Added status code and error code channel * Fix documentation Signed-off-by: Peter Schraffl <[email protected]>
* Added status code and error code channel * Fix documentation Signed-off-by: Peter Schraffl <[email protected]>
* Added status code and error code channel * Fix documentation Signed-off-by: Peter Schraffl <[email protected]>
* Added status code and error code channel * Fix documentation Signed-off-by: Peter Schraffl <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
* Added status code and error code channel * Fix documentation Signed-off-by: Peter Schraffl <[email protected]>
