-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correctly adding configfiles to features #7187
Conversation
Signed-off-by: Kai Kreuzer <[email protected]>
FTR: The distro build currently fails due to this: https://ci.openhab.org/view/Integration%20Builds%20(2.5.x)/job/openHAB-Distribution/68/ |
Interesting. Does that mean no new Installation is using these bindings? Do we need to add an empty |
I looked at the failing build in jenkins but couldn't find any errors...what failed? |
Travis tests have failedHey @kaikreuzer, 1st BuildExpand here
|
No, it means that the default cfg file simply has not been created for voicerss, which doesn't matter much. For leapmotion, this binding indeed won't have worked, but I doubt that anybody is using it productively (it mainly makes sense for demos).
It couldn't find the cfg files for the assembly as the GAV was incorrect. |
That's what I did with #7108 (which you merged) and I just came across those issues here when trying it out on the final distro build... Needs to be fixed before 2.5.3. |
Travis failure looks unrelated to this PR. |
Travis tests were successfulHey @kaikreuzer, |
I also see these warnings in the build:
|
@cpmeister Those warnings are not new and not related to this PR, see #6960. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this is the only remaining fix...
@J-N-K If this looks alright can you go ahead and merge. I don't want to merge changes that I don't understand. I'm still learning the osgi stuff. |
Signed-off-by: Kai Kreuzer <[email protected]> Signed-off-by: leluna <[email protected]>
Signed-off-by: Kai Kreuzer <[email protected]> Signed-off-by: Hans-Reiner Hoffmann <[email protected]>
Signed-off-by: Kai Kreuzer <[email protected]> Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: Kai Kreuzer <[email protected]>
Signed-off-by: Kai Kreuzer <[email protected]>
Signed-off-by: Kai Kreuzer <[email protected]>
Signed-off-by: Kai Kreuzer <[email protected]>
Signed-off-by: Kai Kreuzer <[email protected]>
Signed-off-by: Kai Kreuzer <[email protected]>
Signed-off-by: Kai Kreuzer <[email protected]>
Signed-off-by: Kai Kreuzer <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
Signed-off-by: Kai Kreuzer <[email protected]>
It seems those were lost somewhere on the way to 2.5...
Signed-off-by: Kai Kreuzer [email protected]