-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bluetooth] Refactor and unify BluetoothAdapter implementation logic #7129
Conversation
Signed-off-by: Connor Petty <[email protected]>
Travis tests have failedHey @cpmeister, 1st BuildExpand here
|
Travis tests have failedHey @cpmeister, 1st BuildExpand here
|
Looks like some wemo test failed. Completely unrelated to the changes in this PR. |
This also fixes a bug where bluegiga doesn't report deleted devices to the discovery service. |
@J-N-K When can we get this merged? I have other bluetooth developers that want to develop support for new types of bluetooth adapters and this needs to be merged before they can start on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comments, mostly regarding the removal paramater naming
bundles/org.openhab.binding.bluetooth.bluegiga/src/main/resources/ESH-INF/thing/bluegiga.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.bluetooth.bluegiga/src/main/resources/ESH-INF/thing/bluegiga.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.bluetooth.bluegiga/src/main/resources/ESH-INF/thing/bluegiga.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.bluetooth.bluegiga/src/main/resources/ESH-INF/thing/bluegiga.xml
Outdated
Show resolved
Hide resolved
...ooth.bluez/src/main/java/org/openhab/binding/bluetooth/bluez/handler/BlueZBridgeHandler.java
Show resolved
Hide resolved
...ooth.bluez/src/main/java/org/openhab/binding/bluetooth/bluez/handler/BlueZBridgeHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.bluetooth.bluez/src/main/resources/ESH-INF/thing/bluez.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.bluetooth.bluez/src/main/resources/ESH-INF/thing/bluez.xml
Outdated
Show resolved
Hide resolved
...ng.bluetooth/src/main/java/org/openhab/binding/bluetooth/AbstractBluetoothBridgeHandler.java
Show resolved
Hide resolved
Signed-off-by: Connor Petty <[email protected]>
6919 # Conflicts: # bundles/org.openhab.binding.bluetooth.bluegiga/src/main/java/org/openhab/binding/bluetooth/bluegiga/BlueGigaBluetoothDevice.java # bundles/org.openhab.binding.bluetooth.bluegiga/src/main/java/org/openhab/binding/bluetooth/bluegiga/handler/BlueGigaBridgeHandler.java Signed-off-by: Connor Petty <[email protected]>
Travis tests were successfulHey @cpmeister, |
bundles/org.openhab.binding.bluetooth.bluez/src/main/resources/ESH-INF/thing/bluez.xml
Show resolved
Hide resolved
…penhab#7129) * Refactor and unify BluetoothAdapter implementation logic Signed-off-by: Connor Petty <[email protected]> Signed-off-by: Hans-Reiner Hoffmann <[email protected]>
…penhab#7129) * Refactor and unify BluetoothAdapter implementation logic Signed-off-by: Connor Petty <[email protected]> Signed-off-by: Eugen Freiter <[email protected]>
…penhab#7129) * Refactor and unify BluetoothAdapter implementation logic Signed-off-by: Connor Petty <[email protected]>
…penhab#7129) * Refactor and unify BluetoothAdapter implementation logic Signed-off-by: Connor Petty <[email protected]>
…penhab#7129) * Refactor and unify BluetoothAdapter implementation logic Signed-off-by: Connor Petty <[email protected]>
…penhab#7129) * Refactor and unify BluetoothAdapter implementation logic Signed-off-by: Connor Petty <[email protected]> Signed-off-by: CSchlipp <[email protected]>
…penhab#7129) * Refactor and unify BluetoothAdapter implementation logic Signed-off-by: Connor Petty <[email protected]>
…penhab#7129) * Refactor and unify BluetoothAdapter implementation logic Signed-off-by: Connor Petty <[email protected]>
…penhab#7129) * Refactor and unify BluetoothAdapter implementation logic Signed-off-by: Connor Petty <[email protected]>
…penhab#7129) * Refactor and unify BluetoothAdapter implementation logic Signed-off-by: Connor Petty <[email protected]>
…penhab#7129) * Refactor and unify BluetoothAdapter implementation logic Signed-off-by: Connor Petty <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
…penhab#7129) * Refactor and unify BluetoothAdapter implementation logic Signed-off-by: Connor Petty <[email protected]>
The goal of these changes is to unify the behavior of inactive device cleanup among the different BluetoothAdapter implementations. Additional code similarities have been abstracted out as well.
There is a breaking change I made to the adapter configurations. I changed the one of the config param names, but since it is typically disabled by default I think the name change will cause a negligible impact.