Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bluegiga] Fixed get characteristic data issue #6862

Merged
merged 1 commit into from
Jan 19, 2020

Conversation

paulianttila
Copy link
Contributor

Fix #6857

Signed-off-by: Pauli Anttila [email protected]

@paulianttila paulianttila changed the title [bluegiga] Fixed get characteristic data issue [WIP][bluegiga] Fixed get characteristic data issue Jan 18, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @paulianttila,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@paulianttila
Copy link
Contributor Author

@cdjackson, when you have time, could check this fix? I have no clue how this readCharacteristic should work and if this is proper fix :) But it works fine with airthings binding (#6860) which need to poll data from the sensor.

Copy link

@cdjackson cdjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulianttila looks good to me.

@paulianttila paulianttila changed the title [WIP][bluegiga] Fixed get characteristic data issue [bluegiga] Fixed get characteristic data issue Jan 18, 2020
@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of an add-on label Jan 19, 2020
@kaikreuzer kaikreuzer merged commit 0da33c1 into openhab:2.5.x Jan 19, 2020
@kaikreuzer kaikreuzer added this to the 2.5.2 milestone Jan 19, 2020
tmrobert8 pushed a commit to tmrobert8/openhab-addons that referenced this pull request Jan 21, 2020
@paulianttila paulianttila deleted the bluegiga-characteristic-fix branch March 14, 2020 10:44
leluna pushed a commit to leluna/openhab2-addons that referenced this pull request Mar 21, 2020
Hans-Reiner pushed a commit to Hans-Reiner/openhab2-addons that referenced this pull request Apr 11, 2020
Signed-off-by: Pauli Anttila <[email protected]>
Signed-off-by: Hans-Reiner Hoffmann <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bluetooth] BlueGiga adapter getCharacteristic doesn't return data
4 participants