[lgwebos] Removal of connectsdk library and its dependencies

[sprehn]

This is a major refactoring of the lgwebos binding.
This removes a lot of the connectsdk abstractions and allows us to use OH native json, websocket, UpnpDiscovery capabilities.

[TravisBuddy]

Travis tests were successful

Hey @sprehn,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[J-N-K]

Thanks, I real appreciate removing those external dependencies. I left some comments in the code. Please pay special attention to the 3rdparty-content and the SAT report, I did not mention it everywhere.

[sprehn]

where do I find 3rdparty-content?

[TravisBuddy]

Travis tests were successful

Hey @sprehn,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[J-N-K]

Regarding 3rdparty-content: At best look at the logreader binding. It's just a new Folder (with the same structure as /src/main which is named /src/3rdparty. To make this work in Eclipse you also need to adapt .classpath and for Maven the pom.xml (you can just copy the <build>...</build> part from logreader, no modification needed.

[J-N-K]

Otherwise looks good from my side.

[TravisBuddy]

Travis tests were successful

Hey @sprehn,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[sprehn]

One user has reported a bug with TV: [LG] webOS TV OLED65E7P, webOS v5.80.35
I need to look into why it will not connect properly.

[Hilbrand]

I did some testing and also had the bug. Here are 2 improvements:

1. All classes that are parsed for gson parsing need to have a constructor without arguments.
2. In LGWebOSTVSocket in the onMessage method: wrap the code in a try catch block to catch RuntimeException and just log as warning/error. The problem is. If something goes wrong with the code in onMessage and an exception is thrown this will result in the websocket connection being closed. This triggers the code to reopen the connection and a new call that will end up in onMessage. And if that causes the exception again. It will end up in a nasty loop. With lots of logging. This is what happens due to the problem mentioned in my point 1.

[TravisBuddy]

Travis tests were successful

Hey @sprehn,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[sprehn]

User reported that this fixed the issue.

[sprehn]

@J-N-K do you still request any changes?

[Hilbrand]

At least this needs to be fixed:

All classes that are parsed for gson parsing need to have a constructor without arguments

The catching doesn't fix the problem. It only blocks the binding from going into an endless loop due to it crashing. The crashing is caused (at least with my TV) by the exception thrown by gson due to the missing constructors.

[sprehn]

sure will do, I actually also now see the other remarks.. had to click on "load more"

[TravisBuddy]

Travis tests were successful

Hey @sprehn,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @sprehn,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[J-N-K]

Thanks again.

[Hilbrand]

@sprehn 2 questions:

• Do you plan to add more features. Like dynamic state to get a list of all channels/apps?
• Is it correct this changes the thing configuration? And users need to recreate the thing. In that case there need a comment in the change list on the openhab-distro repository.

[sprehn]

@J-N-K thank you as well.

@Hilbrand, at the moment I am not planning to add more features, but you are right, the config parameter change, so I shall add it to the change list.

[sprehn]

@J-N-K thank you as well.

@Hilbrand, at the moment I am not planning to add more features, but you are right, the config parameter change, so I shall add it to the change list.

[sprehn]

@Hilbrand I don't have a fork of the openhab distro repository. Could you review and add this comment for me, if you don't mind?

ALERT;LGWebOS Binding: The binding parameter 'localIP' was removed. The binding now uses system defaults for network communication. Thing type parameters 'deviceId' is no longer a parameter, but a property. Parameters 'host' and 'key' were added.