Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nest] Fix integration tests fail on Windows #5909

Merged
merged 1 commit into from
Aug 11, 2019
Merged

[nest] Fix integration tests fail on Windows #5909

merged 1 commit into from
Aug 11, 2019

Conversation

wborn
Copy link
Member

@wborn wborn commented Aug 10, 2019 •
edited
Loading

  • Convert line endings read from files so tests work on Linux/Windows
  • Reduce logging output by suppressing org.eclipse.jetty with logback configuration

Fixes #5906

@wborn wborn requested a review from lolodomo August 10, 2019 22:28
@wborn
[nest] Fix integration tests fail on Windows
8ff300a 
* Convert line endings read from files so tests work on Linux/Windows
* Reduce logging output by suppressing org.eclipse.jetty with logback configuration

Fixes openhab#5906

Signed-off-by: Wouter Born <[email protected]>
@wborn wborn force-pushed the fix-nest-itests-on-windows branch from 5d2fe52 to 8ff300a Compare August 10, 2019 22:31
@wborn wborn added bug An unexpected problem or unintended behavior of an add-on build labels Aug 10, 2019
@lolodomo
Copy link
Contributor

lolodomo commented Aug 11, 2019 •
edited
Loading

The tests are all OK now with your changes.

@J-N-K J-N-K merged commit 679948d into openhab:master Aug 11, 2019
@wborn wborn deleted the fix-nest-itests-on-windows branch August 11, 2019 07:33
@cweitkamp cweitkamp added this to the 2.5 milestone Aug 12, 2019
Cossey pushed a commit to Cossey/openhab-addons that referenced this pull request Aug 14, 2019
@wborn @Cossey
[nest] Fix integration tests fail on Windows (openhab#5909)
bfd5040 
* Convert line endings read from files so tests work on Linux/Windows
* Reduce logging output by suppressing org.eclipse.jetty with logback configuration

Fixes openhab#5906

Signed-off-by: Wouter Born <[email protected]>
Cossey pushed a commit to Cossey/openhab-addons that referenced this pull request Aug 14, 2019
@wborn @Cossey
[nest] Fix integration tests fail on Windows (openhab#5909)
0a594ff 
* Convert line endings read from files so tests work on Linux/Windows
* Reduce logging output by suppressing org.eclipse.jetty with logback configuration

Fixes openhab#5906

Signed-off-by: Wouter Born <[email protected]>
sprehn pushed a commit to sprehn/openhab-addons that referenced this pull request Aug 21, 2019
@wborn @sprehn
[nest] Fix integration tests fail on Windows (openhab#5909)
1419ca5 
* Convert line endings read from files so tests work on Linux/Windows
* Reduce logging output by suppressing org.eclipse.jetty with logback configuration

Fixes openhab#5906

Signed-off-by: Wouter Born <[email protected]>
chaton78 pushed a commit to chaton78/openhab-addons that referenced this pull request Sep 2, 2019
@wborn @chaton78
[nest] Fix integration tests fail on Windows (openhab#5909)
07c8bc9 
* Convert line endings read from files so tests work on Linux/Windows
* Reduce logging output by suppressing org.eclipse.jetty with logback configuration

Fixes openhab#5906

Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Pascal Larin <[email protected]>
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
@wborn @ne0h
[nest] Fix integration tests fail on Windows (openhab#5909)
5632889 
* Convert line endings read from files so tests work on Linux/Windows
* Reduce logging output by suppressing org.eclipse.jetty with logback configuration

Fixes openhab#5906

Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Maximilian Hess <[email protected]>
@wborn wborn added the test label Oct 1, 2019
@wborn wborn removed the bug An unexpected problem or unintended behavior of an add-on label Dec 8, 2019
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Dec 8, 2019
@wborn @Pshatsillo
[nest] Fix integration tests fail on Windows (openhab#5909)
9e98f61 
* Convert line endings read from files so tests work on Linux/Windows
* Reduce logging output by suppressing org.eclipse.jetty with logback configuration

Fixes openhab#5906

Signed-off-by: Wouter Born <[email protected]>
tmrobert8 pushed a commit to tmrobert8/openhab-addons that referenced this pull request Jan 21, 2020
@wborn @tmrobert8
[nest] Fix integration tests fail on Windows (openhab#5909)
2298c44 
* Convert line endings read from files so tests work on Linux/Windows
* Reduce logging output by suppressing org.eclipse.jetty with logback configuration

Fixes openhab#5906

Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Tim Roberts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

@lolodomo lolodomo Awaiting requested review from lolodomo

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

[nest] Integration tests fail on Windows
4 participants
@wborn @lolodomo @J-N-K @cweitkamp