-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added transformation services as features #559
Conversation
@@ -48,6 +49,7 @@ protected void unsetFeaturesService(FeaturesService featureService) { | |||
|
|||
@Override | |||
public List<Extension> getExtensions(Locale locale) { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like to start the function with an empty line?
I would suggest to create a pull request for shk for ESH stuff and wrap that features in OH (as it is done e.g. for shk-esh-base, sonos binding, etc.). |
c970788
to
556bb49
Compare
Ok, better now?
I would actually suggest to create a pull request from shk to ESH for that stuff - then the features would be directly build and made available with an ESH build. Is this the plan as soon as we can do versioned releases? |
If shk is hosted at Eclipse and we declare a bundle dependency in a feature, is there a CQ necessary for everyone? |
If we only build the features and don't do the validation (which could be done in the products), then the build would not have a dependency on e.g. pax-web at all, right? As the features are no code by themselves, they also don't have any inherent dependency - they can be considered as a kind of documentation. I would claim that we do not even need to declare build time dependencies for anything here. |
Signed-off-by: Kai Kreuzer <[email protected]>
556bb49
to
8e081a8
Compare
Rebased after merging #560. |
added transformation services as features
Signed-off-by: Kai Kreuzer <[email protected]>
Signed-off-by: Kai Kreuzer [email protected]