Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added transformation services as features #559

Merged
merged 1 commit into from
Dec 18, 2015

Conversation

kaikreuzer
Copy link
Member

Signed-off-by: Kai Kreuzer [email protected]

@@ -48,6 +49,7 @@ protected void unsetFeaturesService(FeaturesService featureService) {

@Override
public List<Extension> getExtensions(Locale locale) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to start the function with an empty line?

@maggu2810
Copy link

I would suggest to create a pull request for shk for ESH stuff and wrap that features in OH (as it is done e.g. for shk-esh-base, sonos binding, etc.).
So we could stop do the same work multiple times.
I have done the automation integration just this evening, so I added the tranformation ones, too.

@kaikreuzer
Copy link
Member Author

Ok, better now?

I would suggest to create a pull request for shk for ESH stuff

I would actually suggest to create a pull request from shk to ESH for that stuff - then the features would be directly build and made available with an ESH build. Is this the plan as soon as we can do versioned releases?

@maggu2810
Copy link

If shk is hosted at Eclipse and we declare a bundle dependency in a feature, is there a CQ necessary for everyone?
It is not for the framework, it is for a product that uses the framework.
All dependencies e.g. Pax Web and all the other Karaf feature we depend on have to be checked the same way as we have to check if something can be used as a work-with dependency (e.g. as you have done with nrjavaserial IIRC).

@kaikreuzer
Copy link
Member Author

If we only build the features and don't do the validation (which could be done in the products), then the build would not have a dependency on e.g. pax-web at all, right? As the features are no code by themselves, they also don't have any inherent dependency - they can be considered as a kind of documentation. I would claim that we do not even need to declare build time dependencies for anything here.

@kaikreuzer
Copy link
Member Author

Rebased after merging #560.

maggu2810 added a commit that referenced this pull request Dec 18, 2015
added transformation services as features
@maggu2810 maggu2810 merged commit f1185c3 into openhab:karaf Dec 18, 2015
@kaikreuzer kaikreuzer deleted the transform branch February 29, 2016 22:34
@kaikreuzer kaikreuzer modified the milestone: 2.0.0 Jan 17, 2017
Flole998 pushed a commit to Flole998/openhab-addons that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants