[systeminfo] Migrate to BND #5455

falkena · 2019-04-14T14:46:16Z

Signed-off-by: Alexander Falkenstern [email protected]

davidgraeff

Thanks.
The karaf feature file need to be modified. The libraries need to be added there as well so that openHAB knows of them and can install them during runtime.

bundles/org.openhab.binding.systeminfo/.classpath

bundles/org.openhab.binding.systeminfo/pom.xml

J-N-K

otherwise looks good.

J-N-K · 2019-04-15T17:23:24Z

features/karaf/openhab-addons/src/main/feature/feature.xml

@@ -847,7 +847,10 @@

    <feature name="openhab-binding-systeminfo" description="System Info Binding" version="${project.version}">
        <feature>openhab-runtime-base</feature>
-        <bundle start-level="80">mvn:org.openhab.binding/org.openhab.binding.systeminfo/${project.version}</bundle>
+        <bundle dependency="true">wrap:mvn:com.github.oshi/oshi-core/3.13.0</bundle>
+        <bundle dependency="true">wrap:mvn:net.java.dev.jna/jna/5.2.0</bundle>


wrapping should not be necessary, this is already an OSGi bundle

Played around to solve travis issues. Sadly, still no progress. see below

J-N-K · 2019-04-15T17:24:41Z

features/karaf/openhab-addons/src/main/feature/feature.xml

-        <bundle start-level="80">mvn:org.openhab.binding/org.openhab.binding.systeminfo/${project.version}</bundle>
+        <bundle dependency="true">wrap:mvn:com.github.oshi/oshi-core/3.13.0</bundle>
+        <bundle dependency="true">wrap:mvn:net.java.dev.jna/jna/5.2.0</bundle>
+        <bundle dependency="true">wrap:mvn:net.java.dev.jna/jna-platform/5.2.0</bundle>


wrapping should not be necessary, this is already an OSGi bundle

Played around to solve travis issues. Sadly, still no progress. See below

I don‘t think Travis failure is related to your changes. Travis fails on all PR.

My local build fails too :-( I mean: Build binding only works. I i try to build all addons on top level, then feature verification fails...

J-N-K · 2019-04-15T17:25:43Z

features/karaf/openhab-addons/src/main/feature/feature.xml

@@ -847,7 +847,10 @@

    <feature name="openhab-binding-systeminfo" description="System Info Binding" version="${project.version}">
        <feature>openhab-runtime-base</feature>
-        <bundle start-level="80">mvn:org.openhab.binding/org.openhab.binding.systeminfo/${project.version}</bundle>
+        <bundle dependency="true">wrap:mvn:com.github.oshi/oshi-core/3.13.0</bundle>


wrapping should not be necessary, this is already an OSGi bundle

Played around to solve travis issues. Sadly, still no progress: See below.

falkena · 2019-04-15T20:25:51Z

I stuck with karaf feature verification: openHAB Add-ons :: Features :: Karaf :: Add-ons .... FAILURE
The message is

Feature resolution failed for [openhab-binding-systeminfo/2.5.0.SNAPSHOT]
[ERROR] Message: Unable to resolve root: missing requirement [root] osgi.identity; osgi.identity=openhab-binding-systeminfo; type=karaf.feature; version=2.5.0.SNAPSHOT; filter:="(&(osgi.identity=openhab-binding-systeminfo)(type=karaf.feature)(version>=2.5.0.SNAPSHOT))" [caused by: Unable to resolve openhab-binding-systeminfo/2.5.0.SNAPSHOT: missing requirement [openhab-binding-systeminfo/2.5.0.SNAPSHOT] osgi.identity; osgi.identity=org.openhab.binding.systeminfo; type=osgi.bundle; version="[2.5.0.201904152011,2.5.0.201904152011]"; resolution:=mandatory [caused by: Unable to resolve org.openhab.binding.systeminfo/2.5.0.201904152011: missing requirement [org.openhab.binding.systeminfo/2.5.0.201904152011] osgi.wiring.package; filter:="(&(osgi.wiring.package=oshi.hardware)(version>=3.13.0)(!(version>=4.0.0)))" [caused by: Unable to resolve com.github.oshi.oshi-core/3.13.0: missing requirement [com.github.oshi.oshi-core/3.13.0] osgi.wiring.package; filter:="(osgi.wiring.package=com.sun.jna.platform.linux)"]]]

Build runs smoothly. Any hint?

J-N-K · 2019-04-15T20:52:18Z

Seems to be a bug in JNA 5.2.0: java-native-access/jna#1054

Did this ever work under Linux?

Edit: this probably broke by updating the libs in #4834. We should check if we can revert that.

J-N-K · 2019-04-16T06:38:17Z

You can try removing the dependency to net.java.dev.jna:.jna-platform, putting jna-platform-5.2.0.jar to /lib and add the following lines to pom.xml.

<properties>
  <bnd.exportpackage>com.sun.jna.platform.*;version="5.2.0"</bnd.exportpackage>
</properties>

I did not try but that should export all packages.

falkena · 2019-04-16T17:25:31Z

Hi @J-N-K , thank you :-) I've traced the dependecies down to jna 4.2.1: still the same problem. It seems, that it's broken for the long time and nobody catched the bug. On Raspberry jna 5.2.0 runs as expected. Therefore it seems, that we must live with workaround.

According to oshi/oshi#752, bugfix is planned for 3.13.1: https://github.com/oshi/oshi/milestone/11

J-N-K · 2019-04-16T17:46:28Z

The export works?

falkena · 2019-04-16T17:48:35Z

Build and verification was OK. Currently i rebase my other PR and test all the stuff.

falkena · 2019-04-16T21:09:58Z

Ok. Rebased, updated eclipse, wait till workspace build... And new fail...

openhab> bundle:restart 254
Error executing command: Error restarting bundles:
Unable to start bundle 254: Could not resolve module: org.openhab.binding.systeminfo [254]
Unresolved requirement: Import-Package: com.sun.jna; version="[5.2.0,6.0.0)"

Ok, embed jna-5.2.0.jar the same way as jna-platform-5.2.0.jar. Rebuilt, new attempt...

openhab> bundle:restart 254
Error executing command: Error restarting bundles:
Unable to start bundle 254: Could not resolve module: org.openhab.binding.systeminfo [254]
Unresolved requirement: Import-Package: oshi; version="[3.13.0,4.0.0)"

Ok, embed oshi-core-3.13.0.jar the same way as jna-5.2.0.jar. Rebuilt, new attempt...

openhab> bundle:restart 254
Error executing command: Error restarting bundles:
Unable to start bundle 254: Could not resolve module: org.openhab.binding.systeminfo [254]
Unresolved requirement: Import-Package: com.sun.management

Built on Windows and run on raspberry...

davidgraeff · 2019-04-16T23:50:38Z

Did it work with the old buildsystem? If not we are not loosing anything if we merge this PR for now and keep investigating later

J-N-K · 2019-04-17T01:08:47Z

This is probably due to the missing dependencies which are defined in the feature.

J-N-K

did you check that the itests successfully run?

J-N-K · 2019-04-17T12:49:48Z

bundles/org.openhab.binding.systeminfo/.classpath

+			<attribute name="test" value="true"/>
+		</attributes>
+	</classpathentry>
+	<classpathentry kind="output" path="target/classes"/>


add jna-platform as lib (see e.g. allplay)

Removed in current version

J-N-K · 2019-04-17T12:50:24Z

bundles/org.openhab.binding.systeminfo/pom.xml

+      <version>3.13.0</version>
+      <scope>provided</scope>
+    </dependency>
+    <dependency>


remove this dependency (always provided if embedded)

J-N-K · 2019-04-17T12:50:59Z

features/karaf/openhab-addons/src/main/feature/feature.xml

@@ -855,7 +855,10 @@

    <feature name="openhab-binding-systeminfo" description="System Info Binding" version="${project.version}">
        <feature>openhab-runtime-base</feature>
-        <bundle start-level="80">mvn:org.openhab.binding/org.openhab.binding.systeminfo/${project.version}</bundle>
+        <bundle dependency="true">mvn:com.github.oshi/oshi-core/3.13.0</bundle>
+        <bundle dependency="true">mvn:net.java.dev.jna/jna-platform/5.2.0</bundle>


remove feature dependency (always provided if embedded)

falkena · 2019-04-17T17:20:13Z

@davidgraeff : Yes it run bevore @J-N-K I already performed requested changes yesterday, just not pushed them, since it will not run...

J-N-K · 2019-04-17T18:04:43Z

As I said before: the feature resolution in your production setup will not work because it is using the old feature.xml.

It should work if you install the missing bundles manually. Did you try that?

Signed-off-by: Alexander Falkenstern <[email protected]>

falkena · 2019-04-17T21:35:27Z

I run two environments: production (2.5.0M1) and development with latest snapshot. The strange thing is, i get

Unresolved requirement: Import-Package: oshi; version="[3.13.0,4.0.0)"

if i try to load the binding, but according to oshi-core manifest file, it's provided by oshi-core.jar...

J-N-K · 2019-04-19T14:47:25Z

I raised a PR against your repo. With those fixes everything compiles and I verified that the binding is working on two systems (both Linux). The tests fail, though. Maybe you can have a look at that.

J-N-K · 2019-04-20T15:10:55Z

@falkena, thanks to @matthiasblaesing JNA 5.3.0 was released very fast. I have updated my PR to your repo, please merge that, the tests now run fine, too.

Signed-off-by: Jan N. Klug <[email protected]>

falkena · 2019-04-20T20:23:25Z

@falkena, thanks to @matthiasblaesing JNA 5.3.0 was released very fast. I have updated my PR to your repo, please merge that, the tests now run fine, too.

Hi @J-N-K : I've merged your PR. Thank you for help! I'll rebase my another PR and test the stuff this week. If something will go wrong, i'll fix it. May be @dbwiddis can find some time and update the oshi dependency to JNA 5.3.0. Officially OSHI depends now still on JNA 5.2.0

dbwiddis · 2019-04-20T20:43:13Z

Hah. I’ve been waiting on JNA 5.3 and checking almost daily. But missed a day.

J-N-K · 2019-04-20T20:59:31Z

But it works with 5.3.0. so no need to hurry.

* Migrate systeminfo to bnd * fix dependencies, update JNA, fix tests (openhab#8) Signed-off-by: Jan N. Klug <[email protected]>

* Migrate systeminfo to bnd * fix dependencies, update JNA, fix tests (openhab#8) Signed-off-by: Jan N. Klug <[email protected]> Signed-off-by: Pshatsillo <[email protected]>

* Migrate systeminfo to bnd * fix dependencies, update JNA, fix tests (openhab#8) Signed-off-by: Jan N. Klug <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>

falkena requested review from svilenvul and a team as code owners April 14, 2019 14:46

falkena mentioned this pull request Apr 14, 2019

[systeminfo] Support multiple processes #5249

Closed

falkena force-pushed the feature/MigrateToBnd branch from 693e036 to e494bc3 Compare April 14, 2019 14:52

davidgraeff reviewed Apr 14, 2019

View reviewed changes

bundles/org.openhab.binding.systeminfo/.classpath Outdated Show resolved Hide resolved

bundles/org.openhab.binding.systeminfo/pom.xml Show resolved Hide resolved

falkena force-pushed the feature/MigrateToBnd branch 5 times, most recently from 4789637 to b2dc0e7 Compare April 15, 2019 15:55

J-N-K reviewed Apr 15, 2019

View reviewed changes

falkena force-pushed the feature/MigrateToBnd branch from b2dc0e7 to 6bbb2ee Compare April 15, 2019 20:05

maggu2810 mentioned this pull request Apr 16, 2019

Migration to a Maven + Bnd based build system #5005

Closed

falkena force-pushed the feature/MigrateToBnd branch from 6bbb2ee to 3a3b625 Compare April 16, 2019 17:36

J-N-K requested changes Apr 17, 2019

View reviewed changes

Hilbrand added the infrastructure Build system and Karaf related issues and PRs label Apr 17, 2019

Migrate systeminfo to bnd

3af9574

Signed-off-by: Alexander Falkenstern <[email protected]>

falkena force-pushed the feature/MigrateToBnd branch from 3a3b625 to 3af9574 Compare April 17, 2019 21:31

fix dependencies, update JNA, fix tests (#8)

78143b4

Signed-off-by: Jan N. Klug <[email protected]>

J-N-K approved these changes Apr 21, 2019

View reviewed changes

davidgraeff approved these changes Apr 22, 2019

View reviewed changes

davidgraeff merged commit f101cca into openhab:master Apr 22, 2019

mherwege pushed a commit to mherwege/openhab-addons that referenced this pull request May 10, 2019

[systeminfo] Migrate to BND (openhab#5455)

14d76dd

* Migrate systeminfo to bnd * fix dependencies, update JNA, fix tests (openhab#8) Signed-off-by: Jan N. Klug <[email protected]>

wborn added this to the 2.5 milestone May 26, 2019

wborn removed this from the 2.5 milestone Dec 8, 2019

wborn added this to the 2.5 milestone Dec 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[systeminfo] Migrate to BND #5455

[systeminfo] Migrate to BND #5455

falkena commented Apr 14, 2019

davidgraeff left a comment

J-N-K left a comment

J-N-K Apr 15, 2019

falkena Apr 15, 2019 •

edited

Loading

J-N-K Apr 15, 2019

falkena Apr 15, 2019 •

edited

Loading

J-N-K Apr 15, 2019

falkena Apr 15, 2019 •

edited

Loading

J-N-K Apr 15, 2019

falkena Apr 15, 2019 •

edited

Loading

falkena commented Apr 15, 2019

J-N-K commented Apr 15, 2019 •

edited

Loading

J-N-K commented Apr 16, 2019

falkena commented Apr 16, 2019 •

edited

Loading

J-N-K commented Apr 16, 2019

falkena commented Apr 16, 2019

falkena commented Apr 16, 2019

davidgraeff commented Apr 16, 2019

J-N-K commented Apr 17, 2019

J-N-K left a comment

J-N-K Apr 17, 2019

falkena Apr 17, 2019

J-N-K Apr 17, 2019

falkena Apr 17, 2019

J-N-K Apr 17, 2019

falkena commented Apr 17, 2019

J-N-K commented Apr 17, 2019

falkena commented Apr 17, 2019 •

edited

Loading

J-N-K commented Apr 19, 2019

J-N-K commented Apr 20, 2019

falkena commented Apr 20, 2019

dbwiddis commented Apr 20, 2019

J-N-K commented Apr 20, 2019

[systeminfo] Migrate to BND #5455

[systeminfo] Migrate to BND #5455

Conversation

falkena commented Apr 14, 2019

davidgraeff left a comment

Choose a reason for hiding this comment

J-N-K left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

falkena Apr 15, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

falkena Apr 15, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

falkena Apr 15, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

falkena Apr 15, 2019 • edited Loading

Choose a reason for hiding this comment

falkena commented Apr 15, 2019

J-N-K commented Apr 15, 2019 • edited Loading

J-N-K commented Apr 16, 2019

falkena commented Apr 16, 2019 • edited Loading

J-N-K commented Apr 16, 2019

falkena commented Apr 16, 2019

falkena commented Apr 16, 2019

davidgraeff commented Apr 16, 2019

J-N-K commented Apr 17, 2019

J-N-K left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

falkena commented Apr 17, 2019

J-N-K commented Apr 17, 2019

falkena commented Apr 17, 2019 • edited Loading

J-N-K commented Apr 19, 2019

J-N-K commented Apr 20, 2019

falkena commented Apr 20, 2019

dbwiddis commented Apr 20, 2019

J-N-K commented Apr 20, 2019

falkena Apr 15, 2019 •

edited

Loading

falkena Apr 15, 2019 •

edited

Loading

falkena Apr 15, 2019 •

edited

Loading

falkena Apr 15, 2019 •

edited

Loading

J-N-K commented Apr 15, 2019 •

edited

Loading

falkena commented Apr 16, 2019 •

edited

Loading

falkena commented Apr 17, 2019 •

edited

Loading