[ihc] Changed pulse command to use scheduling #5417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changed couple of list iterators to streams. Signed-off-by: Pauli Anttila <[email protected]>
davidgraeff
reviewed
Apr 9, 2019
| logger.warn("Channel {} update to resource '{}' failed.", channelUID, valOff); | ||
| } | ||
| } catch (IhcExecption e) { | ||
| logger.error("Can't update channel '{}' value, cause ", channelUID, e.getMessage(), e); |
There was a problem hiding this comment.
Can you change log levels from error to warn in a follow up PR? That would be really great.
There was a problem hiding this comment.
Yes I can do it, but I made quick search to openhab2 addons project and there seems to be almost 1500 error levels used over 100 bindings 😃
There was a problem hiding this comment.
Yup. They are all wrong. But good point, need to be automatically replaced.
See also my PR on the contribution page: openhab/openhab-docs#933
davidgraeff
approved these changes
Apr 9, 2019
mherwege
pushed a commit
to mherwege/openhab-addons
that referenced
this pull request
May 10, 2019
Also changed couple of list iterators to streams. Signed-off-by: Pauli Anttila <[email protected]>
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Jun 19, 2019
Also changed couple of list iterators to streams. Signed-off-by: Pauli Anttila <[email protected]> Signed-off-by: Pshatsillo <[email protected]>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
Also changed couple of list iterators to streams. Signed-off-by: Pauli Anttila <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changed couple of list iterators to streams.
Signed-off-by: Pauli Anttila [email protected]