[bin2json] bin2json Transformation #5348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pauli Anttila <[email protected]>
paulianttila
added
work in progress
davidgraeff
reviewed
Mar 31, 2019
...form.bin2json/src/main/java/org/openhab/transform/bin2json/internal/ConversionException.java
Outdated
Show resolved
Hide resolved
...enhab.transform.bin2json/src/main/java/org/openhab/transform/bin2json/internal/Bin2Json.java
Outdated
Show resolved
Hide resolved
|
|
||
| == Third-party Content | ||
|
|
||
| jbbp |
There was a problem hiding this comment.
Can the jbbp-1.4.1.jar library be provided by maven as dependency instead of adding the jar file?
Signed-off-by: Pauli Anttila <[email protected]>
Signed-off-by: Pauli Anttila <[email protected]>
davidgraeff
reviewed
Mar 31, 2019
Signed-off-by: Pauli Anttila <[email protected]>
Signed-off-by: Pauli Anttila <[email protected]>
paulianttila
removed
the
work in progress
paulianttila
changed the title
|
Thanks David. I added it to Karaf features, even it most probably cause merge problems if merge is delayed. |
|
Forgotten that JBBP jar is not a OSGi bundle so build fails. I add static jar file back to binding. |
Signed-off-by: Pauli Anttila <[email protected]>
|
No you should use the "wrap" prefix. Have a look at all the other bundles in the karaf feature file that are using wrap already. If there is a maven release, a jar file will no longer be accepted. |
|
@davidgraeff, that's sounds great...will do. |
Signed-off-by: Pauli Anttila <[email protected]>
Signed-off-by: Pauli Anttila <[email protected]>
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Jun 19, 2019
Binary To JSON transformation service Signed-off-by: Pauli Anttila <[email protected]> Signed-off-by: Pshatsillo <[email protected]>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
Binary To JSON transformation service Signed-off-by: Pauli Anttila <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary To JSON transformation service
Signed-off-by: Pauli Anttila [email protected]