FTP Upload binding #3137

paulianttila · 2018-01-18T18:40:28Z

This binding integrates large number of network cameras which can send image to FTP server when motion or sound is detected. Binding acts as a FTP server.

Signed-off-by: Pauli Anttila [email protected]

triller-telekom

Thank you for your binding! It is indeed a nice hack to support such cameras in a generic way.

Do you have example vendors and model names of cameras that support this ftp upload functionality once they detect movement?

Two major comments:

I think you only need one channel, the image one, the others are redundant.
Your thing should go ONLINE/OFFLINE if the device is reachable/not reachable.

Please also have a look at the comments inline in the code.

triller-telekom · 2018-04-23T13:33:50Z

addons/binding/org.openhab.binding.networkcamera/ESH-INF/thing/thing-types.xml

+				<label>User Name</label>
+				<description>Username</description>
+			</parameter>
+			<parameter name="password" type="text" required="true">


Please add a <context>password</context> for this parameter.

triller-telekom · 2018-04-23T13:34:46Z

addons/binding/org.openhab.binding.networkcamera/OSGI-INF/NetworkCameraHandlerFactory.xml

@@ -0,0 +1,21 @@
+<?xml version="1.0" encoding="UTF-8"?>


We are using DS annotations now. Can you please remove this file and put a ".gitignore" fle in the OSGI-INF directory?

Inside your HandlerFactory you can use the @Component annotation which will create this xml description for you. You can find an example in the astro binding

triller-telekom · 2018-04-23T13:35:16Z

addons/binding/org.openhab.binding.networkcamera/README.md

@@ -0,0 +1,83 @@
+# Network Camera Binding
+
+This binding integrates large number of network cameras which can send image to FTP server when motion or sound is detected. Binding acts as a FTP server. Images stored to FTP server are not saved to the file system, therefore binding shouldn't cause any problems on flash based openHAB installations.


Please add a new line after each sentence. This simplifies merging later.

...send images to a FTP server if motion...

Images stored on the FTP server...

therefore the binding...

triller-telekom · 2018-04-23T13:38:28Z

addons/binding/org.openhab.binding.networkcamera/README.md

+| Channel Type ID | Item Type    | Description                                                                            |
+|-----------------|--------------|----------------------------------------------------------------------------------------|
+| image           | Image        | Image received from network camera.                                                    |
+| motion          | Switch       | Motion detection sensor state. Updated to ON state when image is received from camera. |


What is the difference to the trigger channel? I guess you only need the image channel, don't you?

Binding is actually done, when trigger channel was pretty new concept, so that's why there is also direct motion channel.

triller-telekom · 2018-04-23T13:39:52Z

addons/binding/org.openhab.binding.networkcamera/README.md

+| motion-trigger  | MOTION_DETECTED        | Triggered when image received from network camera. |
+
+
+## Full Example


Can you please also provide a .sitemap file? You can at least show the current image, right?

triller-telekom · 2018-04-23T14:16:46Z

...ng.networkcamera/src/main/java/org/openhab/binding/networkcamera/internal/ftp/FtpServer.java

+                byte[] d = DatatypeConverter.parseHexBinary(data.toString());
+                logger.debug("File len: {}", d.length);
+                return d;
+            } catch (Exception e) {


triller-telekom · 2018-04-23T14:17:58Z

...ng.networkcamera/src/main/java/org/openhab/binding/networkcamera/internal/ftp/FtpServer.java

+        }
+    }
+
+    private class MyFTPLet extends DefaultFtplet {


Usually one or two small private classes fit nicely into a class, but I think you should factor out yours into extra files because they are too many which makes it hard to read.

triller-telekom · 2018-04-23T14:18:36Z

...ng.networkcamera/src/main/java/org/openhab/binding/networkcamera/internal/ftp/FtpServer.java

+        try {
+            server.start();
+        } catch (FtpException e) {
+            e.printStackTrace();


Please use the logger.

triller-telekom · 2018-04-23T14:54:59Z

addons/binding/org.openhab.binding.networkcamera/README.md

+
+| Channel Type ID | Options                | Description                                        |
+|-----------------|------------------------|----------------------------------------------------|
+| motion-trigger  | MOTION_DETECTED        | Triggered when image received from network camera. |


see above: I a rule you can also check if the image channel has received and update, so that one channel should be sufficient.

Motion trigger channel is useful, if someone don't want to have image channel e.g. for private reaseon.

triller-telekom · 2018-04-23T14:57:51Z

...workcamera/src/main/java/org/openhab/binding/networkcamera/handler/NetworkCameraHandler.java

+
+        ftpServer.addEventListener(this);
+        ftpServer.addAuthenticationCredentials(configuration.userName, configuration.password);
+        updateStatus(ThingStatus.ONLINE);


There should be a mechanism to set the thing to ONLINE/OFFLINE if its reachable/not reachable. How about implementing a scheduled job that pings the device every x seconds to see if the camera is still there?

triller-telekom

Thank you for your very quick response!

I left some more comments in the code.

One larger point which I would like to discuss with you is if this binding should rather be named something like "generic ftp image binding" or so. Because it doesn't matter where the image is uploaded from, it does not necessarily be a network camera, right?

And if this binding will be this "generic image ftp binding" (we have to find a good name for it), I think it would make sense to not only offer ONE single image channel, but make the thing-type extensible with more image channels of the same type. Your image channel would then get a configuration parameter "path" which is the ftp path where the image is uploaded to, so you can have multiple images per thing. WDYT?

triller-telekom · 2018-04-24T12:44:07Z

addons/binding/org.openhab.binding.networkcamera/.classpath

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<classpath>
+	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.7"/>


triller-telekom · 2018-04-24T12:45:18Z

addons/binding/org.openhab.binding.networkcamera/ESH-INF/thing/thing-types.xml

+
+		<channels>
+			<channel id="image" typeId="image-channel" />
+			<channel id="motion" typeId="motion-channel" />


I thought you had removed this channel?

triller-telekom · 2018-04-24T12:46:16Z

addons/binding/org.openhab.binding.networkcamera/ESH-INF/thing/thing-types.xml

+		<channels>
+			<channel id="image" typeId="image-channel" />
+			<channel id="motion" typeId="motion-channel" />
+			<channel id="motion-trigger" typeId="motion-trigger" />


I think this channel is also kind of redundant, because you can obtain this information in rules by creating a condition whether the state of the item on the image channel has been changed, right?

triller-telekom · 2018-04-24T12:46:36Z

addons/binding/org.openhab.binding.networkcamera/ESH-INF/thing/thing-types.xml

+		<description>Image from network camera</description>
+		<state readOnly="true"></state>
+	</channel-type>
+	<channel-type id="motion-channel">


Please remove

triller-telekom · 2018-04-24T12:46:57Z

addons/binding/org.openhab.binding.networkcamera/ESH-INF/thing/thing-types.xml

+		<description>Motion detected</description>
+		<state readOnly="true"></state>
+	</channel-type>
+	<channel-type id="motion-trigger">


See above, this can be removed too, don't you think?

triller-telekom · 2018-04-24T12:50:22Z

...workcamera/src/main/java/org/openhab/binding/networkcamera/handler/NetworkCameraHandler.java

+        if (configuration.userName.equals(userName)) {
+            updateStatus(ThingStatus.ONLINE);
+            updateState(IMAGE, new RawType(data, guessMimeTypeFromData(data)));
+            triggerChannel(MOTION_TRIGGER, "MOTION_DETECTED");


probably not needed anymore.

triller-telekom · 2018-04-24T12:52:01Z

...ra/src/main/java/org/openhab/binding/networkcamera/internal/NetworkCameraHandlerFactory.java

+        String strIdleTimeout = (String) componentContext.getProperties().get("idleTimeout");
+
+        if (StringUtils.isNotEmpty(strPort)) {
+            port = Integer.valueOf(strPort);


What if you get a NumberFormatException here? I think you should at least catch and log it and then use the default values.

triller-telekom · 2018-04-24T12:52:13Z

...ra/src/main/java/org/openhab/binding/networkcamera/internal/NetworkCameraHandlerFactory.java

+        }
+
+        if (StringUtils.isNotEmpty(strPort)) {
+            idleTimeout = Integer.valueOf(strIdleTimeout);


What if you get a NumberFormatException here? I think you should at least catch and log it and then use the default values.

triller-telekom · 2018-04-24T12:54:06Z

...ng.networkcamera/src/main/java/org/openhab/binding/networkcamera/internal/ftp/FtpServer.java

+                iterator.next().fileReceived(userName, data);
+            }
+
+        } catch (Exception e) {


Please do not catch Exception, catch the specific ones.

Callback could throw any kind of execution.

triller-telekom · 2018-04-24T12:56:28Z

...ra/src/main/java/org/openhab/binding/networkcamera/internal/NetworkCameraHandlerFactory.java

+            idleTimeout = Integer.valueOf(strIdleTimeout);
+        }
+
+        ftpServer.startServer(port, idleTimeout);


This method should throw an exception so you can catch it here. In the catch block you should notify all created handlers so they can set their things to OFFLINE with configuration_error.

paulianttila · 2018-04-24T15:17:50Z

Thanks @triller-telekom about the review. I think, most of the findings should be fixed now (I have not tested if binding still works).

About the generic ftp image binding, do you think that there are many use cases for that? Images could be send to item via rest interface as well, right?

Btw, static code analysis give me following errors:

[ERROR] .binding.networkcamera/META-INF/MANIFEST.MF:[0]
The package  should be marked as "internal" if it is not exported.
[ERROR] .binding.networkcamera/META-INF/MANIFEST.MF:[0]
The package org should be marked as "internal" if it is not exported.
[ERROR] .binding.networkcamera/META-INF/MANIFEST.MF:[0]
The package org.openhab should be marked as "internal" if it is not exported.
[ERROR] .binding.networkcamera/META-INF/MANIFEST.MF:[0]
The package org.openhab.binding should be marked as "internal" if it is not exported.

Any idea?

triller-telekom · 2018-04-25T12:14:25Z

...ra/src/main/java/org/openhab/binding/networkcamera/internal/NetworkCameraHandlerFactory.java

+        try {
+            ftpServer.startServer(port, idleTimeout);
+        } catch (FtpException e) {
+            logger.warn("FTP server starting failed, reason: {}", e.getMessage());


As I mentioned before you should store all you created handlers in something like a Set and notify them that the ftpserver is gone if this happens. So they can set their things to offline.

If e.g. FTP server port can't be bind, FTP server throws IOException. As it's not catch, bundle activation fails and things stays in uninitialised state. There is no mechanism that ftp server could notify that server is suddenly shutdown. I don't know when ftp server could throw FtpException in start, but if I remove FtpException catching, things should stay Offline state if server throws that exception during startup.

I think you should catch this Exception and not make the bundle initialization fail. This is an error case which can be treated by handling exception, so we should do it. Note that your modified method is called if you change the binding configuration, so you start the server not only on the initial bundle start but also because of a changed configuration.

triller-telekom · 2018-04-25T12:20:58Z

Regarding the static code analysis error: Can you please rebase your branch onto the latest master branch?

Signed-off-by: Pauli Anttila <[email protected]>

paulianttila · 2018-04-27T15:37:08Z

@kaikreuzer, I quickly tested the custom channels.

Thing networkcamera:motiondetection:garage [ userName="garage", password="12345" ] {
    Channels:
        Type image-channel : my_image1 "My Image channel 1" [
            filename="test1.png"
        ]
        Type image-channel : my_image2 "My Image channel 2" [
            filename="test2.jpg"
        ]
        Trigger String : my_image_trigger1 [
            filename="test1.png"
        ]
        Trigger String : my_image_trigger2 [
            filename="test2.jpg"
        ]     
}

When file is upload to FTP server, binding tries to find first image channel which match the filename. If any custom channel is not found, then binding updates the default image channel. Same for the triggers.

Is that what you proposed?

kaikreuzer · 2018-04-27T15:47:29Z

Yes, exactly! Isn't it nice and wasn't it simple? ;-)

As mentioned above, you might want to allow regular expressions and not only static strings for the filename parameter.

And note that you can define in the thing type that it can be extended by "image-channel"s (note the extensible="channelTypeId1,channelTypeId2,..." part) - then the Paper UI will even offer the user a "+" button to dynamically add channels.

Signed-off-by: Pauli Anttila <[email protected]>

paulianttila · 2018-04-28T10:29:59Z

@kaikreuzer, yes, that was simple :) My fear was more related to FTP directory structures if that should be implemented.

About the regular expression syntax, does thing file configuration syntax or Paper UI support some kind of auto escaping or how that should be implemented? By regex syntax, user can easily broke thing file.

Signed-off-by: Pauli Anttila <[email protected]>

kaikreuzer · 2018-04-29T19:22:41Z

I didn't yet test what issues might come up with regexs as config parameter strings. But in general, both Paper UI and DSL should support any kind of string values for those parameters. For the DSL, only the quotes will need to be escaped, but besides that I would expect it to work. And the most simple regex is anyhow a static filename, so that case should be easily covered - for any other issues, you can happily create bug reports in ESH then ;-)

triller-telekom

Except fro a few minor typos this binding looks good to me now. Please have a look at my comments. Since @kaikreuzer is also satisfied with the custom channels, I guess we are very close to get this binding merged :)

triller-telekom · 2018-05-02T09:21:19Z

addons/binding/org.openhab.binding.networkcamera/ESH-INF/thing/thing-types.xml

+		<config-description>
+			<parameter name="filename" type="text" required="true">
+				<label>Filename</label>
+				<description>Filename to match received files. Support regular expression patterns.</description>


Supports regular...

triller-telekom · 2018-05-02T09:21:56Z

addons/binding/org.openhab.binding.networkcamera/ESH-INF/thing/thing-types.xml

+		<config-description>
+			<parameter name="filename" type="text" required="true">
+				<label>Filename</label>
+				<description>Filename to match received files. Support regular expression patterns.</description>


Supports regular...

triller-telekom · 2018-05-02T09:22:55Z

addons/binding/org.openhab.binding.networkcamera/README.md

@@ -25,26 +25,54 @@ This binding currently supports following channels:
 |-----------------|--------------|----------------------------------------------------------------------------------------|
 | image           | Image        | Image received from network camera.                                                    |

+Binding also support custom Image channels, where matching filename can be configured.


supports... where a matching filename can...

triller-telekom · 2018-05-02T09:24:54Z

addons/binding/org.openhab.binding.networkcamera/README.md

@@ -25,26 +25,54 @@ This binding currently supports following channels:
 |-----------------|--------------|----------------------------------------------------------------------------------------|
 | image           | Image        | Image received from network camera.                                                    |

+Binding also support custom Image channels, where matching filename can be configured.
+When image file is uploaded to FTP server, binding tries to find channel which filename match to upload image filename.


When an image file.. server, the binding... find the channel ~~which~~ whose filename matches to the uploaded...

triller-telekom · 2018-05-02T09:25:33Z

addons/binding/org.openhab.binding.networkcamera/README.md

+Binding also support custom Image channels, where matching filename can be configured.
+When image file is uploaded to FTP server, binding tries to find channel which filename match to upload image filename.
+If any direct match isn't found, the default image channel is updated.
+filename parameter support regular expression patterns.


The filename parameter supports...

triller-telekom · 2018-05-02T09:30:20Z

...workcamera/src/main/java/org/openhab/binding/networkcamera/handler/NetworkCameraHandler.java

+            ChannelUID channel = findCustomChannelByFilename(filename);
+            updateState(channel != null ? channel.getId() : IMAGE, new RawType(data, guessMimeTypeFromData(data)));
+            channel = findCustomTriggerByFilename(filename);
+            triggerChannel(channel != null ? channel.getId() : MOTION_TRIGGER, "MOTION_DETECTED");


Maybe your want to extract the string "MOTION_DETECTED" into a constant.

triller-telekom · 2018-05-02T09:30:48Z

...workcamera/src/main/java/org/openhab/binding/networkcamera/handler/NetworkCameraHandler.java

+import java.util.regex.Pattern;
+import java.util.regex.PatternSyntaxException;
+
+import org.eclipse.jdt.annotation.NonNull;


Please do not use @NonNull, see https://www.eclipse.org/smarthome/documentation/development/conventions.html

triller-telekom · 2018-05-02T09:36:21Z

...era/src/main/java/org/openhab/binding/networkcamera/internal/ftp/FtpServerEventListener.java

@@ -8,6 +8,8 @@
 */
 package org.openhab.binding.networkcamera.internal.ftp;

+import org.eclipse.jdt.annotation.NonNull;


triller-telekom · 2018-05-02T09:39:05Z

addons/binding/org.openhab.binding.ftpupload/ESH-INF/thing/thing-types.xml

        <state readOnly="true"></state>
    </channel-type>
-    <channel-type id="motion-trigger">
+    <channel-type id="image-received">


Does this channel really check if the received file is an image? I see in your later commit you renamed the thing to imagereceiver, so you probably want to check in your implementation that the received file is an image file.

Yes, I renamed thing to imagereceiver as only supported channel is a image channel. I also thought trigger channel name and in the beginning it was "file-received", but then I ended up to image-received because of thing name.

triller-telekom · 2018-05-02T09:40:35Z

addons/binding/org.openhab.binding.ftpupload/README.md

 ## Supported Things

-This binding supports ```motiondetection``` Thing. Every camera is identified by FTP user name. Therefore, every camera should use unique user name to login FTP server.
+This binding supports ```ftpupload``` Thing. Every thing is identified by FTP user name. Therefore, every thing should use unique user name to login FTP server.


Please add a line break after each sentence.

Signed-off-by: Pauli Anttila <[email protected]>

triller-telekom

Thank you for your changes. LGTM now!

paulianttila · 2018-05-02T16:01:07Z

@triller-telekom, hopefully all findings are now fixed.

kaikreuzer

Thanks @paulianttila, please find some final comments attached.

kaikreuzer · 2018-05-07T06:28:00Z

addons/binding/org.openhab.binding.ftpupload/README.md

+# FTP Upload Binding
+
+This binding can be used to receive image files from FTP clients.
+Binding acts as a FTP server.


-> The binding...

kaikreuzer · 2018-05-07T06:28:14Z

addons/binding/org.openhab.binding.ftpupload/README.md

+## Supported Things
+
+This binding supports ```ftpupload``` Thing.
+Every thing is identified by FTP user name.


Every Thing...

kaikreuzer · 2018-05-07T06:29:02Z

addons/binding/org.openhab.binding.ftpupload/README.md

+
+## Supported Things
+
+This binding supports ```ftpupload``` Thing.


-> This binding supports Things of type ftpupload.

kaikreuzer · 2018-05-07T06:32:28Z

addons/binding/org.openhab.binding.ftpupload/about.html

+        did not receive this Content directly from the openHAB community, the following is provided 
+        for informational purposes only, and you should look to the Redistributor's license for 
+        terms and conditions of use.</p>
+        <p><em>


You include 3 jars, so it would be good to have also 3 entries here - to me it is not clear, where ftpled comes from (FTP Server or from MINA?).

kaikreuzer · 2018-05-07T06:36:47Z

addons/binding/org.openhab.binding.ftpupload/README.md

+
+## Binding Configuration
+
+Bindings FTP server listening 2121 TCP port by default, but port can be configured.


Please add a table like this one so that the parameter names are clearly documented.

kaikreuzer · 2018-05-07T07:04:51Z

...ab.binding.ftpupload/src/main/java/org/openhab/binding/ftpupload/internal/ftp/FtpServer.java

+    }
+
+    private void initServer() throws FtpException {
+        logger.info("Starting FTP server, port={}, idleTimeout={}", port, idleTimeout);


kaikreuzer · 2018-05-07T07:05:05Z

...ab.binding.ftpupload/src/main/java/org/openhab/binding/ftpupload/internal/ftp/FtpServer.java

+
+        serverFactory.addListener("default", listener);
+
+        Map<String, Ftplet> ftplets = new LinkedHashMap<String, Ftplet>();


use diamond operator

kaikreuzer · 2018-05-07T07:05:51Z

...ab.binding.ftpupload/src/main/java/org/openhab/binding/ftpupload/internal/ftp/FtpServer.java

+            if (!e.getMessage().isEmpty()) {
+                ftpStartUpErrorReason += ": " + e.getMessage();
+            }
+            throw (e);


Doesn't throw e do?

kaikreuzer · 2018-05-07T07:06:36Z

...pupload/src/main/java/org/openhab/binding/ftpupload/internal/ftp/FtpServerEventListener.java

+     * Procedure for receive raw data from FTP server.
+     *
+     * @param userName
+     *            User name.


put the description on the same line as the parameter, please (all three)

kaikreuzer · 2018-05-07T07:08:08Z

addons/binding/pom.xml

@@ -38,6 +38,7 @@
    <module>org.openhab.binding.folding</module>
    <module>org.openhab.binding.freebox</module>
    <module>org.openhab.binding.fronius</module>
+    <module>org.openhab.binding.ftpupload</module>


Please also add the binding to https://github.com/openhab/openhab2-addons/blob/master/features/openhab-addons/src/main/feature/feature.xml, otherwise it won't turn up in the distro.

Signed-off-by: Pauli Anttila <[email protected]>

paulianttila · 2018-05-07T18:29:10Z

@kaikreuzer, hopefully all findings are now fixed.

kaikreuzer · 2018-05-07T21:23:40Z

Thanks @paulianttila! All fine, just please check the formatting of the XML (I wonder, why it does not apply tabs in your IDE...?)

kaikreuzer · 2018-05-08T08:41:40Z

If you struggle with it, I can run it through my formatter, just let me know.

Signed-off-by: Pauli Anttila <[email protected]>

kaikreuzer

Thanks!

Signed-off-by: Pauli Anttila <[email protected]>

paulianttila force-pushed the NetworkCameraMotionDetectionBinding branch from bd2281d to a743a18 Compare January 20, 2018 06:55

martinvw added the new binding If someone has started to work on a binding. For a new binding PR. label Jan 24, 2018

triller-telekom reviewed Apr 23, 2018

View reviewed changes

triller-telekom reviewed Apr 24, 2018

View reviewed changes

triller-telekom reviewed Apr 25, 2018

View reviewed changes

paulianttila added 23 commits April 25, 2018 18:22

Initial commit for NetworkCameraMotionDetectionBinding

1aa36ce

Signed-off-by: Pauli Anttila <[email protected]>

Added README.md

1617930

Signed-off-by: Pauli Anttila <[email protected]>

Added about.html

e166c93

Signed-off-by: Pauli Anttila <[email protected]>

Removed language property file

33be6fc

Signed-off-by: Pauli Anttila <[email protected]>

Renamed thing type from NetworkCamera to networkcamera

24961c8

Signed-off-by: Pauli Anttila <[email protected]>

Updated Ftp server and mina libraries

ee16732

Signed-off-by: Pauli Anttila <[email protected]>

Fixed logging

5acb7e3

Signed-off-by: Pauli Anttila <[email protected]>

Added FTP server logging instructions

7c6d4c3

Signed-off-by: Pauli Anttila <[email protected]>

Few minor fixes

fa83406

Signed-off-by: Pauli Anttila <[email protected]>

Minor fixes

7bf4303

Signed-off-by: Pauli Anttila <[email protected]>

Minor fixes

4c0f0ec

Signed-off-by: Pauli Anttila <[email protected]>

Minor fixes

7841816

Signed-off-by: Pauli Anttila <[email protected]>

Fixed readme

6721920

Signed-off-by: Pauli Anttila <[email protected]>

Improvements

070a22c

Signed-off-by: Pauli Anttila <[email protected]>

Improvements

6567b5e

Signed-off-by: Pauli Anttila <[email protected]>

Renamed binding to networkcamera

5d3e1a7

Signed-off-by: Pauli Anttila <[email protected]>

Updated headers

14f604f

Signed-off-by: Pauli Anttila <[email protected]>

Added missing new line

9c53c61

Signed-off-by: Pauli Anttila <[email protected]>

Reformatted xml

b8a93e1

Signed-off-by: Pauli Anttila <[email protected]>

Make Martin happy

999d9fd

Signed-off-by: Pauli Anttila <[email protected]>

Renamed directory

8420875

Signed-off-by: Pauli Anttila <[email protected]>

Code review and other fixes

e25f6c4

Signed-off-by: Pauli Anttila <[email protected]>

Use DS annotations

a52ba91

Signed-off-by: Pauli Anttila <[email protected]>

Added support for custom channels

5b9568c

Signed-off-by: Pauli Anttila <[email protected]>

paulianttila closed this Apr 28, 2018

paulianttila reopened this Apr 28, 2018

paulianttila added 2 commits April 28, 2018 15:04

Renamed binding to ftpupload

28f384d

Signed-off-by: Pauli Anttila <[email protected]>

Fixed thing type

aa7a6e6

Signed-off-by: Pauli Anttila <[email protected]>

paulianttila changed the title ~~Network camera motion detection binding~~ FTP Upload binding Apr 28, 2018

triller-telekom reviewed May 2, 2018

View reviewed changes

paulianttila added 2 commits May 2, 2018 18:40

Code review fixes

4e534f1

Signed-off-by: Pauli Anttila <[email protected]>

Typo fixes

3db01a0

Signed-off-by: Pauli Anttila <[email protected]>

triller-telekom approved these changes May 2, 2018

View reviewed changes

kaikreuzer requested changes May 7, 2018

View reviewed changes

paulianttila added 2 commits May 7, 2018 20:13

Code review fixes

98d6594

Signed-off-by: Pauli Anttila <[email protected]>

Added binding to features

8641dd8

Signed-off-by: Pauli Anttila <[email protected]>

Spaces to tabs

9e3ce04

Signed-off-by: Pauli Anttila <[email protected]>

kaikreuzer approved these changes May 9, 2018

View reviewed changes

kaikreuzer merged commit 5a17efa into openhab:master May 9, 2018

martinvw added this to the 2.3 milestone May 25, 2018

hww3 pushed a commit to hww3/openhab2-addons that referenced this pull request Jul 4, 2018

FTP Upload binding (openhab#3137)

1a719ef

Signed-off-by: Pauli Anttila <[email protected]>

divyachauhan25 pushed a commit to divyachauhan25/openhab2-addons that referenced this pull request Jul 6, 2018

FTP Upload binding (openhab#3137)

d83cba4

Signed-off-by: Pauli Anttila <[email protected]>

koa pushed a commit to koa/openhab2-addons that referenced this pull request Oct 28, 2018

FTP Upload binding (openhab#3137)

b094666

Signed-off-by: Pauli Anttila <[email protected]>

kaikreuzer mentioned this pull request Feb 13, 2019

[FolderWatcher] [WIP] Initial contribution #4892

Closed

paulianttila deleted the NetworkCameraMotionDetectionBinding branch March 14, 2020 10:54

		@@ -0,0 +1,83 @@
		# Network Camera Binding

		This binding integrates large number of network cameras which can send image to FTP server when motion or sound is detected. Binding acts as a FTP server. Images stored to FTP server are not saved to the file system, therefore binding shouldn't cause any problems on flash based openHAB installations.

		\| motion-trigger \| MOTION_DETECTED \| Triggered when image received from network camera. \|


		## Full Example


		## Supported Things

		This binding supports ```ftpupload``` Thing.


		## Binding Configuration

		Bindings FTP server listening 2121 TCP port by default, but port can be configured.


		serverFactory.addListener("default", listener);

		Map<String, Ftplet> ftplets = new LinkedHashMap<String, Ftplet>();

FTP Upload binding #3137

FTP Upload binding #3137

Conversation

paulianttila commented Jan 18, 2018

triller-telekom left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

triller-telekom left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paulianttila commented Apr 24, 2018 • edited Loading

Choose a reason for hiding this comment

paulianttila Apr 25, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

triller-telekom commented Apr 25, 2018

paulianttila commented Apr 27, 2018

kaikreuzer commented Apr 27, 2018

paulianttila commented Apr 28, 2018 • edited Loading

kaikreuzer commented Apr 29, 2018

triller-telekom left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

triller-telekom left a comment

Choose a reason for hiding this comment

paulianttila commented May 2, 2018

kaikreuzer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paulianttila commented May 7, 2018

paulianttila commented Apr 24, 2018 •

edited

Loading

paulianttila Apr 25, 2018 •

edited

Loading

paulianttila commented Apr 28, 2018 •

edited

Loading