Initial contribution of the HDanywhere 2.0 binding #23

kgoderis · 2014-10-23T19:30:45Z

Signed-off-by: Karel Goderis [email protected] (github: kgoderis)

kaikreuzer · 2015-05-03T19:56:56Z

addons/binding/org.openhab.binding.hdanywhere/ESH-INF/thing/matrix.xml

+        xsi:schemaLocation="http://eclipse.org/smarthome/schemas/thing-description/v1.0.0 http://eclipse.org/smarthome/schemas/thing-description-1.0.0.xsd">
+
+    <!-- HDanywhere Thing Type -->
+    <thing-type id="matrix">


How many variants are there? Would it be a lot of effort to define the different products directly? You define 8 channels, but some devices have only 4 of them, right? So this feels a bit awkward.
Also, if the number of input ports is known, it could be defined in the state description in order to list the valid options.

Valid point, but 8x8 is the maximum they have for now. It did it that way because part of their product line is sold as bare racks + modules you can insert, so one could end up with any combination of ports on the ingress or egress of the device

kaikreuzer · 2015-05-03T20:07:54Z

Hi Karel,

Thanks, looks good! After incorporating my comments, could you please

apply the code formatter
squash your commits into one?

Thanks!

kgoderis · 2015-05-04T17:59:16Z

Ok. Maybe you wanna want to wait with the other bindings until after I have modified some of them cfr newest API changes etc?

On 03 May 2015, at 22:07, Kai Kreuzer [email protected] wrote:

Hi Karel,

Thanks, looks good! After incorporating my comments, could you please

apply the code formatter
squash your commits into one?
Thanks!

—
Reply to this email directly or view it on GitHub #23 (comment).

kaikreuzer · 2015-05-04T17:59:58Z

Ok. Maybe you wanna want to wait with the other bindings until after I have modified some of them cfr newest API changes etc?

Yes, I can do that.

buildhive · 2015-05-04T19:40:11Z

openhab » openhab2 #77 SUCCESS
This pull request looks good
(what's this?)

buildhive · 2015-05-04T19:53:26Z

openhab » openhab2 #78 SUCCESS
This pull request looks good
(what's this?)

kgoderis · 2015-05-04T20:28:18Z

Ok - Should be inline with your comments, except for the first one.
K

buildhive · 2015-05-04T20:33:47Z

openhab » openhab2 #79 SUCCESS
This pull request looks good
(what's this?)

kaikreuzer · 2015-05-04T20:40:34Z

addons/binding/org.openhab.binding.hdanywhere/ESH-INF/thing/matrix.xml

+    <!-- Port Channel Type -->
+    <channel-type id="port">
+        <item-type>Number</item-type>
+        <label>HDanywhere Matrix Output Port</label>


Hm, did I miss to ask for a shorter label text on this one? Like "Output Port"?

kaikreuzer · 2015-05-04T20:42:09Z

...anywhere/src/main/java/org/openhab/binding/hdanywhere/internal/HDanywhereHandlerFactory.java

+
+		if (thingUID == null) {
+			thingUID = new ThingUID(thingTypeUID,
+					ipAddress.replaceAll(".", "_"));


This might not be enough - as mentioned in my previous comment, an IPv6 address contains colons as well. And users might enter a hostname with special characters, who knows...

kaikreuzer · 2015-05-04T20:42:45Z

Ok - Should be inline with your comments, except for the first one.

Almost, but not quite :-)

kgoderis · 2015-05-05T21:03:37Z

Ok - did not see your additional comments until now.

Btw, I know you want to have debug lines removed, but I would suggest to keep them in until we are out of the Alpha releases. With changing API's one does need the debugging info.

buildhive · 2015-05-05T21:09:44Z

openhab » openhab2 #88 SUCCESS
This pull request looks good
(what's this?)

kaikreuzer · 2015-05-07T06:39:27Z

Btw, I know you want to have debug lines removed

I think I only suggested to remove those which log about changing the thing status. They are indeed not needed anymore, because the framework now itself logs every Thing status update as a debug log message.

kaikreuzer · 2015-05-12T21:27:06Z

@kgoderis short question: Do you actually have the right to change the assignee of an issue? If so, it would be great if you do so after incorporating review comments. But as nobody seems to do it, I guess Github does not let you do it?

kaikreuzer · 2015-05-13T09:21:10Z

Thanks Karel, I'm ready to merge - could you please squash the two commits?

kgoderis · 2015-05-13T13:29:06Z

No, I do not have the privilege to do that, nor can I set labels etc.

kaikreuzer · 2015-05-13T13:38:06Z

ok, that explains why nobody is doing it...

Signed-off-by: Karel Goderis <[email protected]> (github: kgoderis)

kgoderis · 2015-05-14T12:55:01Z

done.

buildhive · 2015-05-14T13:04:35Z

openhab » openhab2 #124 SUCCESS
This pull request looks good
(what's this?)

Initial contribution of the HDanywhere 2.0 binding

kaikreuzer · 2015-05-21T08:52:07Z

@kgoderis: May I ask you to create a short documentation for this binding until Sunday (May 24th)?
I have created a short guide on how to do it: https://github.com/eclipse/smarthome/blob/master/docs/sources/development/extensions/bindings/docs.md
As an example how the result could look like, please see https://github.com/eclipse/smarthome/blob/master/addons/binding/org.eclipse.smarthome.binding.hue/README.md.
Thanks!

kaikreuzer · 2015-05-25T20:08:32Z

@kgoderis: Just noticed that the README.md is still missing - would you manage to add a very short one asap? Would be good to have at least something; everything is better than a 404 link ;-)

Minor bugfixing and little refactoring

Fix office icon.

* [yamahareceiver] Fix ChannelTypeProvider * [yamaha] Fix remaining ChannelTypeProvider (#23) Also-by: Florian Hotze <[email protected]> Signed-off-by: Jan N. Klug <[email protected]>

* [yamahareceiver] Fix ChannelTypeProvider * [yamaha] Fix remaining ChannelTypeProvider (openhab#23) Also-by: Florian Hotze <[email protected]> Signed-off-by: Jan N. Klug <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>

* [yamahareceiver] Fix ChannelTypeProvider * [yamaha] Fix remaining ChannelTypeProvider (openhab#23) Also-by: Florian Hotze <[email protected]> Signed-off-by: Jan N. Klug <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>

* [yamahareceiver] Fix ChannelTypeProvider * [yamaha] Fix remaining ChannelTypeProvider (openhab#23) Also-by: Florian Hotze <[email protected]> Signed-off-by: Jan N. Klug <[email protected]>

kaikreuzer added the new binding If someone has started to work on a binding. For a new binding PR. label Dec 22, 2014

kaikreuzer self-assigned this Jan 13, 2015

kaikreuzer modified the milestone: 2.0.0 alpha2 Apr 4, 2015

kaikreuzer reviewed May 3, 2015
View reviewed changes

kaikreuzer assigned kgoderis and unassigned kaikreuzer May 3, 2015

kgoderis force-pushed the hdanywhere branch from c6e67b8 to e86c6b6 Compare May 4, 2015 19:45

kgoderis force-pushed the hdanywhere branch from e86c6b6 to 171d295 Compare May 4, 2015 20:25

kaikreuzer reviewed May 4, 2015
View reviewed changes

kaikreuzer assigned kaikreuzer and unassigned kgoderis May 12, 2015

Initial contribution of the HDanywhere 2.0 binding

4bc4549

Signed-off-by: Karel Goderis <[email protected]> (github: kgoderis)

kgoderis force-pushed the hdanywhere branch from b31a85d to 4bc4549 Compare May 14, 2015 12:54

kaikreuzer added a commit that referenced this pull request May 14, 2015

Merge pull request #23 from kgoderis/hdanywhere

60a5d8c

Initial contribution of the HDanywhere 2.0 binding

kaikreuzer merged commit 60a5d8c into openhab:master May 14, 2015

kgoderis deleted the hdanywhere branch May 29, 2015 17:22

cvanorman pushed a commit to cvanorman/openhab2-addons that referenced this pull request Dec 29, 2016

Merge pull request openhab#23 from andreacioni/MySensors

4aac271

Minor bugfixing and little refactoring

goofy79 mentioned this pull request Apr 28, 2019

[hueemulation] Migrate to bnd #5243

Merged

magx2 added a commit to SUPLA/openhab2-addons that referenced this pull request Jun 16, 2019

openhab#23 Remove channelUUID from LedCommandExecutor

ffffdcb

magx2 added a commit to SUPLA/openhab2-addons that referenced this pull request Jun 16, 2019

openhab#23 Extra actions(set white and turn works as intended on GUI

2b80667

Flole998 pushed a commit to Flole998/openhab-addons that referenced this pull request Dec 30, 2021

Merge pull request openhab#23 from reitermarkus/master

615e822

Fix office icon.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial contribution of the HDanywhere 2.0 binding #23

Initial contribution of the HDanywhere 2.0 binding #23

kgoderis commented Oct 23, 2014

kaikreuzer May 3, 2015

kgoderis May 4, 2015

kaikreuzer commented May 3, 2015

kgoderis commented May 4, 2015

kaikreuzer commented May 4, 2015

buildhive commented May 4, 2015

buildhive commented May 4, 2015

kgoderis commented May 4, 2015

buildhive commented May 4, 2015

kaikreuzer May 4, 2015

kaikreuzer May 4, 2015

kaikreuzer commented May 4, 2015

kgoderis commented May 5, 2015

buildhive commented May 5, 2015

kaikreuzer commented May 7, 2015

kaikreuzer commented May 12, 2015

kaikreuzer commented May 13, 2015

kgoderis commented May 13, 2015

kaikreuzer commented May 13, 2015

kgoderis commented May 14, 2015

buildhive commented May 14, 2015

kaikreuzer commented May 21, 2015

kaikreuzer commented May 25, 2015

Initial contribution of the HDanywhere 2.0 binding #23

Initial contribution of the HDanywhere 2.0 binding #23

Conversation

kgoderis commented Oct 23, 2014

kaikreuzer May 3, 2015

Choose a reason for hiding this comment

kgoderis May 4, 2015

Choose a reason for hiding this comment

kaikreuzer commented May 3, 2015

kgoderis commented May 4, 2015

kaikreuzer commented May 4, 2015

buildhive commented May 4, 2015

buildhive commented May 4, 2015

kgoderis commented May 4, 2015

buildhive commented May 4, 2015

kaikreuzer May 4, 2015

Choose a reason for hiding this comment

kaikreuzer May 4, 2015

Choose a reason for hiding this comment

kaikreuzer commented May 4, 2015

kgoderis commented May 5, 2015

buildhive commented May 5, 2015

kaikreuzer commented May 7, 2015

kaikreuzer commented May 12, 2015

kaikreuzer commented May 13, 2015

kgoderis commented May 13, 2015

kaikreuzer commented May 13, 2015

kgoderis commented May 14, 2015

buildhive commented May 14, 2015

kaikreuzer commented May 21, 2015

kaikreuzer commented May 25, 2015