Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z-Way: Update Z-Way library and add new device types #2211

Merged
merged 2 commits into from
Apr 26, 2017

Conversation

pathec
Copy link

@pathec pathec commented Apr 26, 2017

  • Update Z-Way library from 0.1.7 to 0.2.7 with some fixes and additions (for details have a look at https://github.com/pathec/ZWay-library-for-Java/blob/master/CHANGELOG.md)
  • Add ToogleButton and SwitchToggle device types (Z-Way scene or Wall Controller). Only on-Commands will send to Z-Way and off-Commands are ignored
  • Add new Channel Type for SensorDiscrete as a two-digit value (first = button/scene and second = action/keyAttribute), for example 30: button Error Importing Project #3 and key attribute 0 means single pressed)

New version for testing: org.openhab.binding.zway-2.1.0-SNAPSHOT.zip

Signed-off-by: Patrick Hecker [email protected] (github: pathec)

pathec added 2 commits April 25, 2017 09:43
Signed-off-by: Patrick Hecker <[email protected]> (github: pathec)
Signed-off-by: Patrick Hecker <[email protected]> (github: pathec)
@mention-bot
Copy link

@pathec, thanks for your PR! By analyzing the history of the files in this pull request, we identified @martinvw, @svilenvul and @kaikreuzer to be potential reviewers.

@kaikreuzer kaikreuzer merged commit 32de188 into openhab:master Apr 26, 2017
tratho pushed a commit to tratho/openhab2-addons that referenced this pull request May 5, 2017
* Update Z-Way library.
* Add SensorDiscrete, ToggleButton, SwitchToggle.

Signed-off-by: Patrick Hecker <[email protected]> (github: pathec)
@kaikreuzer kaikreuzer modified the milestone: 2.1 Jun 23, 2017
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature for an existing add-on label Jun 24, 2017
qvistgaard pushed a commit to qvistgaard/openhab2-addons that referenced this pull request Jun 30, 2017
* Update Z-Way library.
* Add SensorDiscrete, ToggleButton, SwitchToggle.

Signed-off-by: Patrick Hecker <[email protected]> (github: pathec)
Markinus pushed a commit to Markinus/openhab2-addons that referenced this pull request Jul 2, 2017
* Update Z-Way library.
* Add SensorDiscrete, ToggleButton, SwitchToggle.

Signed-off-by: Patrick Hecker <[email protected]> (github: pathec)
@pathec
Copy link
Author

pathec commented Jul 4, 2017

Hi @kaikreuzer,

there is a problem with the last commit.

The code review tool failed. Is it possible that these changes are no longer contained in the official build? A user in the forum means that a feature does not work after a new installation. But in April it worked already.

Many thanks!
Patrick

@martinvw
Copy link
Member

martinvw commented Jul 4, 2017

@pathec I do not know the exact problem, but you can check what is the master now here:

https://github.com/openhab/openhab2-addons/tree/master/addons/binding/org.openhab.binding.zway/lib

It seems to me like the changes are still there?

@pathec
Copy link
Author

pathec commented Jul 5, 2017

Hi,

you are right. The change are in master branch. So it isn't the problem.

aogorek pushed a commit to aogorek/openhab2-addons that referenced this pull request Jul 5, 2017
* Update Z-Way library.
* Add SensorDiscrete, ToggleButton, SwitchToggle.

Signed-off-by: Patrick Hecker <[email protected]> (github: pathec)
Markinus pushed a commit to Markinus/openhab2-addons that referenced this pull request Sep 8, 2017
* Update Z-Way library.
* Add SensorDiscrete, ToggleButton, SwitchToggle.

Signed-off-by: Patrick Hecker <[email protected]> (github: pathec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants