[hueemulation] Device name transformation added #2153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirAd
changed the title
|
Triggering some builds |
|
This change would make the add-on dependent on the MAP transformation service, which is not really desired - additionally, it would only allow textual configuration, but there is no way to do it e.g. through the Paper UI. Note that the issue that you try to address here is discussed at eclipse-archived/smarthome#3692. Currently, the simplest way to get a custom label for Alexa is to simply to use multiple items. I'd therefore suggest to close this PR and rather follow up on eclipse-archived/smarthome#3692. |
martinvw
added
the
awaiting feedback
wborn
changed the title
|
Let's close this PR as suggested because of the undesired dependency. |
Flole998
pushed a commit
to Flole998/openhab-addons
that referenced
this pull request
Dec 30, 2021
Signed-off-by: Jimmy Tanagra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added MAP translation for devices exposed by HueEmulation. The original HueEmulation uses item Label. I've added possibility to exposure item with different names. It's useful for Amazon Alexa integration as Alexa can understand only English or German language. My labels are in local language, but I would like to integrate them with Alexa. I made file with translation Polish<->English.
new configuration has been added:
translationFile=<map file name>in conf/services/hueemulation.cfg
when is a MAP transformation file described here
file contains pairs:
Label=Name exposed by HueEmulation
when Label does not exist in transformation file Label is used.