Initial contribution of ZoneMinder Binding #1812
Conversation
kaikreuzer
added
the
new binding
There was a problem hiding this comment.
Thanks @Mr-Eskildsen looks good now!
Just some very minor formatting issues, see my comments below.
Please also add the binding to https://github.com/openhab/openhab2-addons/blob/master/features/openhab-addons/src/main/feature/feature.xml, so that it is included in the distro.
You can do those changes as additional commits on your branch - I can squash them when merging. Thanks!
| <label>Advanced</label> | ||
| </parameter-group> | ||
|
|
||
| <parameter name="hostname" type="text" required="true" groupName="basic"> |
There was a problem hiding this comment.
could you run the code formatter? Here is a tabs/spaces mix
| } | ||
|
|
||
| ``` | ||
| ###Items configuration### |
There was a problem hiding this comment.
please add an empty line above here
| } | ||
| } | ||
| ``` | ||
| ##Troubleshooting## |
There was a problem hiding this comment.
please add an empty line above here
addons/binding/pom.xml
Outdated
| @@ -68,6 +68,7 @@ | |||
| <module>org.openhab.binding.urtsi</module> | |||
| <module>org.openhab.binding.vitotronic</module> | |||
| <module>org.openhab.binding.yamahareceiver</module> | |||
| <module>org.openhab.binding.zoneminder</module> | |||
|
Thanks @kaikreuzer for your comments. I believe that I have fixed the issues you have pinpointed. Besides from that I found another issue in the .classpath file - I had not added the library I use in that. I verified how it should look like in the chromecast binding, so hopefully I got that one right. |
|
Thanks, looks good! |
Signed-off-by: Martin S. Eskildsen <[email protected]>
|
@kaikreuzer Sorry that I not catched that myself. Thanks for your advice regarding Rebasing :-), hopefully everything is as expected. |
|
Well done, thanks :-) |
Signed-off-by: Martin S. Eskildsen <[email protected]>
Signed-off-by: Martin S. Eskildsen <[email protected]>
Signed-off-by: Martin S. Eskildsen <[email protected]>
Signed-off-by: Martin S. Eskildsen <[email protected]>
* Log reason for rules/scripts refresh Fixes openhab#1293 Signed-off-by: Laurent Garnier <[email protected]>
This Pull Request replaces PR #1376 (https://github.com/openhab/openhab2-addons/pull/1376).