Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[guntamatic] Add channel groups #17901

Merged
merged 8 commits into from
Dec 20, 2024
Merged

[guntamatic] Add channel groups #17901

merged 8 commits into from
Dec 20, 2024

Conversation

MikeTheTux
Copy link
Contributor

@MikeTheTux MikeTheTux commented Dec 14, 2024 •
edited
Loading

[guntamatic] add channel groups, add index to each channel (for channels sharing same description), use AbstractStorageBasedTypeProvider

Description

This PR implements the following changes:

Not backward compatible.
openhab/openhab-distro#1708

@MikeTheTux
guntamatic indexed channels
b30fac7 
Signed-off-by: Michael Weger <[email protected]>
@MikeTheTux MikeTheTux changed the title [guntamatic] add index to channels in order to allow channels with same description [guntamatic] add an index to each channel to allow multiple channels with the same description Dec 14, 2024
@MikeTheTux
Copy link
Contributor Author

Initial init of binding still takes 120s because of:

2024-12-16 12:48:38.507 [WARN ] [core.thing.internal.ThingManagerImpl] - Channel types or config descriptions for thing 'guntamatic:biostar:85792db1de' are missing in the respective registry for more than 120s. In case it does not happen immediately after an upgrade, it should be fixed in the binding.
2024-12-16 12:48:38.514 [WARN ] [core.thing.internal.ThingManagerImpl] - Failed to normalize configuration for thing 'guntamatic:biostar:85792db1de': {thing/channel=Type description guntamatic:000_running for guntamatic:biostar:85792db1de:000_running not found, although we checked the presence before.}

I would require support to get #14954 implemented.

@MikeTheTux MikeTheTux changed the title [guntamatic] add an index to each channel to allow multiple channels with the same description [guntamatic] add an index to each channel to allow multiple channels with the same description, use AbstractStorageBasedTypeProvider Dec 17, 2024
@MikeTheTux MikeTheTux mentioned this pull request Dec 17, 2024
Open
30 tasks
@MikeTheTux
Copy link
Contributor Author

AbstractStorageBasedTypeProvider is now also used, the 120s WARNING gone.

@MikeTheTux MikeTheTux mentioned this pull request Dec 17, 2024
Closed
@MikeTheTux MikeTheTux requested a review from lolodomo December 17, 2024 18:45
@MikeTheTux
implemented channel groups
ee908a7 
Signed-off-by: Michael Weger <[email protected]>
@MikeTheTux MikeTheTux changed the title [guntamatic] add an index to each channel to allow multiple channels with the same description, use AbstractStorageBasedTypeProvider [guntamatic] add channel groups, add index to each channel (share same desciption), use AbstractStorageBasedTypeProvider Dec 18, 2024
@MikeTheTux MikeTheTux changed the title [guntamatic] add channel groups, add index to each channel (share same desciption), use AbstractStorageBasedTypeProvider [guntamatic] add channel groups, add index to each channel (share same description), use AbstractStorageBasedTypeProvider Dec 18, 2024
@MikeTheTux MikeTheTux mentioned this pull request Dec 18, 2024
Merged
@MikeTheTux MikeTheTux changed the title [guntamatic] add channel groups, add index to each channel (share same description), use AbstractStorageBasedTypeProvider [guntamatic] add channel groups, add index to each channel (for channels sharing same description), use AbstractStorageBasedTypeProvider Dec 18, 2024
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Dec 18, 2024
lsiepel
lsiepel requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What alternatives did you consider regarding the channel index prefixes?

bundles/org.openhab.binding.guntamatic/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.guntamatic/README.md Outdated Show resolved Hide resolved
...ding.guntamatic/src/main/java/org/openhab/binding/guntamatic/internal/GuntamaticHandler.java Outdated Show resolved Hide resolved
...ding.guntamatic/src/main/java/org/openhab/binding/guntamatic/internal/GuntamaticHandler.java Show resolved Hide resolved
@lsiepel lsiepel changed the title [guntamatic] add channel groups, add index to each channel (for channels sharing same description), use AbstractStorageBasedTypeProvider [guntamatic] Add channel groups Dec 18, 2024
@MikeTheTux
Copy link
Contributor Author

What alternatives did you consider regarding the channel index prefixes?

answer provided in the redundant comment

@MikeTheTux
implemented review fdings (lower-case-hyphen)
9eb7616 
Signed-off-by: Michael Weger <[email protected]>
@MikeTheTux
rebuild
c2e1219 
Signed-off-by: Michael Weger <[email protected]>
@MikeTheTux MikeTheTux requested a review from lsiepel December 19, 2024 09:02
lsiepel
lsiepel requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing it quickly, think these are my final comments.

bundles/org.openhab.binding.guntamatic/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.guntamatic/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.guntamatic/README.md Show resolved Hide resolved
bundles/org.openhab.binding.guntamatic/src/main/resources/OH-INF/update/update.xml Outdated Show resolved Hide resolved
@MikeTheTux
review findings, round #2
c54d957 
Signed-off-by: Michael Weger <[email protected]>
@MikeTheTux MikeTheTux requested a review from lsiepel December 19, 2024 12:09
lsiepel
lsiepel approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 84021f0 into openhab:main Dec 20, 2024
3 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Dec 20, 2024
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
@MikeTheTux
[guntamatic] Add channel groups (openhab#17901)
832ca4f 
* guntamatic indexed channels

Signed-off-by: Michael Weger <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
DrRSatzteil pushed a commit to DrRSatzteil/openhab-addons that referenced this pull request Jan 3, 2025
@MikeTheTux @DrRSatzteil
[guntamatic] Add channel groups (openhab#17901)
c2f5c06 
* guntamatic indexed channels

Signed-off-by: Michael Weger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@lolodomo lolodomo Awaiting requested review from lolodomo

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on (potentially) not backward compatible
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeTheTux @lsiepel