Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mqtt.homeassistant] Update Jinjava to 2.7.4 #17858

Merged
merged 2 commits into from
Dec 7, 2024
Merged

[mqtt.homeassistant] Update Jinjava to 2.7.4 #17858

merged 2 commits into from
Dec 7, 2024

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Dec 6, 2024

Which includes support for break/continue, which is what Zigbee2MQTT's new event component uses in their template.

@ccutrer
[mqtt.homeassistant] Update Jinjava to 2.7.4
37389ef 
Which includes support for break/continue, which is what Zigbee2MQTT's
new event component uses in their template.

Signed-off-by: Cody Cutrer <[email protected]>
@ccutrer ccutrer added bug An unexpected problem or unintended behavior of an add-on awaiting other PR Depends on another PR labels Dec 6, 2024
@ccutrer
Copy link
Contributor Author

ccutrer commented Dec 6, 2024

Depends on openhab/openhab-osgiify#56

lsiepel
lsiepel approved these changes Dec 7, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for dependency to be merged.

@wborn wborn added rebuild Triggers Jenkins PR build and removed awaiting other PR Depends on another PR rebuild Triggers Jenkins PR build labels Dec 7, 2024
@ccutrer ccutrer marked this pull request as ready for review December 7, 2024 16:24
@ccutrer ccutrer requested review from jochen314, antroids and a team as code owners December 7, 2024 16:24
wborn
wborn requested changes Dec 7, 2024
View reviewed changes
Copy link
Member

@wborn wborn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build fails because the runbundles in the itest.bndrun files still need to be updated:

Error:  Tests not run because project has errors
Error:  Error   : com.hubspot.jinjava.jinjava;version=[2.7.3,2.7.4) Not found in [bnd-cache

@ccutrer
update bndrun file
ae8e9a2 
Signed-off-by: Cody Cutrer <[email protected]>
@lsiepel lsiepel merged commit 5829b90 into openhab:main Dec 7, 2024
4 of 5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Dec 7, 2024
@ccutrer ccutrer deleted the mqtt-homeassistant-jinjava-2.7.4 branch December 7, 2024 23:07
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024
@ccutrer @matchews
[mqtt.homeassistant] Update Jinjava to 2.7.4 (openhab#17858)
b8b2fa8 
* [mqtt.homeassistant] Update Jinjava to 2.7.4

Which includes support for break/continue, which is what Zigbee2MQTT's
new event component uses in their template.

Signed-off-by: Cody Cutrer <[email protected]>

* update bndrun file

Signed-off-by: Cody Cutrer <[email protected]>

---------

Signed-off-by: Cody Cutrer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn requested changes

@lsiepel lsiepel lsiepel approved these changes

@jochen314 jochen314 Awaiting requested review from jochen314 jochen314 is a code owner

@antroids antroids Awaiting requested review from antroids antroids is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@ccutrer @wborn @lsiepel