Normalize thread names #17804

lsiepel · 2024-11-25T20:09:32Z

Normalize thread names:
OH-binding-<thingUID>
OH-binding-<thingUID>-<custom>
OH-binding-<bindingID>

Fixes: #8216

Signed-off-by: Leo Siepel <[email protected]>

andrewfg

LGTM for Hue

andrewfg · 2024-12-04T16:05:39Z

@lsiepel in addition to the bindings that you have so far included, you should perhaps also add bindings with classes that extend the Thread class => search phrase "extends Thread" . Or??

One such example is as follows..

openhab-addons/bundles/org.openhab.binding.govee/src/main/java/org/openhab/binding/govee/internal/CommunicationManager.java

Line 165 in 8d1471d

private class StatusReceiver extends Thread {

Signed-off-by: AndrewFG <[email protected]>

lsiepel · 2024-12-04T17:15:09Z

@lsiepel in addition to the bindings that you have so far included, you should perhaps also add bindings with classes that extend the Thread class => search phrase "extends Thread" . Or??

One such example is as follows..

Thanks I searched for ‘new Thread’ if you have more ideas let me know, will look into your suggestion.

Signed-off-by: Leo Siepel <[email protected]>

lsiepel · 2024-12-04T19:36:26Z

@lsiepel in addition to the bindings that you have so far included, you should perhaps also add bindings with classes that extend the Thread class => search phrase "extends Thread" . Or??

One such example is as follows..

Had a look and there are 57 possible hits. It would take some more time and don;t want to extend the scope for this PR at this moment. Maybe after 4.3.0 i'll create a follow up PR.

Signed-off-by: Leo Siepel <[email protected]>

andrewfg · 2024-12-05T14:57:17Z

Maybe after 4.3.0 i'll create a follow up PR.

If you wish, I can do that.

Signed-off-by: Leo Siepel <[email protected]>

andrewfg

Some comments/questions..

...penhab.binding.ekey/src/main/java/org/openhab/binding/ekey/internal/handler/EkeyHandler.java

...enhab.binding.hue/src/main/java/org/openhab/binding/hue/internal/connection/Clip2Bridge.java

...ng.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java

Signed-off-by: Leo Siepel <[email protected]>

...enhab.binding.hue/src/main/java/org/openhab/binding/hue/internal/connection/Clip2Bridge.java

Signed-off-by: Leo Siepel <[email protected]>

andrewfg

I have checked them all now. LGTM

andrewfg · 2024-12-06T13:07:53Z

@lsiepel the CI build is reporting "The Jenkins Controller is preparing for shutdown. No new builds can be started." .. it is not clear why that is the case .. but apart from that it all looks good to me.

morph166955

LGTM for AndroidTV

lsiepel · 2024-12-06T13:53:12Z

@lsiepel the CI build is reporting "The Jenkins Controller is preparing for shutdown. No new builds can be started." .. it is not clear why that is the case .. but apart from that it all looks good to me.

Jenkins is having trouble for some time, not related to this PR. i just ignore it, as long as the regular java builds succeeds....

hmerk

LGTM

druciak

LGTM for Satel

jlaur

Thanks for making this more consistent, and by that making it easier to monitor threads. I have added a few minor questions/remarks for consideration only.

....binding.ekey/src/main/java/org/openhab/binding/ekey/internal/api/EkeyUdpPacketReceiver.java

...ding.intesis/src/main/java/org/openhab/binding/intesis/internal/api/IntesisBoxSocketApi.java

....binding.milight/src/main/java/org/openhab/binding/milight/internal/protocol/QueuedSend.java

...k/src/main/java/org/openhab/binding/tellstick/internal/core/TelldusCoreDeviceController.java

...rc/main/java/org/openhab/binding/yeelight/internal/lib/device/connection/WifiConnection.java

…binding/milight/internal/protocol/QueuedSend.java Co-authored-by: Jacob Laursen <[email protected]> Signed-off-by: lsiepel <[email protected]>

…/binding/yeelight/internal/lib/device/connection/WifiConnection.java Co-authored-by: Jacob Laursen <[email protected]> Signed-off-by: lsiepel <[email protected]>

Signed-off-by: Leo Siepel <[email protected]>

…hab-addons into various-threadnames

jlaur

LGTM, thanks!

....binding.ekey/src/main/java/org/openhab/binding/ekey/internal/api/EkeyUdpPacketReceiver.java

...ding.intesis/src/main/java/org/openhab/binding/intesis/internal/api/IntesisBoxSocketApi.java

Revert unneeded changes Signed-off-by: Jacob Laursen <[email protected]>

Signed-off-by: Leo Siepel <[email protected]>

lsiepel added 5 commits November 25, 2024 21:07

Fix thread names

d63dc62

Signed-off-by: Leo Siepel <[email protected]>

Spotless

f7d58a5

Signed-off-by: Leo Siepel <[email protected]>

Spotless

2524457

Signed-off-by: Leo Siepel <[email protected]>

Build fix

9195772

Signed-off-by: Leo Siepel <[email protected]>

Fix build

8368069

Signed-off-by: Leo Siepel <[email protected]>

jlaur mentioned this pull request Nov 26, 2024

[wiz] Initial contribution #17681

Merged

lsiepel added 8 commits November 26, 2024 22:47

Fix build

3d8cfae

Signed-off-by: Leo Siepel <[email protected]>

Build fix

e381b31

Signed-off-by: Leo Siepel <[email protected]>

Spotless

d612469

Signed-off-by: Leo Siepel <[email protected]>

Fix Bridge referring to Thing

b7e6f95

Signed-off-by: Leo Siepel <[email protected]>

Spotless

c3e0add

Signed-off-by: Leo Siepel <[email protected]>

Fix mihome

dced319

Signed-off-by: Leo Siepel <[email protected]>

Merge branch 'openhab:main' into various-threadnames

dbbb4b0

Merge branch 'openhab:main' into various-threadnames

6fa26f0

andrewfg approved these changes Dec 4, 2024

View reviewed changes

andrewfg added a commit to andrewfg/openhab-addons that referenced this pull request Dec 4, 2024

normalize thread name (see openhab#17804)

34d9731

Signed-off-by: AndrewFG <[email protected]>

andrewfg mentioned this pull request Dec 4, 2024

[govee] Fix brightness vs. color synchronization #17812

Merged

Fix some more

02b85ad

Signed-off-by: Leo Siepel <[email protected]>

Fix import

7308a98

Signed-off-by: Leo Siepel <[email protected]>

Russound import

e992978

Signed-off-by: Leo Siepel <[email protected]>

andrewfg mentioned this pull request Dec 5, 2024

Normalize thread names (2) #17849

Merged

Fix last imports

d5c3090

Signed-off-by: Leo Siepel <[email protected]>

lsiepel marked this pull request as ready for review December 5, 2024 19:39

lsiepel requested review from claell, steand and a team as code owners December 5, 2024 19:39

lsiepel requested review from hmerk, cweitkamp, mhilbush and morph166955 as code owners December 5, 2024 19:39

lsiepel added 2 commits December 5, 2024 22:44

Merge branch 'main' into various-threadnames

aa18b4f

Signed-off-by: Leo Siepel <[email protected]>

Fix result of conflict

bf4c7ad

Signed-off-by: Leo Siepel <[email protected]>

andrewfg requested changes Dec 5, 2024

View reviewed changes

Fix review comment

22327d6

Signed-off-by: Leo Siepel <[email protected]>

andrewfg reviewed Dec 6, 2024

View reviewed changes

...enhab.binding.hue/src/main/java/org/openhab/binding/hue/internal/connection/Clip2Bridge.java Outdated Show resolved Hide resolved

Fix review comment 2

3db75e6

Signed-off-by: Leo Siepel <[email protected]>

andrewfg approved these changes Dec 6, 2024

View reviewed changes

andrewfg added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Dec 6, 2024

morph166955 approved these changes Dec 6, 2024

View reviewed changes

hmerk approved these changes Dec 6, 2024

View reviewed changes

druciak approved these changes Dec 6, 2024

View reviewed changes

jlaur reviewed Dec 6, 2024

View reviewed changes

lsiepel and others added 4 commits December 7, 2024 12:52

Update bundles/org.openhab.binding.milight/src/main/java/org/openhab/…

2fb6ee4

…binding/milight/internal/protocol/QueuedSend.java Co-authored-by: Jacob Laursen <[email protected]> Signed-off-by: lsiepel <[email protected]>

Update bundles/org.openhab.binding.yeelight/src/main/java/org/openhab…

df1aedd

…/binding/yeelight/internal/lib/device/connection/WifiConnection.java Co-authored-by: Jacob Laursen <[email protected]> Signed-off-by: lsiepel <[email protected]>

Fix review comments

5a592ec

Signed-off-by: Leo Siepel <[email protected]>

Merge branch 'various-threadnames' of https://github.com/lsiepel/open…

04b7cd7

…hab-addons into various-threadnames

jlaur approved these changes Dec 7, 2024

View reviewed changes

Apply suggestions from code review

3e41a10

Revert unneeded changes Signed-off-by: Jacob Laursen <[email protected]>

jlaur merged commit fb54c2b into openhab:main Dec 8, 2024
5 checks passed

jlaur added this to the 4.3 milestone Dec 8, 2024

lsiepel deleted the various-threadnames branch December 8, 2024 07:51

jsetton mentioned this pull request Dec 14, 2024

[insteon] Convert legacy threads to use scheduler service #17904

Merged

matchews pushed a commit to matchews/openhab-addons that referenced this pull request Dec 16, 2024

Normalize thread names (openhab#17804)

52c60f8

Signed-off-by: Leo Siepel <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Normalize thread names #17804

Normalize thread names #17804

lsiepel commented Nov 25, 2024 •

edited

Loading

andrewfg left a comment

andrewfg commented Dec 4, 2024

lsiepel commented Dec 4, 2024 •

edited

Loading

lsiepel commented Dec 4, 2024 •

edited

Loading

andrewfg commented Dec 5, 2024

andrewfg left a comment

andrewfg left a comment

andrewfg commented Dec 6, 2024

morph166955 left a comment

lsiepel commented Dec 6, 2024

hmerk left a comment

druciak left a comment

jlaur left a comment •

edited

Loading

jlaur left a comment

Normalize thread names #17804

Normalize thread names #17804

Conversation

lsiepel commented Nov 25, 2024 • edited Loading

andrewfg left a comment

Choose a reason for hiding this comment

andrewfg commented Dec 4, 2024

lsiepel commented Dec 4, 2024 • edited Loading

lsiepel commented Dec 4, 2024 • edited Loading

andrewfg commented Dec 5, 2024

andrewfg left a comment

Choose a reason for hiding this comment

andrewfg left a comment

Choose a reason for hiding this comment

andrewfg commented Dec 6, 2024

morph166955 left a comment

Choose a reason for hiding this comment

lsiepel commented Dec 6, 2024

hmerk left a comment

Choose a reason for hiding this comment

druciak left a comment

Choose a reason for hiding this comment

jlaur left a comment • edited Loading

Choose a reason for hiding this comment

jlaur left a comment

Choose a reason for hiding this comment

lsiepel commented Nov 25, 2024 •

edited

Loading

lsiepel commented Dec 4, 2024 •

edited

Loading

lsiepel commented Dec 4, 2024 •

edited

Loading

jlaur left a comment •

edited

Loading