[a-d] Fix @ActionOutput annotations #17644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
Related to openhab#17636 Signed-off-by: Laurent Garnier <[email protected]> Deconz
lolodomo
force-pushed
the
fix_actionoutput_1
branch
from
0e1a95e
to
70611b7
Compare
lolodomo
changed the title
lsiepel
reviewed
Oct 28, 2024
...ab.binding.deconz/src/main/java/org/openhab/binding/deconz/internal/action/GroupActions.java
Show resolved
Hide resolved
florian-h05
reviewed
Oct 28, 2024
| @@ -66,7 +66,7 @@ public void setThingHandler(@Nullable ThingHandler handler) { | |||
| } | |||
|
|
|||
| @RuleAction(label = "get the azimuth", description = "Get the azimuth for a given time.") | |||
| public @Nullable @ActionOutput(name = "getAzimuth", label = "Azimuth", type = "org.openhab.core.library.types.QuantityType<javax.measure.quantity.Angle>") QuantityType<Angle> getAzimuth( | |||
| public @Nullable @ActionOutput(name = "result", label = "Azimuth", type = "org.openhab.core.library.types.QuantityType<javax.measure.quantity.Angle>") QuantityType<Angle> getAzimuth( | |||
There was a problem hiding this comment.
@lolodomo Just FYI, it should be possible to leave out the name as it now defaults to result inside the core code.
There was a problem hiding this comment.
@lsiepel @florian-h05 : your suggestion is to set name parameters or not ?
There was a problem hiding this comment.
I would suggest to not set names for actions with a single output.
There was a problem hiding this comment.
Maybe a little redundant, but also less error prone to have them explicitly set. I'm fine with either one, as long as we are consistent.
There was a problem hiding this comment.
Let's choose to not include name.
KaaNee
pushed a commit
to KaaNee/openhab-addons
that referenced
this pull request
Nov 8, 2024
Related to openhab#17636 Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #17636