-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mqtt.homeassistant] Implement template schema lights #17399
[mqtt.homeassistant] Implement template schema lights #17399
Conversation
Yay! The initial commit of this PR only happened nearly 2 years ago. And now it can actually be merged in! |
96095a2
to
e1ec05b
Compare
Signed-off-by: Cody Cutrer <[email protected]>
e1ec05b
to
e79dab6
Compare
What took you so long ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some code style improvements.
Edit: Some how the line numbers are a bit off for this review, hope you can place the suggestions at the correct line. Will look into why this is happening in vscode.
...main/java/org/openhab/binding/mqtt/homeassistant/internal/component/TemplateSchemaLight.java
Show resolved
Hide resolved
...main/java/org/openhab/binding/mqtt/homeassistant/internal/component/TemplateSchemaLight.java
Outdated
Show resolved
Hide resolved
...main/java/org/openhab/binding/mqtt/homeassistant/internal/component/TemplateSchemaLight.java
Outdated
Show resolved
Hide resolved
...main/java/org/openhab/binding/mqtt/homeassistant/internal/component/TemplateSchemaLight.java
Show resolved
Hide resolved
...main/java/org/openhab/binding/mqtt/homeassistant/internal/component/TemplateSchemaLight.java
Outdated
Show resolved
Hide resolved
...main/java/org/openhab/binding/mqtt/homeassistant/internal/component/TemplateSchemaLight.java
Show resolved
Hide resolved
...main/java/org/openhab/binding/mqtt/homeassistant/internal/component/TemplateSchemaLight.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Cody Cutrer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
* [mqtt.homeassistant] implement template schema lights Signed-off-by: Cody Cutrer <[email protected]>
* [mqtt.homeassistant] implement template schema lights Signed-off-by: Cody Cutrer <[email protected]> Signed-off-by: Patrik Gfeller <[email protected]>
* [mqtt.homeassistant] implement template schema lights Signed-off-by: Cody Cutrer <[email protected]>
* [mqtt.homeassistant] implement template schema lights Signed-off-by: Cody Cutrer <[email protected]>
* [mqtt.homeassistant] implement template schema lights Signed-off-by: Cody Cutrer <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>
No description provided.