Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt.homeassistant] Implement template schema lights #17399

Merged

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Sep 10, 2024

No description provided.

@ccutrer ccutrer added the enhancement An enhancement or new feature for an existing add-on label Sep 10, 2024
@ccutrer ccutrer requested a review from lsiepel September 10, 2024 15:07
@ccutrer ccutrer requested a review from antroids as a code owner September 10, 2024 15:07
@ccutrer
Copy link
Contributor Author

ccutrer commented Sep 10, 2024

Yay! The initial commit of this PR only happened nearly 2 years ago. And now it can actually be merged in!

@ccutrer ccutrer force-pushed the mqtt-homeassistant-template-schema-light branch from 96095a2 to e1ec05b Compare September 10, 2024 15:08
@ccutrer ccutrer force-pushed the mqtt-homeassistant-template-schema-light branch from e1ec05b to e79dab6 Compare September 10, 2024 15:09
@lsiepel
Copy link
Contributor

lsiepel commented Sep 10, 2024

Yay! The initial commit of this PR only happened nearly 2 years ago. And now it can actually be merged in!

What took you so long ;-)

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some code style improvements.

Edit: Some how the line numbers are a bit off for this review, hope you can place the suggestions at the correct line. Will look into why this is happening in vscode.

Signed-off-by: Cody Cutrer <[email protected]>
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 436dea6 into openhab:main Sep 10, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Sep 10, 2024
@ccutrer ccutrer deleted the mqtt-homeassistant-template-schema-light branch September 10, 2024 21:11
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Sep 24, 2024
* [mqtt.homeassistant] implement template schema lights

Signed-off-by: Cody Cutrer <[email protected]>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
* [mqtt.homeassistant] implement template schema lights

Signed-off-by: Cody Cutrer <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* [mqtt.homeassistant] implement template schema lights

Signed-off-by: Cody Cutrer <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
* [mqtt.homeassistant] implement template schema lights

Signed-off-by: Cody Cutrer <[email protected]>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
* [mqtt.homeassistant] implement template schema lights

Signed-off-by: Cody Cutrer <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants