Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hue] Fix compile warnings #17293

Merged
merged 6 commits into from
Aug 19, 2024
Merged

[hue] Fix compile warnings #17293

merged 6 commits into from
Aug 19, 2024

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Aug 19, 2024

Fixed the warnings introduced by updating the lastnpe version.

Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Leo Siepel <[email protected]>
Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsiepel many thanks for this. I have not explored in full detail but I already found a bug in your code.

Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Leo Siepel <[email protected]>
Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thankyou.

@andrewfg
Copy link
Contributor

@lsiepel there is a merge conflict with my own PR which was merged just now.

Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (again) thank you.

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit ba6cef3 into openhab:main Aug 19, 2024
5 checks passed
@jlaur jlaur added this to the 4.3 milestone Aug 19, 2024
@jlaur jlaur added the regression Regression that happened during the development of a release. Not shown on final release notes. label Aug 19, 2024
@lsiepel lsiepel deleted the hue-fix-warnings branch August 19, 2024 22:38
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants