Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[freeboxos] First big update of README #17279

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

lolodomo
Copy link
Contributor

Fixes #17074
Fixes #17077
Fixes #17080

Signed-off-by: Laurent Garnier [email protected]

@lolodomo lolodomo requested a review from clinique as a code owner August 17, 2024 17:45
@lolodomo lolodomo added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Aug 17, 2024
Copy link
Contributor

@clinique clinique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this ! LGTM

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement has been done this binding and now also to the documentation!
One minor comment is that all readme.md headers should be capitalized, otherwise LGTM

@lolodomo
Copy link
Contributor Author

One minor comment is that all readme.md headers should be capitalized

You mean the first letter ?

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo force-pushed the freeboxos_upd_README_1 branch from 229dbff to deadfcb Compare August 19, 2024 07:02
@lolodomo
Copy link
Contributor Author

Done

@lsiepel
Copy link
Contributor

lsiepel commented Aug 19, 2024

One minor comment is that all readme.md headers should be capitalized

You mean the first letter ?

Each word.

bundles/org.openhab.binding.freeboxos/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.freeboxos/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.freeboxos/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.freeboxos/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.freeboxos/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.freeboxos/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.freeboxos/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.freeboxos/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.freeboxos/README.md Outdated Show resolved Hide resolved
@lolodomo
Copy link
Contributor Author

Each word.

Done.
I kept the plural (Things) when the section concerns several thing types.

lsiepel

This comment was marked as outdated.

@lsiepel lsiepel merged commit 43cc09a into openhab:main Aug 19, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Aug 19, 2024
@lolodomo lolodomo deleted the freeboxos_upd_README_1 branch August 19, 2024 18:59
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
* [freeboxos] First big update of README

Fixes openhab#17074
Fixes openhab#17077
Fixes openhab#17080

Signed-off-by: Laurent Garnier <[email protected]>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
* [freeboxos] First big update of README

Fixes openhab#17074
Fixes openhab#17077
Fixes openhab#17080

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* [freeboxos] First big update of README

Fixes openhab#17074
Fixes openhab#17077
Fixes openhab#17080

Signed-off-by: Laurent Garnier <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
* [freeboxos] First big update of README

Fixes openhab#17074
Fixes openhab#17077
Fixes openhab#17080

Signed-off-by: Laurent Garnier <[email protected]>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
* [freeboxos] First big update of README

Fixes openhab#17074
Fixes openhab#17077
Fixes openhab#17080

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants