-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsscripting] Add info about npm requiring path #17022
Conversation
The command to install an npm package that was suggested in the documentation would not work, as it was missing the required path. I've added information to explain this is required. Signed-off-by: SkyLined <[email protected]>
As step 4 is already asking to do the command ‘ from your library's folder’, adding the path at step 5 is not needed. Or what am I missing? |
I think the point here is, that the tarball is in the library folder and not inside automation/js. |
Having a copy of the tarball in Assuming something is self-explanatory is the most common flaw in documentation, please do not leave out information unless it really clutters the page (in which case, link to another page that provide it). In this case, it doesn't clutter but is a useful reminder to provide the path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@SkyLined Can you please open a PR to openhab-js to apply the change there as well? |
The command to install an npm package that was suggested in the documentation would not work, as it was missing the required path. I've added information to explain this is required. Signed-off-by: SkyLined <[email protected]>
Signed-off-by: Florian Hotze <[email protected]>
The command to install an npm package that was suggested in the documentation would not work, as it was missing the required path. I've added information to explain this is required. Signed-off-by: SkyLined <[email protected]> Signed-off-by: Patrik Gfeller <[email protected]>
The command to install an npm package that was suggested in the documentation would not work, as it was missing the required path. I've added information to explain this is required. Signed-off-by: SkyLined <[email protected]>
The command to install an npm package that was suggested in the documentation would not work, as it was missing the required path. I've added information to explain this is required. Signed-off-by: SkyLined <[email protected]>
The command to install an npm package that was suggested in the documentation would not work, as it was missing the required path. I've added information to explain this is required. Signed-off-by: SkyLined <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>
The command to install an npm package that was suggested in the documentation would not work, as it was missing the required path. I've added information to explain this is required.