[monopriceaudio] Fix compiler warnings and code improvements #16991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lobstein <[email protected]>
jlaur
added
rebuild
|
@mlobstein - #16875 is merged, so you might want to rebase and have a look at the new result. |
Signed-off-by: Michael Lobstein <[email protected]>
mlobstein
force-pushed
the
monoprice_improvements
branch
from
f797638 to
c652b52
Compare
Got it. Should be good now. |
lsiepel
reviewed
Jul 15, 2024
.../src/main/java/org/openhab/binding/monopriceaudio/internal/communication/AmplifierModel.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Lobstein <[email protected]>
mlobstein
force-pushed
the
monoprice_improvements
branch
from
9a8a17a to
8b0a65b
Compare
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Jul 18, 2024
…#16991) * Fix compiler warnings and code improvements Signed-off-by: Michael Lobstein <[email protected]>
digitaldan
pushed a commit
to digitaldan/openhab-addons
that referenced
this pull request
Aug 29, 2024
…#16991) * Fix compiler warnings and code improvements Signed-off-by: Michael Lobstein <[email protected]>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
…#16991) * Fix compiler warnings and code improvements Signed-off-by: Michael Lobstein <[email protected]> Signed-off-by: Patrik Gfeller <[email protected]>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…#16991) * Fix compiler warnings and code improvements Signed-off-by: Michael Lobstein <[email protected]>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
…#16991) * Fix compiler warnings and code improvements Signed-off-by: Michael Lobstein <[email protected]>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
…#16991) * Fix compiler warnings and code improvements Signed-off-by: Michael Lobstein <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all compiler warnings and replace some code with lambdas.