-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[evcc] Adjust to evcc 0.125.0 API changes #16660
Conversation
…ed' and 'pvConfigured' Signed-off-by: Michael Weger <[email protected]>
04494dd
to
288a37e
Compare
Signed-off-by: Michael Weger <[email protected]>
Signed-off-by: Michael Weger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, thanks!
Please have a look at my comments.
...es/org.openhab.binding.evcc/src/main/java/org/openhab/binding/evcc/internal/EvccHandler.java
Outdated
Show resolved
Hide resolved
...es/org.openhab.binding.evcc/src/main/java/org/openhab/binding/evcc/internal/EvccHandler.java
Outdated
Show resolved
Hide resolved
...org.openhab.binding.evcc/src/main/java/org/openhab/binding/evcc/internal/api/dto/Result.java
Show resolved
Hide resolved
Please also update the README wrt evcc version. |
Done. Please check if I should keep the update as it is or simplify it (mention version 125.0 only) |
Signed-off-by: Michael Weger <[email protected]>
Signed-off-by: Michael Weger <[email protected]>
This reverts commit aa0c3c0. Signed-off-by: Michael Weger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your changes!
Just two minor comments left.
...org.openhab.binding.evcc/src/main/java/org/openhab/binding/evcc/internal/api/dto/Result.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Weger <[email protected]>
Signed-off-by: Michael Weger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@openhab/add-ons-maintainers Can you please merge?
* avoid deprecated parameters evcc rest API parameters 'batteryConfigured' and 'pvConfigured' Signed-off-by: Michael Weger <[email protected]>
* avoid deprecated parameters evcc rest API parameters 'batteryConfigured' and 'pvConfigured' Signed-off-by: Michael Weger <[email protected]> (cherry picked from commit 6db28f5)
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
* avoid deprecated parameters evcc rest API parameters 'batteryConfigured' and 'pvConfigured' Signed-off-by: Michael Weger <[email protected]> Signed-off-by: Paul Smedley <[email protected]>
* avoid deprecated parameters evcc rest API parameters 'batteryConfigured' and 'pvConfigured' Signed-off-by: Michael Weger <[email protected]> Signed-off-by: Patrik Gfeller <[email protected]>
* avoid deprecated parameters evcc rest API parameters 'batteryConfigured' and 'pvConfigured' Signed-off-by: Michael Weger <[email protected]>
* avoid deprecated parameters evcc rest API parameters 'batteryConfigured' and 'pvConfigured' Signed-off-by: Michael Weger <[email protected]>
* avoid deprecated parameters evcc rest API parameters 'batteryConfigured' and 'pvConfigured' Signed-off-by: Michael Weger <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>
Implementation of #16658 due to evcc-io/evcc#13463.
The change is backward compatible.