Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openwebnet] Thermo: new channels and README updates #16652

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

mvalla
Copy link
Contributor

@mvalla mvalla commented Apr 14, 2024

Depends on #16626.

This PR adds these changes:

  • new channels: targetTemperature, heating and coolng for bus_thermo_zone Things
  • code for updateModeAndFunction() improved/fixed for better handling of *4*1*where## messages when changing between Winter/Summer thermo functions
  • updated README to add more references to MyHOME system name; added new device images.

Fixes #12019.

@mvalla mvalla added enhancement An enhancement or new feature for an existing add-on awaiting other PR Depends on another PR labels Apr 14, 2024
@mvalla mvalla requested a review from lolodomo April 14, 2024 06:10
@lsiepel lsiepel removed the awaiting other PR Depends on another PR label Apr 15, 2024
@lolodomo
Copy link
Contributor

Rebase needed to solve conflicts.

@mvalla mvalla force-pushed the openwebnet-thermo-new-channels branch from a807820 to d73a355 Compare April 15, 2024 07:05
@mvalla
Copy link
Contributor Author

mvalla commented Apr 15, 2024

Rebase needed to solve conflicts.

@lolodomo done thanks!

@mvalla mvalla requested a review from lolodomo April 18, 2024 18:05
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 342b7b8 into openhab:main Apr 18, 2024
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Apr 18, 2024
lo92fr pushed a commit to lo92fr/openhab-addons that referenced this pull request Apr 30, 2024
* [openwebnet] added new channels: targetTemperature, heating and cooling to bus_thermo_zone
Fixes openhab#12019
* [openwebnet] cleaner code in updateModeAndFunction() to handle *4*1*w## messages
* [openwebnet] Updated README. Added new device images

---------

Signed-off-by: Massimo Valla <[email protected]>
@mvalla mvalla deleted the openwebnet-thermo-new-channels branch June 11, 2024 07:13
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
* [openwebnet] added new channels: targetTemperature, heating and cooling to bus_thermo_zone
Fixes openhab#12019
* [openwebnet] cleaner code in updateModeAndFunction() to handle *4*1*w## messages
* [openwebnet] Updated README. Added new device images

---------

Signed-off-by: Massimo Valla <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* [openwebnet] added new channels: targetTemperature, heating and cooling to bus_thermo_zone
Fixes openhab#12019
* [openwebnet] cleaner code in updateModeAndFunction() to handle *4*1*w## messages
* [openwebnet] Updated README. Added new device images

---------

Signed-off-by: Massimo Valla <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
* [openwebnet] added new channels: targetTemperature, heating and cooling to bus_thermo_zone
Fixes openhab#12019
* [openwebnet] cleaner code in updateModeAndFunction() to handle *4*1*w## messages
* [openwebnet] Updated README. Added new device images

---------

Signed-off-by: Massimo Valla <[email protected]>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
* [openwebnet] added new channels: targetTemperature, heating and cooling to bus_thermo_zone
Fixes openhab#12019
* [openwebnet] cleaner code in updateModeAndFunction() to handle *4*1*w## messages
* [openwebnet] Updated README. Added new device images

---------

Signed-off-by: Massimo Valla <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[openwebnet] Thermo: add heating channel of type switch in addition to heatingValves
3 participants