[tellstick] Adopt new API url

[andrewfg]

Resolves #15987

Note: not (yet) tested.

Signed-off-by: Andrew Fiddian-Green [email protected]

[andrewfg]

Ping @ulfwin @dabj123

[wborn]

It looks good to me except for this comment:

[andrewfg]

The jar file for testing is here..

https://github.com/andrewfg/openhab-addons/releases/download/v1/org.openhab.binding.tellstick-4.2.0-SNAPSHOT.jar

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/telldus-live-tellstick-binding-need-new-api/151646/4

[wborn]

Thanks! LGTM now 👍

[dabj123]

How about?

• Do not make more than 10 requests to pa-api.telldus.com per minute.
• Double-check that your scripts do not attempt to contact the Telldus API again without waiting for at least 10 seconds. Retry without delay will result in HTTP 429 error.

[wborn]

Maybe you can create a PR for that @dabj123?
It's not easy to implement and test if you do not use Tellstick.

[andrewfg]

Do not make more than 10 requests to pa-api.telldus.com per minute.

The polling rate of the binding is 10 seconds (so 6 calls per minute) .. so I presume that is Ok.

do not attempt to contact the Telldus API again without waiting for at least 10 seconds
It's not easy to implement and test if you do not use Tellstick.

I agree with @wborn :)

[lsiepel]

LGTM

Can this be cherry picked to 4.1.x?

[lolodomo]

Was this change tested by someone and reported as fixing the issues?

[jlaur]

Can this be cherry picked to 4.1.x?

I don't think so. openhab/openhab-core#3922 was introduced only in 4.2. It would have been better with separate PR's for the URL bugfix and the USB suggestion enhancement. @andrewfg - will you be able to split the PR on short notice in order to possible get the URL fix into 4.1.1?

[jlaur]

Was this change tested by someone and reported as fixing the issues?

Ping @dabj123, @ulfwin

[ulfwin]

I actually bought another base station using the local API as a work around, rather than Telldus live. If @dabj123 still uses live, it's probably easier to test for him.

[jlaur]

I checked https://telldus.com/driftinformation/ which is in Swedish (which is readable for me as Danish 🙂):

Om du använder våra API-tjänster, vänligen notera följande:

• Använd INTE api.telldus.com. Din IP kommer automatiskt att blockeras. Byt till pa-api.telldus.com om du inte redan har gjort det.
• Gör inte mer än 10 förfrågningar till pa-api.telldus.com per minut.
• Kontrollera och dubbelkolla att dina skript inte gör nya försök att kontakta Telldus API utan att vänta minst 10 sekunder. Försök på nytt utan fördröjning kommer innebära HTTP 429 error.

The first bullet "Använd INTE api.telldus.com. Din IP kommer automatiskt att blockeras." means: "do NOT use api.telldus.com. Your IP will automatically be blocked." So we can safely merge as it's pretty clear the old endpoint cannot be used anymore.

[andrewfg]

which is in Swedish (which is readable for me as Danish

@jlaur yes I could read it too .. via Google Translate ;)

[dabj123]

I still use Telldus live bridge, but it seams to not work for me with new jar "org.openhab.binding.tellstick-4.2.0-SNAPSHOT.jar"

Request [http://pa-api.telldus.com/xml/devices/list?supportedMethods=19] failed: ExecutionException HTTP request returned status code 401
2024-01-07 15:06:53.774 [WARN ] [ternal.live.TelldusLiveBridgeHandler] - Failed to update
org.openhab.binding.tellstick.internal.live.TelldusLiveException: HTTP request returned status code 401
at org.openhab.binding.tellstick.internal.live.TelldusLiveDeviceController.callRestMethod(TelldusLiveDeviceController.java:299) ~[?:?]
at org.openhab.binding.tellstick.internal.live.TelldusLiveBridgeHandler.updateDevices(TelldusLiveBridgeHandler.java:155) ~[?:?]
at org.openhab.binding.tellstick.internal.live.TelldusLiveBridgeHandler.refreshDeviceList(TelldusLiveBridgeHandler.java:124) ~[?:?]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) [?:?]
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305) [?:?]
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305) [?:?]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
at java.lang.Thread.run(Thread.java:833) [?:?]
Caused by: java.util.concurrent.ExecutionException: HTTP request returned status code 401
at org.openhab.binding.tellstick.internal.live.TelldusLiveDeviceController.innerCallRest(TelldusLiveDeviceController.java:350) ~[?:?]
at org.openhab.binding.tellstick.internal.live.TelldusLiveDeviceController.callRestMethod(TelldusLiveDeviceController.java:290) ~[?:?]
... 8 more

[andrewfg]

it seams to not work for me with new jar

@dabj123 an HTTP 401 error means 'authentication failed' so check your login credentials please.

[dabj123]

I know that, but I have double check every thing and generate new keys, but still recieve 401 or 429.

[lsiepel]

I know that, but I have double check every thing and generate new keys, but still recieve 401 or 429.

Could you open a new issue to investigate that?

[andrewfg]

but still recieve 401 or 429

@dabj123 these are TWO different issues..

• HTTP 401 is an authentication error
• HTTP 429 is because you are sending a retry request faster than 10 seconds "Kontrollera och dubbelkolla att dina skript inte gör nya försök att kontakta Telldus API utan att vänta minst 10 sekunder. Försök på nytt utan fördröjning kommer innebära HTTP 429 error."

I am guessing that if the HTTP 401 error is fixed, then there will not be any retries, so the HTTP 429 error will probably go away.

[dabj123]

Request [http://pa-api.telldus.com/xml/devices/list?supportedMethods=19] failed: ExecutionException HTTP request returned status code 401

OAuth Verification Failed: Can't verify request, missing oauth_consumer_key or oauth_token

[andrewfg]

OAuth Verification Failed: Can't verify request, missing oauth_consumer_key or oauth_token

@dabj123 you are the TellStick user (apparently the only one) so only you know how to renew your user key or token. I cannot help you since I do not know the binding or the application.

[dabj123]

I have renew new keys etc. Maybe TellStick have new logic in the new api to handle OAuth Verification...

[andrewfg]

^
https://api.telldus.com/documentation/live