Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilerArguments deprecation warnings #15504

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Conversation

wborn
Copy link
Member

@wborn wborn commented Aug 26, 2023

This fixes the following warnings:

[WARNING] Parameter 'compilerArguments' is deprecated: use {@link #compilerArgs} instead.

Related to openhab/openhab-core#3512

@wborn wborn requested a review from a team as a code owner August 26, 2023 14:18
This fixes the following warnings:

```
[WARNING] Parameter 'compilerArguments' is deprecated: use {@link #compilerArgs} instead.
```

Related to openhab/openhab-core#3512

Signed-off-by: Wouter Born <[email protected]>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@J-N-K
Copy link
Member

J-N-K commented Aug 26, 2023

Did you check that it still works properly? I remember having tried the same thing and the EEA were no longer used.

@wborn
Copy link
Member Author

wborn commented Aug 26, 2023

Did you check that it still works properly?

Yes it still worked for me when I did some testing.
I also noticed it can be configured using a property as it is done in the webui project.

@wborn
Copy link
Member Author

wborn commented Aug 26, 2023

I also noticed it can be configured using a property as it is done in the webui project.

I think if you use the property it will only be used in Eclipse and not with the compiler on CLI builds.

@wborn
Copy link
Member Author

wborn commented Aug 26, 2023

I think if you use the property it will only be used in Eclipse and not with the compiler on CLI builds.

There's now openhab/openhab-webui#2042 to fix this.

@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Aug 26, 2023
@jlaur jlaur merged commit d1a6914 into openhab:main Aug 27, 2023
@jlaur jlaur added this to the 4.1 milestone Aug 27, 2023
@wborn wborn deleted the compiler-args branch August 27, 2023 11:55
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Sep 29, 2023
This fixes the following warnings:

```
[WARNING] Parameter 'compilerArguments' is deprecated: use {@link #compilerArgs} instead.
```

Related to openhab/openhab-core#3512

Signed-off-by: Wouter Born <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
This fixes the following warnings:

```
[WARNING] Parameter 'compilerArguments' is deprecated: use {@link #compilerArgs} instead.
```

Related to openhab/openhab-core#3512

Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants