Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[freeboxos] Align audio sink to freebox binding #15207

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Jul 8, 2023

Related to #15113

Signed-off-by: Laurent Garnier [email protected]

@lolodomo lolodomo requested a review from clinique as a code owner July 8, 2023 11:45
@lolodomo lolodomo mentioned this pull request Jul 8, 2023
13 tasks
Copy link
Contributor

@clinique clinique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question since I'm not into Freebox, and don't know if Apple-related.

@jlaur jlaur merged commit 5c32f80 into openhab:main Jul 12, 2023
@jlaur jlaur added this to the 4.0 milestone Jul 12, 2023
@lolodomo lolodomo deleted the freeboxos_sink branch July 12, 2023 09:52
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Related to openhab#15113

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants