Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[allplay] Support for more audio streams through the HTTP audio servlet #15201

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Jul 7, 2023

Related to #15113

Signed-off-by: Laurent Garnier [email protected]

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Jul 7, 2023
@lolodomo lolodomo requested a review from dominicdesu as a code owner July 7, 2023 19:21
@lolodomo lolodomo mentioned this pull request Jul 7, 2023
13 tasks
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment.

@jlaur
Copy link
Contributor

jlaur commented Jul 12, 2023

@dalgwen - do you want to have a look?

Copy link
Contributor

@dalgwen dalgwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nothing to add

@lolodomo lolodomo force-pushed the allplay_audiosink branch from cbb851d to 271e276 Compare July 12, 2023 19:20
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaikreuzer kaikreuzer added this to the 4.0 milestone Jul 12, 2023
@kaikreuzer kaikreuzer merged commit 25314d4 into openhab:main Jul 12, 2023
@lolodomo lolodomo deleted the allplay_audiosink branch July 12, 2023 19:57
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
…et (openhab#15201)

* [allplay] Support for more audio streams through the HTTP audio servlet

Related to openhab#15113

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants