[kodi] Support for more audio streams through the HTTP audio servlet #15192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[kodi] Audio sink supporting more audio streams Related to openhab#15113 Signed-off-by: Gwendal Roulleau <[email protected]>
lolodomo
requested changes
Jul 6, 2023
.../org.openhab.binding.kodi/src/main/java/org/openhab/binding/kodi/internal/KodiAudioSink.java
Outdated
Show resolved
Hide resolved
.../org.openhab.binding.kodi/src/main/java/org/openhab/binding/kodi/internal/KodiAudioSink.java
Outdated
Show resolved
Hide resolved
.../org.openhab.binding.kodi/src/main/java/org/openhab/binding/kodi/internal/KodiAudioSink.java
Show resolved
Hide resolved
.../org.openhab.binding.kodi/src/main/java/org/openhab/binding/kodi/internal/KodiAudioSink.java
Show resolved
Hide resolved
Apply code review and fix a x10 factor in a wait loop. Signed-off-by: Gwendal Roulleau <[email protected]>
lolodomo
requested changes
Jul 6, 2023
.../org.openhab.binding.kodi/src/main/java/org/openhab/binding/kodi/internal/KodiAudioSink.java
Outdated
Show resolved
Hide resolved
lolodomo
added
the
enhancement
Apply code review to handle URLAudioStream asynchronously. Signed-off-by: Gwendal Roulleau <[email protected]>
lolodomo
requested changes
Jul 8, 2023
.../org.openhab.binding.kodi/src/main/java/org/openhab/binding/kodi/internal/KodiAudioSink.java
Outdated
Show resolved
Hide resolved
Apply code review Signed-off-by: Gwendal Roulleau <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Jul 8, 2023
…penhab#15192) * [kodi] Support for more audio streams through the HTTP audio servlet [kodi] Audio sink supporting more audio streams Related to openhab#15113 --------- Signed-off-by: Gwendal Roulleau <[email protected]>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Aug 9, 2023
…penhab#15192) * [kodi] Support for more audio streams through the HTTP audio servlet [kodi] Audio sink supporting more audio streams Related to openhab#15113 --------- Signed-off-by: Gwendal Roulleau <[email protected]> Signed-off-by: Matt Myers <[email protected]>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…penhab#15192) * [kodi] Support for more audio streams through the HTTP audio servlet [kodi] Audio sink supporting more audio streams Related to openhab#15113 --------- Signed-off-by: Gwendal Roulleau <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kodi audio sink supporting more audio streams, with the help of the HTTP audio servlet new capabilities.
Also (slightly) better volume restoration from openHAB.
Related to #15113
Note : The previous system for volume restoration (inside kodi binding) doesn't seem to work. It seems to try to guess when play ends by waiting for state that doesn't happen, and/or for not enough time ?
Plus, when openHAB tried to handle volume, both of them modified it at different time, leading to a mess. I added a boolean to avoid conflict.
So I replace it with the sound duration analysis from the servlet.
It's better but it is not reliable either, because Kodi keep requesting the stream again and again, resetting the time we consider as the "start".