[pulseaudio] Make the process method asynchronous #15179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And use the new 'complete' system to signal core that the sound is fully played. Signed-off-by: Gwendal Roulleau <[email protected]>
lolodomo
requested changes
Jul 5, 2023
...lseaudio/src/main/java/org/openhab/binding/pulseaudio/internal/PulseaudioHandlerFactory.java
Outdated
Show resolved
Hide resolved
...ng.pulseaudio/src/main/java/org/openhab/binding/pulseaudio/internal/PulseAudioAudioSink.java
Outdated
Show resolved
Hide resolved
...ng.pulseaudio/src/main/java/org/openhab/binding/pulseaudio/internal/PulseAudioAudioSink.java
Outdated
Show resolved
Hide resolved
...ng.pulseaudio/src/main/java/org/openhab/binding/pulseaudio/internal/PulseAudioAudioSink.java
Outdated
Show resolved
Hide resolved
Apply code review Signed-off-by: Gwendal Roulleau <[email protected]>
lolodomo
added
the
enhancement
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Jul 8, 2023
* [pulseaudio] Make the process method asynchronous And use the new 'complete' system to signal core that the sound is fully played. --------- Signed-off-by: Gwendal Roulleau <[email protected]>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Aug 9, 2023
* [pulseaudio] Make the process method asynchronous And use the new 'complete' system to signal core that the sound is fully played. --------- Signed-off-by: Gwendal Roulleau <[email protected]> Signed-off-by: Matt Myers <[email protected]>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* [pulseaudio] Make the process method asynchronous And use the new 'complete' system to signal core that the sound is fully played. --------- Signed-off-by: Gwendal Roulleau <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following some rewrite with openhab/openhab-core#3461
Implementation remark : I do not use AudioSinkSync or AudioSinkAsync as a base class because the PulseAudioAudioSink already extends another class. Separing concern does not seem a good idea as it breaks the symetry with AudioSource.