[onkyo] Support for more audio streams through the HTTP audio servlet #15117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
added
the
enhancement
|
@dalgwen for information and feedback |
lolodomo
force-pushed
the
onkyo_sink
branch
3 times, most recently
from
791d2bc to
99b30a0
Compare
lolodomo
force-pushed
the
onkyo_sink
branch
2 times, most recently
from
3d914ce to
950dedf
Compare
LGTM : the new capabilities are used as intended. |
|
Do we set the timeout for 5 or to 10 for more security ? |
|
By security, I finally set the timeout to 10s. @kaikreuzer : this is ready for a final review. |
Related to openhab#15113 Signed-off-by: Laurent Garnier <[email protected]>
jlaur
requested changes
Jul 12, 2023
...nhab.binding.onkyo/src/main/java/org/openhab/binding/onkyo/internal/OnkyoHandlerFactory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Laurent Garnier <[email protected]>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…openhab#15117) * [onkyo] Support for more audio streams through the HTTP audio servlet Related to openhab#15113 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #15113
Signed-off-by: Laurent Garnier [email protected]