Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rrd4j] Improve timestamp handling #15107

Merged
merged 2 commits into from
Jun 18, 2023
Merged

[rrd4j] Improve timestamp handling #15107

merged 2 commits into from
Jun 18, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jun 18, 2023

Fixes #15054

Storage retry is now tried immediately, not scheduled. This should prevent having the "next" value being stored before the current one.

@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of an add-on label Jun 18, 2023
@J-N-K J-N-K requested a review from a team as a code owner June 18, 2023 10:33
@J-N-K
spotless
d9794b3 
Signed-off-by: Jan N. Klug <[email protected]>
kaikreuzer
kaikreuzer approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit 07e6403 into openhab:main Jun 18, 2023
@kaikreuzer kaikreuzer added this to the 4.0 milestone Jun 18, 2023
@J-N-K J-N-K deleted the rrd4j branch June 18, 2023 19:19
tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023
@J-N-K @tb4jc
[rrd4j] Improve timestamp handling (openhab#15107)
5a46b8a 
* [rrd4j] Improve timestamp handling

Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Thomas Burri <[email protected]>
@Elle4u
Copy link

Elle4u commented Jul 3, 2023

It is better, now, with the new milestone but I still have the following messages:

2023-07-03 19:21:08.296 [WARN ] [d4j.internal.RRD4jPersistenceService] - RRD4J does not support adding past value this=1688404860, last update=1688404865. Discarding E3DC_Household - 616.0 2023-07-03 19:22:07.951 [WARN ] [d4j.internal.RRD4jPersistenceService] - RRD4J does not support adding past value this=1688404920, last update=1688404925. Discarding E3DC_Household - 462.0 2023-07-03 19:22:07.952 [WARN ] [d4j.internal.RRD4jPersistenceService] - RRD4J does not support adding past value this=1688404920, last update=1688404925. Discarding E3DC_BatteryCharge - 639.0 2023-07-03 19:24:08.459 [WARN ] [d4j.internal.RRD4jPersistenceService] - RRD4J does not support adding past value this=1688405042, last update=1688405047. Discarding E3DC_PVPower - 1225.0

matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
@J-N-K @matchews
[rrd4j] Improve timestamp handling (openhab#15107)
790c1f5 
* [rrd4j] Improve timestamp handling

Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Matt Myers <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@J-N-K @austvik
[rrd4j] Improve timestamp handling (openhab#15107)
54d55c3 
* [rrd4j] Improve timestamp handling

Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

[rrd4j] Could not persist to rrd4j database: Bad sample time
3 participants
@J-N-K @Elle4u @kaikreuzer