-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[renault] Add support for MyDacia accounts and Dacia Spring car #15101
Conversation
Signed-off-by: Doug Culnane <[email protected]>
Signed-off-by: Doug Culnane <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please generate the I18N properties file to get the new strings included.
bundles/org.openhab.binding.renault/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
…thing/thing-types.xml Co-authored-by: Jacob Laursen <[email protected]> Signed-off-by: Doug Culnane <[email protected]>
Signed-off-by: Doug Culnane <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jlaur Thanks for the quick review. |
…hab#15101) * [renault] Support for MyDacia accounts and Dacia Spring car Signed-off-by: Doug Culnane <[email protected]> Signed-off-by: Thomas Burri <[email protected]>
…hab#15101) * [renault] Support for MyDacia accounts and Dacia Spring car Signed-off-by: Doug Culnane <[email protected]> Signed-off-by: Matt Myers <[email protected]>
…hab#15101) * [renault] Support for MyDacia accounts and Dacia Spring car Signed-off-by: Doug Culnane <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
This PR adds an "Account Type" configuration option so that uses can select (the non-default) type for MyDacia Cars. Request for this enhancement was made here: #14227