Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dynamodb] Changes required after API changes in core framework #14966

Merged
merged 1 commit into from
May 10, 2023
Merged

[dynamodb] Changes required after API changes in core framework #14966

merged 1 commit into from
May 10, 2023

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented May 10, 2023 •
edited
Loading

Changes in openhab/openhab-core#3481 broke this service due to a breaking API change in NumberItem class (constructor).

Related to openhab/openhab-core#3600

Signed-off-by: Laurent Garnier [email protected]

@lolodomo lolodomo requested a review from ssalonen as a code owner May 10, 2023 14:47
@lolodomo lolodomo mentioned this pull request May 10, 2023
Closed
@lolodomo
Copy link
Contributor Author

@ssalonen for help as code maintainer
@J-N-K for information

@J-N-K
Copy link
Member

J-N-K commented May 10, 2023

Why don't you inject the
UnitProvider in the constructor (similar to the ItemRegistry)?

@lolodomo
Copy link
Contributor Author

Why don't you inject the UnitProvider in the constructor (similar to the ItemRegistry)?

Good idea.

@lolodomo
[dynamodb] Changes required after API changes in core framework
a860523 
Changes in openhab/openhab-core#3481 broke this service due to an
breaking API change in NumberItem class (constructor).

Related to openhab/openhab-core#3600

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo changed the title [dynamodb] Changes required to build the binding with success [dynamodb] Changes required after API changes in core framework May 10, 2023
@lolodomo
Copy link
Contributor Author

Ok, it is now fully fixed.

@lolodomo
Copy link
Contributor Author

@openhab/add-ons-maintainers : please review and merge ASAP so that we can get new snapshots again.

@lolodomo lolodomo added bug An unexpected problem or unintended behavior of an add-on test labels May 10, 2023
jlaur
jlaur approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit 518283d into openhab:main May 10, 2023
@jlaur jlaur added this to the 4.0 milestone May 10, 2023
@jlaur jlaur added the regression Regression that happened during the development of a release. Not shown on final release notes. label May 10, 2023
@lolodomo lolodomo deleted the dynamodb_fix_tests branch May 10, 2023 16:14
@lolodomo
Copy link
Contributor Author

Thank you @jlaur
@kaikreuzer @J-N-K : please start the build of a new snapshot.

@jlaur
Copy link
Contributor

jlaur commented May 10, 2023

@lolodomo - FYI, build failed because of another test:

https://github.com/openhab/openhab-addons/actions/runs/4939114188/jobs/8829556438

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project org.openhab.binding.modbus.tests: Compilation failure
Error:  /home/runner/work/openhab-addons/openhab-addons/itests/org.openhab.binding.modbus.tests/src/main/java/org/openhab/binding/modbus/tests/AbstractModbusOSGiTest.java:[159,27] The constructor org.openhab.core.library.CoreItemFactory() is undefined

@lolodomo
Copy link
Contributor Author

@lolodomo - FYI, build failed because of another test

I certainly forgot to grep in integration tests.
I will continue to share in openhab/openhab-core#3600
This would have been better if J-N-K had checked the build of addons before the merge of the core change.

@lolodomo
Copy link
Contributor Author

openhab/openhab-core#3600 (comment)
I see at least 3 bundles to fix for integration tests.

tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023
@lolodomo @tburri-alstom
[dynamodb] Changes required after API changes in core framework (open…
03e3716 
…hab#14966)

Changes in openhab/openhab-core#3481 broke this service due to an
breaking API change in NumberItem class (constructor).

Related to openhab/openhab-core#3600

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Thomas Burri <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
@lolodomo @matchews
[dynamodb] Changes required after API changes in core framework (open…
971bac5 
…hab#14966)

Changes in openhab/openhab-core#3481 broke this service due to an
breaking API change in NumberItem class (constructor).

Related to openhab/openhab-core#3600

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Matt Myers <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@lolodomo @austvik
[dynamodb] Changes required after API changes in core framework (open…
c1918f9 
…hab#14966)

Changes in openhab/openhab-core#3481 broke this service due to an
breaking API change in NumberItem class (constructor).

Related to openhab/openhab-core#3600

Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@ssalonen ssalonen Awaiting requested review from ssalonen ssalonen is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes. test
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lolodomo @J-N-K @jlaur