Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[innogysmarthome] Remove binding (replaced by livisismarthome) #14675

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

Novanic
Copy link
Contributor

@Novanic Novanic commented Mar 25, 2023

Remove binding (replaced by livisismarthome)

See issue #14674 for more information.

Remove binding (replaced by livisismarthome)

Signed-off-by: Sven Strohschein <[email protected]>
Signed-off-by: Sven Strohschein <[email protected]>
@Novanic Novanic requested review from ollie-dev and a team as code owners March 25, 2023 19:03
@Novanic
Copy link
Contributor Author

Novanic commented Mar 26, 2023

Hello @wborn , is it normal, that the build fails (because the building binding was removed) or is there something which has to get changed before the pull request can get merged? Thanks :-)

@wborn
Copy link
Member

wborn commented Mar 26, 2023

It's an issue in the build scripts. They should do a full build instead of a partial build in case an add-on gets removed. So we should make them a little bit smarter. 😉 Haven't found the time yet to look into this edge case.

@wborn
Copy link
Member

wborn commented Mar 26, 2023

Haven't found the time yet to look into this edge case.

It was an easy fix, so I was able to scrap it from my todo list with #14680. 🙂

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

The only issue I see is that it may be a bit too early to already remove this when it is only retired in about a year.

See: https://community.livisi.de/paq-en/

On this page we want to answer some of your questions regarding the retirement of the LIVISI SmartHome Services on March 1st 2024.

@jlaur
Copy link
Contributor

jlaur commented Mar 26, 2023

The only issue I see is that it may be a bit too early to already remove this when it is only retired in about a year.

I agree.

@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Mar 26, 2023
@jlaur jlaur changed the title [innogysmarthome] Remove binding (replaced by livisismarthome) #14674 [innogysmarthome] Remove binding (replaced by livisismarthome) Mar 26, 2023
@Novanic
Copy link
Contributor Author

Novanic commented Mar 26, 2023

The changes look good to me.

The only issue I see is that it may be a bit too early to already remove this when it is only retired in about a year.

See: https://community.livisi.de/paq-en/

On this page we want to answer some of your questions regarding the retirement of the LIVISI SmartHome Services on March 1st 2024.

@wborn and @jlaur

Some arguments to remove the binding with OpenHAB 4.0 (probably summer 2023):

  • The official apps are supported until March 2024, the binding isn't part of that.
  • The vendor wishes that more users are switching to the local API to reduce the traffic and costs and it's also the vendors wish to remove the old binding.
  • Originally it was planned to remove the binding with OpenHAB 3.4.0.
  • The binding is documented as deprecated for 1 year (from OpenHAB 3.3 / summer 2022 till OpenHAB 4.0 / summer 2023). The users have at least 1 year time to switch to the new binding.
  • I think the major release of OpenHAB 4.0.0 is a good time. Why should a deprecated binding move to a new major version and why should users upgrade to the next major release 4.0.0 but don't want to switch to the new binding?
  • Users which currently don't want to switch to the new binding till March 2024, they could stay on OpenHAB 3.x.
  • As I know the vendor has already started to block some client IDs...

@Novanic
Copy link
Contributor Author

Novanic commented Mar 26, 2023

@wborn and @jlaur

I got now the info that the vendor has already shutdown the cloud API for OpenHAB this month (via the client id). The binding is already not working anymore. Therefore the binding can now get removed.

@jlaur
Copy link
Contributor

jlaur commented Mar 26, 2023

Those are good and convincing arguments. Let's merge then!

@jlaur jlaur merged commit 2c710a2 into openhab:main Mar 26, 2023
@jlaur jlaur added this to the 4.0 milestone Mar 26, 2023
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
…ab#14675)

Remove binding (replaced by livisismarthome)

Signed-off-by: Sven Strohschein <[email protected]>
Signed-off-by: Sven Strohschein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[innogysmarthome] Remove binding (replaced by livisismarthome)
4 participants