-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[innogysmarthome] Remove binding (replaced by livisismarthome) #14675
[innogysmarthome] Remove binding (replaced by livisismarthome) #14675
Conversation
Remove binding (replaced by livisismarthome) Signed-off-by: Sven Strohschein <[email protected]> Signed-off-by: Sven Strohschein <[email protected]>
Hello @wborn , is it normal, that the build fails (because the building binding was removed) or is there something which has to get changed before the pull request can get merged? Thanks :-) |
It's an issue in the build scripts. They should do a full build instead of a partial build in case an add-on gets removed. So we should make them a little bit smarter. 😉 Haven't found the time yet to look into this edge case. |
It was an easy fix, so I was able to scrap it from my todo list with #14680. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me.
The only issue I see is that it may be a bit too early to already remove this when it is only retired in about a year.
See: https://community.livisi.de/paq-en/
On this page we want to answer some of your questions regarding the retirement of the LIVISI SmartHome Services on March 1st 2024.
I agree. |
Some arguments to remove the binding with OpenHAB 4.0 (probably summer 2023):
|
Those are good and convincing arguments. Let's merge then! |
…ab#14675) Remove binding (replaced by livisismarthome) Signed-off-by: Sven Strohschein <[email protected]> Signed-off-by: Sven Strohschein <[email protected]>
Remove binding (replaced by livisismarthome)
See issue #14674 for more information.