[deconz] [Proposal] Normalize valve value to zigbee specification #14259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deconz just passes the PIHeatingDemand without any normalization to the relevant range of valid values from the zigbee specification. This facility is a workaround until deconz is fixed. Signed-off-by: Daniel Demus <[email protected]>
holgerfriedrich
added
the
external bug
|
@danieldemus, @J-N-K - is this PR still relevant? The mentioned issue #11517 is fixed by #14622. |
|
It's not relevant for the ally thermostat any more, but I can see the solution pushes the problem to the non-conforming thermostats, extending it with some confusing behaviour (ie. up to 100 you get a percent, above 100 you get undef type). |
|
It can be fixed on deconz-side by adding a proper DDF, so it's a non-issue nowadays. |
danieldemus
deleted the
deconz-11517-normalize-valve-to-zigbee-specification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A suggestion to work around #11517.
Deconz just passes the PIHeatingDemand without any normalization to the relevant range of valid values from the zigbee
specification. The thermostat that was used as a template for the relevant code is unfortunately not standards compliant, so any standards compliant thermostats show incorrect valve values.
While it would be preferable to have this fixed in deconz itself, until that happens a workaround would be useful.
This PR is a suggestion to treat #11517.
Signed-off-by: Daniel Demus [email protected]