Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] Markdown improvements for bindings a to e #13859

Merged
merged 17 commits into from
Dec 7, 2022
Merged

[Documentation] Markdown improvements for bindings a to e #13859

merged 17 commits into from
Dec 7, 2022

Conversation

Confectrician
Copy link
Contributor

This is a first bulk pr for getting some consistency into the doc markdown files.

Reference for a general linting approach here: #13858
Discussion Reference for codeblock styles i have applied: openhab/openhab-docs#999

@Confectrician
Apply markdown fixes for bindings with letter _a_
a1eb53a 
Signed-off-by: Jerome Luckenbach <[email protected]>
@Confectrician
Apply markdown fixes for bindings with letter _b_
2c60355 
Signed-off-by: Jerome Luckenbach <[email protected]>
@Confectrician
Apply markdown fixes for bindings with letter _c_
479290d 
Signed-off-by: Jerome Luckenbach <[email protected]>
@Confectrician
Apply markdown fixes for bindings with letter _a_
dc19110 
Signed-off-by: Jerome Luckenbach <[email protected]>
@Confectrician
Apply markdown fixes for bindings with letter _d_
6628ec0 
Signed-off-by: Jerome Luckenbach <[email protected]>
@Confectrician
Apply markdown fixes for bindings with letter _e_
aa09aa1 
Signed-off-by: Jerome Luckenbach <[email protected]>
@Confectrician
Apply markdown fixes for bindings with letter _a_
a01e87a 
Signed-off-by: Jerome Luckenbach <[email protected]>
@Confectrician
Apply markdown fixes for bindings with letter _b_
fa2a87a 
Signed-off-by: Jerome Luckenbach <[email protected]>
@Confectrician
Apply markdown fixes for bindings with letter _c_
79ed2ce 
Signed-off-by: Jerome Luckenbach <[email protected]>
@Confectrician
Apply markdown fixes for bindings with letter _a_
e61c119 
Signed-off-by: Jerome Luckenbach <[email protected]>
@Confectrician
Apply markdown fixes for bindings with letter _d_
c2b7ae9 
Signed-off-by: Jerome Luckenbach <[email protected]>
@Confectrician
Apply markdown fixes for bindings with letter _e_
2fcf53b 
Signed-off-by: Jerome Luckenbach <[email protected]>
@Confectrician
Merge branch 'markdown-improvements' of github.com:Confectrician/open…
1243509 
…hab-addons into markdown-improvements

Signed-off-by: Jerome Luckenbach <[email protected]>
@Confectrician
Fix wrongly solved merge conflict.
e606b47 
Signed-off-by: Jerome Luckenbach <[email protected]>
hmerk
hmerk approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@hmerk hmerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlobstein mlobstein mentioned this pull request Dec 6, 2022
Merged
@wborn wborn mentioned this pull request Dec 7, 2022
Open
GiviMAD
GiviMAD approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@GiviMAD GiviMAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the androiddebugbridge binding

@Confectrician
Adress review comment.
20c4d55 
Signed-off-by: Jerome Luckenbach <[email protected]>
wborn
wborn approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too now!

@hypetsch
Copy link
Contributor

hypetsch commented Dec 7, 2022

LGTM for bsblan binding

boehan
boehan approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@boehan boehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for comfoair

Friesoch
Friesoch approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@Friesoch Friesoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Dominoswiss

@wborn wborn merged commit caf71f7 into openhab:main Dec 7, 2022
@wborn wborn added this to the 3.4 milestone Dec 7, 2022
@Confectrician Confectrician deleted the markdown-improvements branch December 7, 2022 21:14
morph166955 pushed a commit to morph166955/openhab-addons that referenced this pull request Dec 18, 2022
@Confectrician @morph166955
[Documentation] Markdown improvements for bindings a to e (openhab#13859
5976803 
)

Signed-off-by: Jerome Luckenbach <[email protected]>
Signed-off-by: Ben Rosenblum <[email protected]>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Dec 24, 2022
@Confectrician @andrasU
[Documentation] Markdown improvements for bindings a to e (openhab#13859
26a9f9d 
)

Signed-off-by: Jerome Luckenbach <[email protected]>
Signed-off-by: Andras Uhrin <[email protected]>
@Confectrician Confectrician mentioned this pull request Jan 2, 2023
Merged
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
@Confectrician @borazslo
[Documentation] Markdown improvements for bindings a to e (openhab#13859
07b63b2 
)

Signed-off-by: Jerome Luckenbach <[email protected]>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@Confectrician @psmedley
[Documentation] Markdown improvements for bindings a to e (openhab#13859
b49c442 
)

Signed-off-by: Jerome Luckenbach <[email protected]>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@Confectrician @nemerdaud
[Documentation] Markdown improvements for bindings a to e (openhab#13859
f1e13c3 
)

Signed-off-by: Jerome Luckenbach <[email protected]>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 6, 2024
@Confectrician @andrasU
[Documentation] Markdown improvements for bindings a to e (openhab#13859
384e4e9 
)

Signed-off-by: Jerome Luckenbach <[email protected]>
Signed-off-by: Andras Uhrin <[email protected]>
@jlaur jlaur mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur left review comments

@florian-h05 florian-h05 florian-h05 approved these changes

@Friesoch Friesoch Friesoch approved these changes

@mlobstein mlobstein mlobstein approved these changes

@hypetsch hypetsch hypetsch approved these changes

@wborn wborn wborn approved these changes

@GiviMAD GiviMAD GiviMAD approved these changes

@boehan boehan boehan approved these changes

@hmerk hmerk hmerk approved these changes

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

@Nebula83 Nebula83 Awaiting requested review from Nebula83 Nebula83 is a code owner

@klocsson klocsson Awaiting requested review from klocsson klocsson is a code owner

@Hilbrand Hilbrand Awaiting requested review from Hilbrand Hilbrand is a code owner

@fruggy83 fruggy83 Awaiting requested review from fruggy83 fruggy83 is a code owner

@gdolfen gdolfen Awaiting requested review from gdolfen gdolfen is a code owner

@mherwege mherwege Awaiting requested review from mherwege mherwege is a code owner

@jannegpriv jannegpriv Awaiting requested review from jannegpriv

@lolodomo lolodomo Awaiting requested review from lolodomo lolodomo is a code owner

@sibbi77 sibbi77 Awaiting requested review from sibbi77 sibbi77 is a code owner

@mhilbush mhilbush Awaiting requested review from mhilbush mhilbush is a code owner

@alexf2015 alexf2015 Awaiting requested review from alexf2015 alexf2015 is a code owner

@limdul79 limdul79 Awaiting requested review from limdul79 limdul79 is a code owner

@DerOetzi DerOetzi Awaiting requested review from DerOetzi DerOetzi is a code owner

@RSStephens RSStephens Awaiting requested review from RSStephens RSStephens is a code owner

@andrew-schofield andrew-schofield Awaiting requested review from andrew-schofield andrew-schofield is a code owner

@rmichalak rmichalak Awaiting requested review from rmichalak rmichalak is a code owner

@soenkekueper soenkekueper Awaiting requested review from soenkekueper soenkekueper is a code owner

@jwveldhuis jwveldhuis Awaiting requested review from jwveldhuis jwveldhuis is a code owner

@lujop lujop Awaiting requested review from lujop lujop is a code owner

@pravussum pravussum Awaiting requested review from pravussum pravussum is a code owner

@rs22 rs22 Awaiting requested review from rs22 rs22 is a code owner

@caffineehacker caffineehacker Awaiting requested review from caffineehacker caffineehacker is a code owner

@BobRak BobRak Awaiting requested review from BobRak BobRak is a code owner

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

@jpharvey jpharvey Awaiting requested review from jpharvey jpharvey is a code owner

@gedejong gedejong Awaiting requested review from gedejong gedejong is a code owner

@MrRonfo MrRonfo Awaiting requested review from MrRonfo MrRonfo is a code owner

@marvkis marvkis Awaiting requested review from marvkis marvkis is a code owner

@tratho tratho Awaiting requested review from tratho tratho is a code owner

@coeing coeing Awaiting requested review from coeing

@GerdZanker GerdZanker Awaiting requested review from GerdZanker GerdZanker is a code owner

@jofleck jofleck Awaiting requested review from jofleck jofleck is a code owner

@ssalonen ssalonen Awaiting requested review from ssalonen ssalonen is a code owner

@cpmeister cpmeister Awaiting requested review from cpmeister cpmeister is a code owner

@pfink pfink Awaiting requested review from pfink pfink is a code owner

@blafois blafois Awaiting requested review from blafois blafois is a code owner

@cdjackson cdjackson Awaiting requested review from cdjackson cdjackson is a code owner

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

@digitaldan digitaldan Awaiting requested review from digitaldan digitaldan is a code owner

@tmrobert8 tmrobert8 Awaiting requested review from tmrobert8

@gerrieg gerrieg Awaiting requested review from gerrieg

@paphko paphko Awaiting requested review from paphko paphko is a code owner

@mgeramb mgeramb Awaiting requested review from mgeramb mgeramb is a code owner

@OLibutzki OLibutzki Awaiting requested review from OLibutzki

@3cky 3cky Awaiting requested review from 3cky 3cky is a code owner

@kubawolanin kubawolanin Awaiting requested review from kubawolanin

@aurelio1 aurelio1 Awaiting requested review from aurelio1 aurelio1 is a code owner

@Wolfgang1966 Wolfgang1966 Awaiting requested review from Wolfgang1966 Wolfgang1966 is a code owner

@bobadair bobadair Awaiting requested review from bobadair bobadair is a code owner

@billfor billfor Awaiting requested review from billfor billfor is a code owner

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
10 participants
@Confectrician @hypetsch @hmerk @boehan @GiviMAD @wborn @jlaur @mlobstein @Friesoch @florian-h05