[androiddebugbridge] Fix volume channel for android 11/12 #13828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Álvarez <[email protected]>
|
I'll add another commit, I have discovered how to get the max volume level on android 12, can be gathered from the device properties |
Signed-off-by: Miguel Álvarez <[email protected]>
Signed-off-by: Miguel Álvarez <[email protected]>
|
Now it's ready. I left the deviceMaxVolume config in case other device miss this property. |
Signed-off-by: Miguel Álvarez <[email protected]>
lolodomo
requested changes
Dec 3, 2022
bundles/org.openhab.binding.androiddebugbridge/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.androiddebugbridge/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.androiddebugbridge/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Miguel Álvarez <[email protected]>
lolodomo
requested changes
Dec 3, 2022
bundles/org.openhab.binding.androiddebugbridge/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
Signed-off-by: Miguel Álvarez <[email protected]>
morph166955
pushed a commit
to morph166955/openhab-addons
that referenced
this pull request
Dec 18, 2022
) * [androiddebugbridge] Fix volume channel for android 11/12 * [androiddebugbridge] Try get max volume level from device properties * [androiddebugbridge] Fixes reported code analysis * [androiddebugbridge] Fix comparison Signed-off-by: Miguel Álvarez <[email protected]> Signed-off-by: Ben Rosenblum <[email protected]>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Dec 24, 2022
) * [androiddebugbridge] Fix volume channel for android 11/12 * [androiddebugbridge] Try get max volume level from device properties * [androiddebugbridge] Fixes reported code analysis * [androiddebugbridge] Fix comparison Signed-off-by: Miguel Álvarez <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>
borazslo
pushed a commit
to borazslo/openhab-mideaac-addon
that referenced
this pull request
Jan 8, 2023
) * [androiddebugbridge] Fix volume channel for android 11/12 * [androiddebugbridge] Try get max volume level from device properties * [androiddebugbridge] Fixes reported code analysis * [androiddebugbridge] Fix comparison Signed-off-by: Miguel Álvarez <[email protected]>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
) * [androiddebugbridge] Fix volume channel for android 11/12 * [androiddebugbridge] Try get max volume level from device properties * [androiddebugbridge] Fixes reported code analysis * [androiddebugbridge] Fix comparison Signed-off-by: Miguel Álvarez <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
) * [androiddebugbridge] Fix volume channel for android 11/12 * [androiddebugbridge] Try get max volume level from device properties * [androiddebugbridge] Fixes reported code analysis * [androiddebugbridge] Fix comparison Signed-off-by: Miguel Álvarez <[email protected]>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Jan 6, 2024
) * [androiddebugbridge] Fix volume channel for android 11/12 * [androiddebugbridge] Try get max volume level from device properties * [androiddebugbridge] Fixes reported code analysis * [androiddebugbridge] Fix comparison Signed-off-by: Miguel Álvarez <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Device "ChromeCast with Google TV" was recently updated to android 12.
I found out that volume channel is not working anymore (neither should work on android 11), it is due the 'media' cli removal on android 11.
This PR aims to fix the volume channel for both versions (just tested on android 12).
Regards!
Signed-off-by: Miguel Álvarez [email protected]