-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rollershutterposition] Initial contribution #13259
Conversation
dd09cc1
to
c9c6d8e
Compare
a9fd172
to
f0d71b8
Compare
f0d71b8
to
a61c85f
Compare
f292924
to
bb580ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Some minor feedback provided.
...ava/org/openhab/transform/rollershutterposition/internal/RollerShutterPositionConstants.java
Outdated
Show resolved
Hide resolved
...ava/org/openhab/transform/rollershutterposition/internal/RollerShutterPositionConstants.java
Outdated
Show resolved
Hide resolved
...ava/org/openhab/transform/rollershutterposition/internal/RollerShutterPositionConstants.java
Outdated
Show resolved
Hide resolved
a61c85f
to
55eace3
Compare
Signed-off-by: Jeff James <[email protected]>
Signed-off-by: Jeff James <[email protected]>
Signed-off-by: Jeff James <[email protected]>
Signed-off-by: Jeff James <[email protected]>
55eace3
to
38482a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few last comments.
...rg/openhab/transform/rollershutterposition/internal/RollerShutterPositionProfileFactory.java
Outdated
Show resolved
Hide resolved
...org/openhab/transform/rollershutterposition/internal/config/RollerShutterPositionConfig.java
Outdated
Show resolved
Hide resolved
...nhab.transform.rollershutterposition/src/main/resources/OH-INF/i18n/rollershutter.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Jeff James <[email protected]>
38482a1
to
6459021
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this transformation add-on. LGTM.
* Initial contribution Signed-off-by: Jeff James <[email protected]>
@jsjames - can you create a follow-up PR adding the file |
@jsjames - gentle ping. 🙂 |
Will definitely get to this this weekend. Just traveling now. On Mar 8, 2023, at 11:57 PM, Jacob Laursen ***@***.***> wrote:
@jsjames - gentle ping. 🙂
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
That's okay. I have created #14559 trying to squeeze it into the M1 build. You might want to have a look - I copied name and description from pom/readme. |
* Initial contribution Signed-off-by: Jeff James <[email protected]> Signed-off-by: miloit <[email protected]>
* Initial contribution Signed-off-by: Jeff James <[email protected]>
Is there a possibility to add functionality for blinds that can open/close (angle of the blades)? I mean the type that opens the blades when going up and closes them when going down. So depending on the wanted open/close state, the shutter has to move in the opposite direction for a short time at the end. Also some shutters like mine have a feedback for full open and fully closed. It would be nice if it could be used to adjust the times automatically, and/or to recalibrate. |
What item type are you using to control the open/close - a Contact or Switch? I think this would be possible and could look at this with you.
I don't follow what you mean here?
I think that would be possible as well. Let me know if you want to work on this together? |
Wow, thank you! I'm talking about this type of shutter: I'm using the elero binding, but it should be adaptable to other bindings as well The shutter is controlled via 0..100%, and responds also with 0..100. it's kinda awkward as it ignores most commands and also only reports 0, 50, and 100. But generally speaking, it is controlled via UP, DOWN, and STOP. So if you go down, but want the blades open, you have to move it down to the desired position, STOP, and then go UP again for a second. The elero binding even has separate commands that do that for you (OPEN and CLOSE). They are really common here (not generally elero, but the type of blinds that have tilting blades). I'm unsure how this could be added in a general way to this function (feedback fully open, feedback fully closed, and the tilting command after reaching the target position) |
In looking at the elerotransmitterstick binding, I don't see how it supports the OPEN/CLOSE commands, it looks like there is only a rollershutter type channel and a read-only status channel. Am I looking at the right binding? If I understand how the shade works, the basic function of the transform should work as-is if you set the uptime/downtime to equal the total time it takes for the blind to tilt open/close + move the shade fully up or down. The angle of the blades would just be controlled based on the last few percentages (i.e. 98%, 99%, 100%) - i'm not sure what percent of the tilt time is to the total time of tilt time down + close time so this may not give the granularity you want. But the limit here is how fast openhab + transmitter will send a UP command and then a quick STOP command once the position is reached is likely going to limit the level of accuracy you can achieve. An enhancement could be made to the transform so that if the value being set is close to the extreme (i.e. 98% closed), then it could recalibrate by sending DOWN command to get to 100% and then send UP command followed by STOP. Regarding looking at the status to recalibrate - the transform will recalibrate automatically to the full up / down position even without feedback from the handler. If a 0% or 100% command is issued, the transform will an UP or DOWN command to the handler without a stop. |
You're right. It does not support close and open commands. As for the percentages, you're right that this should work. In a perfect world, I would imagine the following: Im also willing to test if I can get the transform running in OH3.4? I sadly can't upgrade to 4.0 just for testing at the moment. Also this can wait is is not urgent (it's just a wishful idea :) ) Thanks very much! |
There is as version of the transform compiled for openhab3 here: https://drive.google.com/file/d/1b-3cpLOFW2T51h_2tWvq1zagcwvSpVVs/view?usp=share_link which you can try. Since this is a transform, I don't believe it can accept different types of commands vs. what the item type can support - so a Rollershutter item type would only support UP, DOWN, STOP and percent. If you are thinking to combine multiple items to the handler via the transform, I don't believe that would be supported either. I wonder if the best way to handle this is with scripts? |
Thanks, I guess then it won't make sense to adjust anything, as you would need to control the tilt independently from the opening. I will have to go via scripts then I guess :) wouldve just been nice to have. Thanks anyway! |
* Initial contribution Signed-off-by: Jeff James <[email protected]>
Rollershutter Position emulation
Description
This transform will emulate setting of absolute position for rollershutters which only support Up/Down/Stop commands. By specifying the time it takes for the rollershutter to fully extend or close, the transform will estimate the time it will take for the rollershutter to move to an absolute position.