Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify how we get a string value from an item for thermostat modes.… #1276

Merged
merged 1 commit into from
Sep 30, 2016
Merged

Simplify how we get a string value from an item for thermostat modes.… #1276

merged 1 commit into from
Sep 30, 2016

Conversation

digitaldan
Copy link
Contributor

… Fixes #1275

Signed-off-by: Dan Cunningham [email protected]

@digitaldan
Copy link
Contributor Author

digitaldan commented Sep 30, 2016 •
edited
Loading

@beowulfe not sure if there was a reason to cal getStateAs(StringType.class) to get a StringType before calling toString() on the state, but this was not working for NumberItems. I think calling toString() on the items getState() returned state should suffice is all cases.

@kaikreuzer kaikreuzer merged commit 28639a8 into openhab:master Sep 30, 2016
@andylintner
Copy link

Nope, no particular reason - this should work. It does relate to the discussion here on the ontology and enumerated values: eclipse-archived/smarthome#1093

@kaikreuzer kaikreuzer modified the milestone: 2.0.0 Jan 17, 2017
@digitaldan digitaldan deleted the homekit-thermo-fix branch October 25, 2021 03:57
Flole998 pushed a commit to Flole998/openhab-addons that referenced this pull request Dec 30, 2021
@cweitkamp @wborn
Added missing JavaDoc to 'createGroupStateChangedEvent' method (openh…
7130988 
…ab#1276)

Signed-off-by: Christoph Weitkamp <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Aug 12, 2023
@fwolter
Extend types of Thing Configuration mappings (openhab#1276)
a7c7182 
Available types: https://github.com/openhab/openhab-core/blob/master/bundles/org.openhab.core.config.core/src/main/java/org/openhab/core/config/core/internal/ConfigMapper.java#L128

Signed-off-by: Fabian Wolter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@digitaldan @andylintner @kaikreuzer