[OmniLink] Refactor parts of code #12246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes an unused trigger channel definition that was in OmnilinkBindingConstants.java. Signed-off-by: Ethan Dye <[email protected]>
ecdye
changed the title
jlaur
changed the title
ecdye
added
the
awaiting external dependency
This will be changed at a later date once the new version is properly released. Signed-off-by: Ethan Dye <[email protected]>
ecdye
changed the title
|
@jlaur This is ready for a review, I reverted the version bump for jomnilink, I'll make a new PR when it is ready. |
ecdye
removed
the
awaiting external dependency
|
Please open a PR in distro repo to add an entry in update.ps1 to mention the breaking change (channel renamed). |
|
Already done and merged see openhab/openhab-distro#1367 |
|
Perfect, thank you |
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
Signed-off-by: Ethan Dye <[email protected]> Signed-off-by: Nick Waterton <[email protected]>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jun 29, 2022
Signed-off-by: Ethan Dye <[email protected]>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
Signed-off-by: Ethan Dye <[email protected]>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
Signed-off-by: Ethan Dye <[email protected]> Signed-off-by: Andras Uhrin <[email protected]>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
Signed-off-by: Ethan Dye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes an unused trigger channel definition that was in
OmnilinkBindingConstants.java.
Related-to openhab-distro#1367
Signed-off-by: Ethan Dye [email protected]