-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[netatmo] Null annotations #7913
Comments
Ok, thank you. I think it's a good idea to refactor this one-time, that may be less work when done one-time and after that it is easier to make "correct" changes. ;-) There are about 30 classes within the binding, 6 are currently annotated with NonNullByDefault. |
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
Related to #7913 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
To finish the job, I msut wait for the merge of #7968 |
Related to #7913 Signed-off-by: Laurent Garnier <[email protected]>
Fix openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
Fix openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
Fix openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
Fix openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
Fix openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
Fix openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
Fix openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
Fix openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
@clinique : is there a valid reason that for the homecoach you just get the first device while for the weather station for example you apply a filter on the id ? My feeling is that the filter on the id was to be sure to get a device in case the provided id was wrong. |
Fix openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo : the homecoach part has not been developped by me so there may be possible enhancements I did not see |
Fix openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
Fix openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
OK, I fixed it in my PR. Please note that I also suppressed the usage of Optional in class fields and method arguments after reading that it is not recommended (Optional only recommended as return of methods). |
* [netatmo] Null annotations Part 3 of 3 Fix #7913 * Video status only set when there is a video in the event * Add a setting to enable/disable the background discovery Fix #8083 * Cache Optional result in local variable Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
* [netatmo] Null annotations Part 3 of 3 Fix openhab#7913 * Video status only set when there is a video in the event * Add a setting to enable/disable the background discovery Fix openhab#8083 * Cache Optional result in local variable Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: CSchlipp <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: CSchlipp <[email protected]>
* [netatmo] Null annotations Part 3 of 3 Fix openhab#7913 * Video status only set when there is a video in the event * Add a setting to enable/disable the background discovery Fix openhab#8083 * Cache Optional result in local variable Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: CSchlipp <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: MPH80 <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: MPH80 <[email protected]>
* [netatmo] Null annotations Part 3 of 3 Fix openhab#7913 * Video status only set when there is a video in the event * Add a setting to enable/disable the background discovery Fix openhab#8083 * Cache Optional result in local variable Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: MPH80 <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
* [netatmo] Null annotations Part 3 of 3 Fix openhab#7913 * Video status only set when there is a video in the event * Add a setting to enable/disable the background discovery Fix openhab#8083 * Cache Optional result in local variable Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
* [netatmo] Null annotations Part 3 of 3 Fix openhab#7913 * Video status only set when there is a video in the event * Add a setting to enable/disable the background discovery Fix openhab#8083 * Cache Optional result in local variable Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
* [netatmo] Null annotations Part 3 of 3 Fix openhab#7913 * Video status only set when there is a video in the event * Add a setting to enable/disable the background discovery Fix openhab#8083 * Cache Optional result in local variable Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
* [netatmo] Null annotations Part 3 of 3 Fix openhab#7913 * Video status only set when there is a video in the event * Add a setting to enable/disable the background discovery Fix openhab#8083 * Cache Optional result in local variable Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
* [netatmo] Null annotations Part 3 of 3 Fix openhab#7913 * Video status only set when there is a video in the event * Add a setting to enable/disable the background discovery Fix openhab#8083 * Cache Optional result in local variable Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
Related to openhab#7913 Signed-off-by: Laurent Garnier <[email protected]>
* [netatmo] Null annotations Part 3 of 3 Fix openhab#7913 * Video status only set when there is a video in the event * Add a setting to enable/disable the background discovery Fix openhab#8083 * Cache Optional result in local variable Signed-off-by: Laurent Garnier <[email protected]>
@clinique @Novanic : for your information, I will add null annotations on all classes in the Netatmo binding.
We have many classes but it should not be too much difficult I think.
I am now just waiting for a merge to get again a compiling version of the binding in branch 2.5.x.
The text was updated successfully, but these errors were encountered: